Attachment 111 Details for Bug 554 – Removes assert() statements

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

[patch] Removes assert() statements

80-libart-remove-asserts.patch (text/plain), 1.87 KB, created by Laurent Dard on 2011-10-27 15:04:46 CDT

(hide)

Description:

Filename:

MIME Type:

Creator: Laurent Dard

Created: 2011-10-27 15:04:46 CDT

Size: 1.87 KB

patch

obsolete

>Origin: other, http://bugzilla.gnome.org/155472#c1
>Bug-Gnome: http://bugzilla.gnome.org/155472
>Bug-Debian: http://bugs.debian.org/271111
>Bug-Trinity:http://bugs.pearsoncomputing.net/554
>Forwarded: http://bugzilla.gnome.org/155472#c1
>Author: Brian J. Tarricone <bjt23@cornell.edu>
>Applied-Upstream: no
>Description: Removes assert() statements that makes applications crash.
> Several applications (Xfce Desktop, Trinity Desktop, gok...) have been reported
> to crash when trying to render SVG files, because of asserts in the
> 'art_render_gradient_linear_render_8' function, in file art_render_gradient.c.
> Now unmaintained by upstream (see http://bugzilla.gnome.org/155472#c4)
>--- libart-lgpl.orig/art_render_gradient.c.orig	2004-10-15 00:41:51.444732640 -0700
>+++ libart-lgpl/art_render_gradient.c	2004-10-15 00:45:47.125903656 -0700
>@@ -30,7 +30,9 @@
> #include <stdlib.h>
> #include <stdio.h>
> #include <string.h>
>+#if 0
> #include <assert.h>
>+#endif
> 
> /* Hack to find out how to define alloca on different platforms.
>  * Modified version of glib/galloca.h.
>@@ -203,7 +205,9 @@
>     }
> 
>   printf ("WARNING! bad ix %d in calc_color_at() [internal error]\n", ix);
>+#if 0
>   assert (0);
>+#endif
> }
> 
> static void
>@@ -331,6 +335,7 @@
>   printf ("Initial ix: %d\n", ix);
> #endif
>   
>+#if 0
>   assert (ix > 0);
>   assert (ix < n_stops);
>   assert ((stops[ix-1].offset <= offset_fraction + EPSILON) ||
>@@ -344,6 +349,17 @@
>   assert ((offset_fraction != stops[ix].offset) ||
> 	  (d_offset <= 0.0));
>   */
>+#else
>+  if (!( (ix > 0) && (ix < n_stops)
>+         && ((stops[ix-1].offset <= offset_fraction + EPSILON) ||
>+             ((stops[ix].offset > (1.0 - EPSILON))
>+              && (offset_fraction < EPSILON /* == 0.0*/)))
>+         && (offset_fraction <= stops[ix].offset)))
>+  {
>+    printf ("art_render_gradient.c:%d: Old assert() failed!\n", __LINE__);
>+    return;
>+  }
>+#endif
>   
>   while (width > 0)
>     {

Actions: View | Diff

Attachments on bug 554: 111 | 541 | 544 | 545 | 554