Attachment 1153 Details for Bug 1399 – Patch with usability improvements to taskbar config dialogs

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

[patch] Patch with usability improvements to taskbar config dialogs

tdebase-global-taskbar.diff (text/plain), 10.27 KB, created by Darrell on 2013-04-11 17:22:57 CDT

(hide)

Description:

Filename:

MIME Type:

Creator: Darrell

Created: 2013-04-11 17:22:57 CDT

Size: 10.27 KB

patch

obsolete

>diff -urN tdebase/kcontrol/taskbar/kcmtaskbar.cpp tdebase.new/kcontrol/taskbar/kcmtaskbar.cpp
>--- tdebase/kcontrol/taskbar/kcmtaskbar.cpp	2013-04-11 11:55:25.000000000 -0500
>+++ tdebase.new/kcontrol/taskbar/kcmtaskbar.cpp	2013-04-11 15:23:46.077864089 -0500
>@@ -276,6 +276,7 @@
> 		m_widget->globalConfigReload->hide();
> 		m_widget->globalConfigEdit->hide();
> 		m_widget->kcfg_UseGlobalSettings->hide();
>+ m_widget->globalConfigReminder->hide();
> 	}
> 	else {
> 		m_widget->globalConfigWarning->hide();
>@@ -285,10 +286,12 @@
> 			m_widget->actionsGroup->hide();
> 			m_widget->globalConfigReload->hide();
> 			m_widget->globalConfigEdit->show();
>+ m_widget->globalConfigReminder->hide();
> 		}
> 		else {
> 			m_widget->taskbarGroup->show();
> 			m_widget->actionsGroup->show();
>+ m_widget->globalConfigReminder->show();
> 			// FIXME
> 			// Disable this feature until a method can be found to force the TDECModule to reload its settings from disk after the global settings have been copied!
> 			//m_widget->globalConfigReload->show();
>diff -urN tdebase/kcontrol/taskbar/kcmtaskbarui.ui tdebase.new/kcontrol/taskbar/kcmtaskbarui.ui
>--- tdebase/kcontrol/taskbar/kcmtaskbarui.ui	2013-04-10 21:16:17.000000000 -0500
>+++ tdebase.new/kcontrol/taskbar/kcmtaskbarui.ui	2013-04-11 16:41:10.450364369 -0500
>@@ -40,15 +40,15 @@
> 					<cstring>globalConfigWarning</cstring>
> 				</property>
> 				<property name="text">
>-					<string>&lt;b&gt;NOTE: This module is currently editing the global floating taskbar configuration.&lt;/b&gt;&lt;br&gt;To change the configuration of a specific Kicker taskbar applet, please use the corresponding Configure Taskbar menu option.</string>
>+					<string>&lt;b&gt;NOTE: Currently you are editing the global taskbar configuration.&lt;/b&gt;&lt;br&gt;To change the configuration of a specific taskbar (when using multiple taskbars), use the corresponding Configure Taskbar menu option, located in the taskbar handle popup menu.</string>
> 				</property>
> 			</widget>
>-			<widget class="TQCheckBox" row="0" column="0" rowspan="1" colspan="2">
>+			<widget class="TQCheckBox" row="1" column="0" rowspan="1" colspan="2">
> 				<property name="name">
> 					<cstring>kcfg_UseGlobalSettings</cstring>
> 				</property>
> 				<property name="text">
>-					<string>Use global floating taskbar configuration</string>
>+					<string>Use global taskbar configuration</string>
> 				</property>
> 				<property name="checked">
> 					<bool>true</bool>
>@@ -62,7 +62,7 @@
> 					<cstring>globalConfigReload</cstring>
> 				</property>
> 				<property name="text">
>-					<string>Overwrite current configuration with the current global floating taskbar configuration</string>
>+					<string>Overwrite current configuration with the current global taskbar configuration</string>
> 				</property>
> 			</widget>
> 			<widget class="TQPushButton" row="2" column="0" rowspan="1" colspan="2">
>@@ -70,9 +70,17 @@
> 					<cstring>globalConfigEdit</cstring>
> 				</property>
> 				<property name="text">
>-					<string>Edt global floating taskbar configuration</string>
>+					<string>Edit global taskbar configuration</string>
> 				</property>
> 			</widget>
>+ <widget class="TQLabel" row="2" column="0" rowspan="1" colspan="2">
>+ <property name="name">
>+ <cstring>globalConfigReminder</cstring>
>+ </property>
>+ <property name="text">
>+ <string>&lt;b&gt;NOTE:&lt;/b&gt; Currently you are editing the taskbar configuration for &lt;b&gt;only&lt;/b&gt; this taskbar.</string>
>+ </property>
>+ </widget>
> 		</grid>
> 	</widget>
> <widget class="TQButtonGroup">
>diff -urN tdebase/kicker/taskbar/taskbar.kcfg tdebase.new/kicker/taskbar/taskbar.kcfg
>--- tdebase/kicker/taskbar/taskbar.kcfg	2013-04-10 21:16:17.000000000 -0500
>+++ tdebase.new/kicker/taskbar/taskbar.kcfg	2013-04-11 16:06:31.584574086 -0500
>@@ -8,13 +8,13 @@
> <group name="General">
> <entry key="UseGlobalSettings" type="Bool" >
> <default>true</default>
>- <label>Use the global (floating) taskbar configuration</label>
>- <whatsthis>Turning this option off will cause the taskbar to ignore the global (floating) taskbar configuration, instead using a specific configuration for that particular taskbar.</whatsthis>
>+ <label>Use the global taskbar configuration</label>
>+ <whatsthis>Turning this option off will cause the taskbar to ignore the global taskbar configuration, instead using a specific configuration for that particular taskbar.</whatsthis>
> </entry>
> <entry key="ShowAllWindows" type="Bool" >
> <default>true</default>
> <label>Show windows from all desktops</label>
>- <whatsthis>Turning this option off will cause the taskbar to display only the windows on the current desktop. \n\nBy default, this option is selected and all windows are shown.</whatsthis>
>+ <whatsthis>Turning this option off will cause the taskbar to display only the windows on the current desktop. By default, this option is selected and all windows are shown.</whatsthis>
> </entry>
> <entry key="CycleWheel" type="Bool" >
> <default>true</default>
>@@ -24,7 +24,7 @@
> <entry key="ShowOnlyIconified" type="Bool" >
> <default>false</default>
> <label>Show only minimized windows</label>
>- <whatsthis>Select this option if you want the taskbar to display only minimized windows. \n\nBy default, this option is not selected and the taskbar will show all windows.</whatsthis>
>+ <whatsthis>Select this option if you want the taskbar to display only minimized windows. By default, this option is not selected and the taskbar will show all windows.</whatsthis>
> </entry>
> <entry key="GroupTasks" type="Enum" >
> <choices>
>@@ -40,7 +40,7 @@
> </choices>
> <default>GroupWhenFull</default>
> <label>Group similar tasks:</label>
>- <whatsthis>The taskbar can group similar windows into single buttons. When one of these window group buttons are clicked on a menu appears showing all the windows in that group. This can be especially useful with the Show all windows option.\n\nYou can set the taskbar to Never group windows, to Always group windows or to group windows only When the Taskbar is Full.\n\nBy default the taskbar groups windows when it is full.</whatsthis>
>+ <whatsthis>The taskbar can group similar windows into single buttons. When one of these window group buttons are clicked on a menu appears showing all the windows in that group. This can be especially useful with the Show all windows option. You can set the taskbar to Never group windows, to Always group windows or to group windows only When the Taskbar is Full. By default the taskbar groups windows when it is full.</whatsthis>
> </entry>
> <entry key="ShowTaskStates" type="Enum" >
> <choices>
>@@ -56,22 +56,22 @@
> </choices>
> 	 <default>ShowAll</default>
> <label>Show tasks with state:</label>
>-	 <whatsthis>The taskbar can show and/or hide tasks based on their current process state. Select Any to show all tasks regardless of current state.</whatsthis>
>+	 <whatsthis>The taskbar can show and/or hide tasks based on their current process state. Select Any to show all tasks regardless of current state.</whatsthis>
> </entry>
> <entry key="SortByDesktop" type="Bool" >
> <default>true</default>
> <label>Sort windows by desktop</label>
>- <whatsthis>Selecting this option causes the taskbar to show windows in order of the desktop they appear on.\n\nBy default this option is selected.</whatsthis>
>+ <whatsthis>Selecting this option causes the taskbar to show windows in order of the desktop they appear on. By default this option is selected.</whatsthis>
> </entry>
> <entry key="SortByApp" type="Bool" >
> <default>true</default>
> <label>Sort windows by application</label>
>- <whatsthis>Selecting this option causes the taskbar to show windows ordered by application.\n\nBy default this option is selected.</whatsthis>
>+ <whatsthis>Selecting this option causes the taskbar to show windows ordered by application. By default this option is selected.</whatsthis>
> </entry>
> <entry key="ShowIcon" type="Bool" >
> <default>true</default>
> <label>Show application icons</label>
>- <whatsthis>Select this option if you want window icons to appear along with their titles in the taskbar.\n\nBy default this option is selected.</whatsthis>
>+ <whatsthis>Select this option if you want window icons to appear along with their titles in the taskbar. By default this option is selected.</whatsthis>
> </entry>
> <entry key="MaximumButtonWidth" type="Int" >
> <default>200</default>
>@@ -88,7 +88,7 @@
> <entry key="ShowCurrentScreenOnly" type="Bool" >
> <default>false</default>
> <label>Show windows from all screens</label>
>- <whatsthis>Turning this option off will cause the taskbar to display only windows which are on the same Xinerama screen as the taskbar.\n\nBy default, this option is selected and all windows are shown.</whatsthis>
>+ <whatsthis>Turning this option off will cause the taskbar to display only windows which are on the same Xinerama screen as the taskbar. By default, this option is selected and all windows are shown.</whatsthis>
> </entry>
> <entry key="taskbarFont" type="Font" >
> <default></default>
>@@ -154,7 +154,7 @@
> <entry key="DrawButtons" type="Bool" >
> <default>false</default>
> <label>Draw taskbar entries "flat" and not as a button</label>
>- <whatsthis>Turning this option on will cause the taskbar to draw visible button frames for each entry in the taskbar. \n\nBy default, this option is off.</whatsthis>
>+ <whatsthis>Turning this option on will cause the taskbar to draw visible button frames for each entry in the taskbar. By default, this option is off.</whatsthis>
> </entry>
> <entry key="HaloText" type="Bool" >
> <default>false</default>

Actions: View | Diff

Attachments on bug 1399: 1153 | 1154