Attachment 1307 Details for Bug 1544 – tdmtheme 3.5.13.2 : fix crash when unselecting theme

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

[patch] tdmtheme 3.5.13.2 : fix crash when unselecting theme

tdmtheme-3.5.13.2-fix_null_theme_segv.patch (text/plain), 1.30 KB, created by Francois Andriot on 2013-06-13 02:00:13 CDT

(hide)

Description:

Filename:

MIME Type:

Creator: Francois Andriot

Created: 2013-06-13 02:00:13 CDT

Size: 1.30 KB

patch

obsolete

>--- trinity-tdmtheme-3.5.13.2/src/kdmtheme.cpp.ORI	2013-06-13 08:36:49.449599069 +0200
>+++ trinity-tdmtheme-3.5.13.2/src/kdmtheme.cpp	2013-06-13 08:44:01.014366366 +0200
>@@ -268,16 +268,22 @@
> 
> void KDMThemeWidget::updateInfoView( ThemeData *theme )
> {
>-	info->setText(
>-		((theme->copyright.length() > 0) ?
>-			i18n("<qt>Copyright: %1 </qt>",
>-				theme->copyright) : "") +
>-		((theme->description.length() > 0) ?
>-			i18n("<qt>Description: %1</qt>",
>-				theme->description) : "") );
>-	preview->setPixmap( theme->path + '/' + theme->screenShot );
>-	preview->setText( theme->screenShot.isEmpty() ?
>-		"Screenshot not available" : TQString() );
>+	if(theme) {
>+		info->setText(
>+			((theme->copyright.length() > 0) ?
>+				i18n("<qt>Copyright: %1 </qt>",
>+					theme->copyright) : "") +
>+			((theme->description.length() > 0) ?
>+				i18n("<qt>Description: %1</qt>",
>+					theme->description) : "") );
>+		preview->setPixmap( theme->path + '/' + theme->screenShot );
>+		preview->setText( theme->screenShot.isEmpty() ?
>+			i18n("Screenshot not available") : TQString() );
>+	} else {
>+		info->setText(i18n("No theme selected."));
>+		preview->setPixmap(NULL);
>+		preview->setText(i18n("Screenshot not available"));
>+	}
> }
> 
> void KDMThemeWidget::installNewTheme()

Actions: View | Diff

Attachments on bug 1544: 1307