Attachment 1404 Details for Bug 1594 – yet another cmake patch

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

[patch] yet another cmake patch

tdelibs-fix-ftbfs-on-some-tricky-options.patch (text/plain), 2.97 KB, created by Alexander Golubev (Fat-Zer) on 2013-07-24 22:17:06 CDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alexander Golubev (Fat-Zer)

Created: 2013-07-24 22:17:06 CDT

Size: 2.97 KB

patch

obsolete

>diff --git a/tdecore/CMakeLists.txt b/tdecore/CMakeLists.txt
>index bff0e51..b294609 100644
>--- a/tdecore/CMakeLists.txt
>+++ b/tdecore/CMakeLists.txt
>@@ -19,14 +19,15 @@ if( NOT DBUS_SYSTEM_BUS )
>   set( DBUS_SYSTEM_BUS "unix:path=/var/run/dbus/system_bus_socket" CACHE INTERNAL "" FORCE )
> endif()
> 
>+if( WITH_UPOWER OR WITH_UDISKS OR WITH_UDISKS2 OR
>+    WITH_NETWORK_MANAGER_BACKEND OR WITH_CONSOLEKIT )
>+  list( APPEND TDEHW_CUSTOM_INCLUDE_DIRS ${DBUS_TQT_INCLUDE_DIRS} )
>+  list( APPEND TDEHW_CUSTOM_LIBRARY_DIRS ${DBUS_TQT_LIBRARY_DIRS} )
>+  list( APPEND TDEHW_CUSTOM_LIBRARIES ${DBUS_TQT_LIBRARIES} )
>+endif( )
>+
> if( WITH_UPOWER )
>   add_definitions( -DWITH_UPOWER )
>-  set ( TDEUPOWER_INCLUDE_DIRECTORIES
>-    ${DBUS_TQT_INCLUDE_DIRS}
>-  )
>-  set ( TDEUPOWER_LIBRARIES
>-    ${DBUS_TQT_LIBRARIES}
>-  )
> endif( )
> 
> if( WITH_UDISKS )
>@@ -48,14 +49,12 @@ endif( WITH_LIBART )
> 
> if( WITH_NETWORK_MANAGER_BACKEND )
>   add_subdirectory( networkbackends/network-manager/dbus )
>-  set ( TDENM_INCLUDE_DIRECTORIES
>-    ${DBUS_TQT_INCLUDE_DIRS}
>+  list( APPEND TDEHW_CUSTOM_INCLUDE_DIR 
>     ${NM_UTIL_INCLUDE_DIRS}
>-    "${CMAKE_BINARY_DIR}/tdecore/networkbackends/network-manager/dbus"
>+    "${CMAKE_CURRENT_BINARY_DIR}/networkbackends/network-manager/dbus"
>   )
>-  set ( TDENM_LIBRARIES
>+  list( APPEND TDEHW_CUSTOM_LIBRARIES
>     tdenm_dbus-static
>-    ${DBUS_TQT_LIBRARIES}
>   )
>   set ( TDENM_BACKEND_SOURCES networkbackends/network-manager/network-manager.cpp )
> endif( WITH_NETWORK_MANAGER_BACKEND )
>@@ -75,14 +74,14 @@ include_directories(
>   ${LIBART_INCLUDE_DIRS}
>   ${LIBIDN_INCLUDE_DIRS}
>   ${GAMIN_INCLUDEDIR}
>-  ${TDENM_INCLUDE_DIRECTORIES}
>-  ${TDEUPOWER_INCLUDE_DIRECTORIES}
>+  ${TDEHW_CUSTOM_INCLUDE_DIRS}
> )
> 
> link_directories(
>   ${TQT_LIBRARY_DIRS}
>   ${LIBIDN_LIBRARY_DIRS}
>   ${GAMIN_LIBDIR}
>+  ${TDEHW_CUSTOM_LIBRARY_DIRS}
> )
> 
> ##### headers ###################################
>@@ -177,7 +176,9 @@ tde_add_library( ${target} SHARED AUTOMOC
>   SOURCES ${${target}_SRCS}
>   VERSION 4.2.0
>   EMBED tdecorenetwork-static
>-  LINK ltdlc-static ${KDESVGICONS} DCOP-shared tdefx-shared ${ZLIB_LIBRARIES} ${LIBIDN_LIBRARIES} ${XCOMPOSITE_LIBRARIES} ICE SM udev ${GAMIN_LIBRARIES} ${TDENM_LIBRARIES} ${TDEUPOWER_LIBRARIES}
>+  LINK ltdlc-static ${KDESVGICONS} DCOP-shared tdefx-shared ${ZLIB_LIBRARIES}
>+    ${LIBIDN_LIBRARIES} ${XCOMPOSITE_LIBRARIES} ICE SM udev ${GAMIN_LIBRARIES}
>+    ${TDEHW_CUSTOM_LIBRARIES}
>   DEPENDENCIES dcopidl dcopidl2cpp
>   DESTINATION ${LIB_INSTALL_DIR}
> )
>diff --git a/tdecore/tdehardwaredevices.cpp b/tdecore/tdehardwaredevices.cpp
>index f7f9066..63358f0 100644
>--- a/tdecore/tdehardwaredevices.cpp
>+++ b/tdecore/tdehardwaredevices.cpp
>@@ -68,7 +68,7 @@
> #endif // WITH_NETWORK_MANAGER_BACKEND
> 
> // uPower and uDisks2 integration
>-#if defined(WITH_UPOWER) || defined(WITH_UDISKS) || defined(WITH_UDISKS2)
>+#if defined(WITH_UPOWER) || defined(WITH_UDISKS) || defined(WITH_UDISKS2) || defined(WITH_CONSOLEKIT)
> 	#include <tqdbusdata.h>
> 	#include <tqdbusmessage.h>
> 	#include <tqdbusproxy.h>

Actions: View | Diff

Attachments on bug 1594: 1403 | 1404 | 1428 | 1436