Attachment #1531 for bug #1655

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release. View | Details | Raw Unified | Return to bug 1655
Collapse All | Expand All




 */
bool Battery::checkChargeLevelUnit () {
	kdDebugFuncOut(trace);

	// First make sure the battery object is still available
	TDEBatteryDevice* bdevice = dynamic_cast<TDEBatteryDevice*>(m_hwdevices->findByUniqueID(udi));
	if (!bdevice) {
		//grr... no luck
		kdError() << "Battery::checkChargeLevelUnit couldn't find battery" << endl;
		kdDebugFuncOut(trace);
		return false;
	}

		return false;
	}

	// Power supply energy informations in sysfs are always in uWh.
	// https://www.kernel.org/doc/Documentation/power/power_supply_class.txt
	// TDE hardware library internally uses Wh.
	// Since charge level unit are always Wh.
	charge_level_unit = "Wh";
	kdDebugFuncOut(trace);
	return false;
}

Return to bug 1655

Lines 515-526 bool Battery::checkChargeLevelRate () { Link Here

(-)a/src/hardware_battery.cpp (-7 / +7 lines)
515	*/	515	*/
516	bool Battery::checkChargeLevelUnit () {	516	bool Battery::checkChargeLevelUnit () {
517	kdDebugFuncOut(trace);	517	kdDebugFuncOut(trace);
518		518
519	// First make sure the battery object is still available	519	// First make sure the battery object is still available
520	TDEBatteryDevice* bdevice = dynamic_cast<TDEBatteryDevice*>(m_hwdevices->findByUniqueID(udi));	520	TDEBatteryDevice* bdevice = dynamic_cast<TDEBatteryDevice*>(m_hwdevices->findByUniqueID(udi));
521	if (!bdevice) {	521	if (!bdevice) {
522	//grr... no luck	522	//grr... no luck
523	kdError() << "Battery::checkChargeLevelRate couldn't find battery" << endl;	523	kdError() << "Battery::checkChargeLevelUnit couldn't find battery" << endl;
524	kdDebugFuncOut(trace);	524	kdDebugFuncOut(trace);
525	return false;	525	return false;
526	}	526	}
Lines 531-541 bool Battery::checkChargeLevelUnit () { Link Here
531	return false;	531	return false;
532	}	532	}
533		533
534	// FIXME VERIFY CORRECTNESS	534	// Power supply energy informations in sysfs are always in uWh.
535	// what does tdepowersave expect to see in charge_level_unit (battery.charge_level.unit)?	535	// https://www.kernel.org/doc/Documentation/power/power_supply_class.txt
536	charge_level_unit = "wH";	536	// TDE hardware library internally uses Wh.
537	//query was not successfull but this is optional	537	// Since charge level unit are always Wh.
538	kdWarning() << "Couldn't request charge_level.unit for udi: " << udi << endl;	538	charge_level_unit = "Wh";
539	kdDebugFuncOut(trace);	539	kdDebugFuncOut(trace);
540	return false;	540	return false;
541	}	541	}