Attachment 1532 Details for Bug 1655 – tdepowersave : more accurate reporting failure while acquire org.freedesktop.Policy.Power

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

[patch] tdepowersave : more accurate reporting failure while acquire org.freedesktop.Policy.Power

tdepowersave-report-error-on-acquire-policy-power.diff (text/plain), 1.13 KB, created by Slávek Banko on 2013-10-02 16:57:57 CDT

(hide)

Description:

Filename:

MIME Type:

Creator: Slávek Banko

Created: 2013-10-02 16:57:57 CDT

Size: 1.13 KB

patch

obsolete

>diff --git a/src/dbusInterface.cpp b/src/dbusInterface.cpp
>index 19e4bc3..1ca0ee4 100644
>--- a/src/dbusInterface.cpp
>+++ b/src/dbusInterface.cpp
>@@ -188,8 +188,15 @@ bool dbusInterface::acquirePolicyPowerIface(){
> 		return false;
> 	}
> 
>-	switch (dbus_bus_request_name(dbus_connection, "org.freedesktop.Policy.Power",
>-				      DBUS_NAME_FLAG_REPLACE_EXISTING, NULL)) {
>+	DBusError err;
>+	dbus_error_init(&err);
>+	int ret = dbus_bus_request_name(dbus_connection, "org.freedesktop.Policy.Power",
>+					DBUS_NAME_FLAG_REPLACE_EXISTING, &err);
>+	if (dbus_error_is_set(&err)) {
>+		kdWarning() << "Acquire org.freedesktop.Policy.Power interface failed with error: " << err.message << endl;
>+		dbus_error_free(&err);
>+	}
>+	switch (ret) {
> 		case DBUS_REQUEST_NAME_REPLY_PRIMARY_OWNER:
> 			kdDebug() << "Acquired org.freedesktop.Policy.Power interface" << endl;
> 			acquiredPolicyPower = true;
>@@ -199,7 +206,6 @@ bool dbusInterface::acquirePolicyPowerIface(){
> 			acquiredPolicyPower = false;
> 			break;
> 		default:
>-			kdWarning() << "Unknown error while acquire org.freedesktop.Policy.Power interface" << endl;
> 			acquiredPolicyPower = false;
> 			break;
> 	}

Actions: View | Diff

Attachments on bug 1655: 1531 | 1532 | 1534 | 1535