By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

[patch] Konqueror move tab right/left patch

tdebase_konqueror_move_tab_popup.diff (text/plain), 4.75 KB, created by Michele Calgaro on 2013-10-18 09:46:36 CDT

(hide)

Description: Konqueror move tab right/left patch

Filename:

MIME Type:

Creator: Michele Calgaro

Created: 2013-10-18 09:46:36 CDT

Size: 4.75 KB

patch

obsolete

>diff -Nur original/tdebase/konqueror/konq_tabs.cc new/tdebase/konqueror/konq_tabs.cc >--- original/tdebase/konqueror/konq_tabs.cc 2013-10-18 23:06:05.887904076 +0900 >+++ new/tdebase/konqueror/konq_tabs.cc 2013-10-18 22:56:59.255920227 +0900 >@@ -20,8 +20,10 @@ > > -------------------------------------------------------------- > Additional changes: >- - 2013/10/16 Michele Calgaro: >+ - 2013/10/16 Michele Calgaro > add "scroll tabs on mouse wheel event" functionality >+ - 2013/10/18 Michele Calgaro >+ correctly enable/disable 'move tab left/right' in the tab popup menu > */ > > #include "konq_tabs.h" >@@ -52,12 +54,12 @@ > #include <tqwhatsthis.h> > #include <tqstyle.h> > >-#define DUPLICATE_ID 3 >-#define RELOAD_ID 4 >-#define BREAKOFF_ID 5 >-#define CLOSETAB_ID 6 >-#define OTHERTABS_ID 7 >-#define MOVE_LEFT_ID 8 >+#define DUPLICATE_ID 3 >+#define RELOAD_ID 4 >+#define BREAKOFF_ID 5 >+#define CLOSETAB_ID 6 >+#define OTHERTABS_ID 7 >+#define MOVE_LEFT_ID 8 > #define MOVE_RIGHT_ID 9 > > //################################################################### >@@ -121,7 +123,7 @@ > m_pViewManager->mainWindow(), > TQT_SLOT( slotMoveTabRight() ), > m_pViewManager->mainWindow()->action("tab_move_right")->shortcut(), >- MOVE_RIGHT_ID ); >+ MOVE_RIGHT_ID ); > m_pPopupMenu->insertSeparator(); > m_pSubPopupMenuTab = new TQPopupMenu( this ); > m_pPopupMenu->insertItem( i18n("Other Tabs" ), m_pSubPopupMenuTab, OTHERTABS_ID ); >@@ -386,12 +388,32 @@ > m_pPopupMenu->setItemEnabled( RELOAD_ID, false ); > m_pPopupMenu->setItemEnabled( DUPLICATE_ID, false ); > m_pPopupMenu->setItemEnabled( BREAKOFF_ID, false ); >- m_pPopupMenu->setItemEnabled( MOVE_LEFT_ID, false ); >- // The following line fails to build. Adapted from konq_mainwindow.cc: 4243. Help! >- // m_pPopupMenu->setItemEnabled( MOVE_LEFT_ID, m_pViewManager->mainWindow()->currentView() ? m_pViewManager->mainWindow()->currentView()->frame()!=(TQApplication::reverseLayout() ? childFrameList->last() : childFrameList->first()) : false ); >- m_pPopupMenu->setItemEnabled( MOVE_RIGHT_ID, false ); >- // The following line fails to build. Adapted from konq_mainwindow.cc: 4245. Help! >- // m_pPopupMenu->setItemEnabled( MOVE_RIGHT_ID, m_pViewManager->mainWindow()->currentView() ? m_pViewManager->mainWindow()->currentView()->frame()!=(TQApplication::reverseLayout() ? childFrameList->first() : childFrameList->last()) : false ); >+ >+ uint tabCount = m_pChildFrameList->count(); >+ KonqView *kview = m_pViewManager->mainWindow()->currentView(); >+ if (tabCount>1 && kview) >+ { >+ // Move tab left >+ bool left_enable = false, right_enable = false; >+ if (TQApplication::reverseLayout()) >+ { >+ left_enable = (kview->frame() != m_pChildFrameList->last()); >+ right_enable= (kview->frame() != m_pChildFrameList->first()); >+ } >+ else >+ { >+ left_enable = (kview->frame() != m_pChildFrameList->first()); >+ right_enable= (kview->frame() != m_pChildFrameList->last()); >+ } >+ m_pPopupMenu->setItemEnabled( MOVE_LEFT_ID, left_enable); >+ m_pPopupMenu->setItemEnabled( MOVE_RIGHT_ID, right_enable); >+ } >+ else >+ { >+ m_pPopupMenu->setItemEnabled(MOVE_LEFT_ID, false); >+ m_pPopupMenu->setItemEnabled(MOVE_RIGHT_ID, false); >+ } >+ > m_pPopupMenu->setItemEnabled( CLOSETAB_ID, false ); > m_pPopupMenu->setItemEnabled( OTHERTABS_ID, true ); > m_pSubPopupMenuTab->setItemEnabled( m_closeOtherTabsId, false ); >@@ -407,8 +429,31 @@ > m_pPopupMenu->setItemEnabled( RELOAD_ID, true ); > m_pPopupMenu->setItemEnabled( DUPLICATE_ID, true ); > m_pPopupMenu->setItemEnabled( BREAKOFF_ID, tabCount>1 ); >- m_pPopupMenu->setItemEnabled( MOVE_LEFT_ID, tabCount>1 ); >- m_pPopupMenu->setItemEnabled( MOVE_RIGHT_ID, tabCount>1 ); >+ >+ KonqView *kview = m_pViewManager->mainWindow()->currentView(); >+ if (tabCount>1 && kview) >+ { >+ // Move tab left >+ bool left_enable = false, right_enable = false; >+ if (TQApplication::reverseLayout()) >+ { >+ left_enable = (kview->frame() != m_pChildFrameList->last()); >+ right_enable= (kview->frame() != m_pChildFrameList->first()); >+ } >+ else >+ { >+ left_enable = (kview->frame() != m_pChildFrameList->first()); >+ right_enable= (kview->frame() != m_pChildFrameList->last()); >+ } >+ m_pPopupMenu->setItemEnabled( MOVE_LEFT_ID, left_enable); >+ m_pPopupMenu->setItemEnabled( MOVE_RIGHT_ID, right_enable); >+ } >+ else >+ { >+ m_pPopupMenu->setItemEnabled(MOVE_LEFT_ID, false); >+ m_pPopupMenu->setItemEnabled(MOVE_RIGHT_ID, false); >+ } >+ > m_pPopupMenu->setItemEnabled( CLOSETAB_ID, tabCount>1 ); > m_pPopupMenu->setItemEnabled( OTHERTABS_ID, tabCount>1 ); > m_pSubPopupMenuTab->setItemEnabled( m_closeOtherTabsId, true ); View Attachment As Diff View Attachment As Raw

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    [x]
  • | Forgot Password
    Login: [x]