Attachment 2345 Details for Bug 2187 – tdenetwork: fix missing return values

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

[patch] tdenetwork: fix missing return values

tdenetwork-3.5.13.2-fix_ftbfs_noreturn.patch (text/plain), 3.24 KB, created by Francois Andriot on 2014-11-11 11:23:14 CST

(hide)

Description:

Filename:

MIME Type:

Creator: Francois Andriot

Created: 2014-11-11 11:23:14 CST

Size: 3.24 KB

patch

obsolete

>diff --git a/kopete/protocols/jabber/jingle/libjingle/talk/session/phone/linphonemediaengine.cc b/kopete/protocols/jabber/jingle/libjingle/talk/session/phone/linphonemediaengine.cc
>index f3244c5..d9cf2a9 100644
>--- a/kopete/protocols/jabber/jingle/libjingle/talk/session/phone/linphonemediaengine.cc
>+++ b/kopete/protocols/jabber/jingle/libjingle/talk/session/phone/linphonemediaengine.cc
>@@ -47,6 +47,7 @@ void *thread_function(void *data)
>     if (iface && (mc->mute()==FALSE))
>       iface->SendPacket(buf, len);
>   }
>+  return NULL;
> }
> 
> LinphoneMediaChannel::LinphoneMediaChannel() {
>@@ -118,8 +119,8 @@ void LinphoneMediaChannel::SetSend(bool send) {
>   mute_ = !send;
> }
> 
>-float LinphoneMediaChannel::GetCurrentQuality() {}
>-int LinphoneMediaChannel::GetOutputLevel() {}
>+float LinphoneMediaChannel::GetCurrentQuality() { return 0; }
>+int LinphoneMediaChannel::GetOutputLevel() { return 0; }
> 
> LinphoneMediaEngine::LinphoneMediaEngine() {}
> LinphoneMediaEngine::~LinphoneMediaEngine() {}
>@@ -163,8 +164,8 @@ MediaChannel *LinphoneMediaEngine::CreateChannel() {
>   return new LinphoneMediaChannel();
> }
> 
>-int LinphoneMediaEngine::SetAudioOptions(int options) {}
>-int LinphoneMediaEngine::SetSoundDevices(int wave_in_device, int wave_out_device) {}
>+int LinphoneMediaEngine::SetAudioOptions(int options) { return 0; }
>+int LinphoneMediaEngine::SetSoundDevices(int wave_in_device, int wave_out_device) { return 0; }
> 
>-float LinphoneMediaEngine::GetCurrentQuality() {}
>-int LinphoneMediaEngine::GetInputLevel() {}
>+float LinphoneMediaEngine::GetCurrentQuality() { return 0; }
>+int LinphoneMediaEngine::GetInputLevel() { return 0; }
>diff --git a/kopete/protocols/jabber/jingle/libjingle/talk/third_party/mediastreamer/audiostream.c b/kopete/protocols/jabber/jingle/libjingle/talk/third_party/mediastreamer/audiostream.c
>index 8b322f4..42198d6 100644
>--- a/kopete/protocols/jabber/jingle/libjingle/talk/third_party/mediastreamer/audiostream.c
>+++ b/kopete/protocols/jabber/jingle/libjingle/talk/third_party/mediastreamer/audiostream.c
>@@ -340,4 +340,5 @@ gint audio_stream_send_dtmf(AudioStream *stream, gchar dtmf)
> {
> 	ms_rtp_send_dtmf(MS_RTP_SEND(stream->rtpsend), dtmf);
> 	ms_oss_write_play_dtmf(MS_OSS_WRITE(stream->soundwrite),dtmf);
>+	return 0;
> }
>diff --git a/kopete/protocols/jabber/jingle/libjingle/talk/third_party/mediastreamer/msread.c b/kopete/protocols/jabber/jingle/libjingle/talk/third_party/mediastreamer/msread.c
>index a66f7ab..133445d 100644
>--- a/kopete/protocols/jabber/jingle/libjingle/talk/third_party/mediastreamer/msread.c
>+++ b/kopete/protocols/jabber/jingle/libjingle/talk/third_party/mediastreamer/msread.c
>@@ -172,6 +172,7 @@ gint ms_read_close(MSRead *obj)
> 		obj->fd=-1;
> 		obj->state=MS_READ_STATE_STOPPED;
> 	}
>+	return 0;
> }
> 
> 
>diff --git a/kopete/protocols/jabber/jingle/libjingle/talk/third_party/mediastreamer/mssync.c b/kopete/protocols/jabber/jingle/libjingle/talk/third_party/mediastreamer/mssync.c
>index f85784e..d495647 100644
>--- a/kopete/protocols/jabber/jingle/libjingle/talk/third_party/mediastreamer/mssync.c
>+++ b/kopete/protocols/jabber/jingle/libjingle/talk/third_party/mediastreamer/mssync.c
>@@ -189,5 +189,6 @@ int ms_sync_uninit(MSSync *sync)
> 	g_mutex_free(sync->lock);
> 	g_cond_free(sync->thread_cond);
> 	g_cond_free(sync->stop_cond);
>+	return 0;
> }
>

Actions: View | Diff

Attachments on bug 2187: 2345