Attachment 2470 Details for Bug 2402 – bibletime: use strcmp instead of string comparison

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

[patch] bibletime: use strcmp instead of string comparison

bibletime-14.0.0.patch (text/plain), 1.21 KB, created by Francois Andriot on 2015-03-21 11:31:04 CDT

(hide)

Description:

Filename:

MIME Type:

Creator: Francois Andriot

Created: 2015-03-21 11:31:04 CDT

Size: 1.21 KB

patch

obsolete

>diff --git a/bibletime/backend/cswordbackend.cpp b/bibletime/backend/cswordbackend.cpp
>index 1c218b3..dda6275 100644
>--- a/bibletime/backend/cswordbackend.cpp
>+++ b/bibletime/backend/cswordbackend.cpp
>@@ -251,7 +251,7 @@ const bool CSwordBackend::shutdownModules() {
> 
> /** Returns true if the given option is enabled. */
> const bool CSwordBackend::isOptionEnabled( const CSwordModuleInfo::FilterTypes type) {
>-	return (getGlobalOption( optionName(type).latin1() ) == "On");
>+	return (strcmp(getGlobalOption( optionName(type).latin1() ), "On"));
> }
> 
> /** Sets the given options enabled or disabled depending on the second parameter. */
>diff --git a/bibletime/frontend/cdragdropmgr.cpp b/bibletime/frontend/cdragdropmgr.cpp
>index 52d012f..4f8c4fe 100644
>--- a/bibletime/frontend/cdragdropmgr.cpp
>+++ b/bibletime/frontend/cdragdropmgr.cpp
>@@ -36,7 +36,7 @@ bool CDragDropMgr::BTDrag::canDecode( const TQMimeSource * mime ) {
> };
> 
> bool CDragDropMgr::BTDrag::provides( const char* type ) const {
>-	return (type == "BibleTime/DND"); //return only true if the type is BibleTime/DND
>+	return (strcmp(type, "BibleTime/DND")); //return only true if the type is BibleTime/DND
> };
> 
> const char* CDragDropMgr::BTDrag::format( int i ) const {

Actions: View | Diff

Attachments on bug 2402: 2470 | 2471