Attachment 2540 Details for Bug 1362 – KJobViewer (tdebase part) crash fix and autostart appending to the system tray

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

[patch] KJobViewer (tdebase part) crash fix and autostart appending to the system tray

kjobviewer-crash-autostart.patch (text/plain), 5.17 KB, created by Roman Savochenko on 2015-07-27 04:39:52 CDT

(hide)

Description:

Filename:

MIME Type:

Creator: Roman Savochenko

Created: 2015-07-27 04:39:52 CDT

Size: 5.17 KB

patch

obsolete

>--- kdebase-3.5.13.2/tdeprint/kjobviewer/kjobviewer.cpp~	2014-02-03 12:41:53.704406602 +0200
>+++ kdebase-3.5.13.2/tdeprint/kjobviewer/kjobviewer.cpp	2014-02-03 12:41:57.600220118 +0200
>@@ -94,10 +94,14 @@
> 	m_views.setAutoDelete(true);
> 	m_tray = 0;
> 	m_timer = 0;
>+
>+	// We handle autostart via standard autostart-enabled .desktop file instead of the session manager
>+	disableSessionManagement();
> }
> 
> KJobViewerApp::~KJobViewerApp()
> {
>+	if(m_timer) delete m_timer;
> }
> 
> int KJobViewerApp::newInstance()
>@@ -162,7 +165,7 @@
>         view->setPrinter(prname);
> 
> 	//m_timer->release(true);
>-	m_timer->delay(10);
>+	m_timer->delay(100);
> }
> 
> void KJobViewerApp::slotJobsShown(KMJobViewer *view, bool hasJobs)
>@@ -220,7 +223,7 @@
> void KJobViewerApp::reload()
> {
> 	// trigger delayed refresh in all views
>-	m_timer->delay(10);
>+	m_timer->delay(100);
> }
> 
> void KJobViewerApp::slotViewerDestroyed(KMJobViewer *view)
>diff -uNr kjobviewer~/CMakeLists.txt kjobviewer/CMakeLists.txt
>--- kdebase-3.5.13.2/tdeprint/kjobviewer/CMakeLists.txt~	2015-07-24 16:39:37.328493216 +0300
>+++ kdebase-3.5.13.2/tdeprint/kjobviewer/CMakeLists.txt	2015-07-24 16:25:34.644373543 +0300
>@@ -26,6 +26,7 @@
> 
> tde_install_icons( kjobviewer )
> install( FILES kjobviewer.desktop DESTINATION ${XDG_APPS_INSTALL_DIR} )
>+install( FILES kjobviewer-autostart.desktop DESTINATION ${AUTOSTART_INSTALL_DIR} )
> install( FILES kjobviewerui.rc DESTINATION ${DATA_INSTALL_DIR}/kjobviewer )
> 
> 
>diff -uNr kjobviewer~/kjobviewer-autostart.desktop kjobviewer/kjobviewer-autostart.desktop
>--- kdebase-3.5.13.2/tdeprint/kjobviewer/kjobviewer-autostart.desktop~	1970-01-01 03:00:00.000000000 +0300
>+++ kdebase-3.5.13.2/tdeprint/kjobviewer/kjobviewer-autostart.desktop	2015-07-24 16:19:29.606588964 +0300
>@@ -0,0 +1,96 @@
>+[Desktop Entry]
>+Exec=kjobviewer --all --noshow %i %m
>+Icon=kjobviewer
>+Terminal=false
>+Type=Application
>+
>+Name=KJobViewer
>+Name[bn]=à¦à§-à¦à¦¬-à¦à¦¿à¦à§à¦¾à¦°
>+Name[csb]=PrzezÃ©rnik pÃ²lÃ©tÃ³w drÃ«kera
>+Name[cy]=KGwelyddSwyddi
>+Name[ja]=K ã¸ã§ããã¥ã¼ã¢
>+Name[nds]=Opgavenkieker
>+Name[ne]=KJob à¤¦à¤°à¥à¤¶à¤
>+Name[pl]=PrzeglÄdarka zadaÅ drukowania
>+Name[pt_BR]=Trabalhos de ImpressÃ£o
>+Name[ro]=Vizualizor lucrÄri de tipÄrit
>+Name[rw]=K-IkigaragazaUmurimo
>+Name[sk]=PrehliadaÄ Ãºloh
>+Name[sv]=K-jobbvisare
>+Name[ta]=à®à¯à®ªà®£à®¿ à®à®¾à®à¯à®à®¿à®¯à®¾à®³à®©à¯
>+Name[tg]=ÐÐ°Ð¼Ð¾Ð¸ÑÐ³Ð°ÑÐ¸ ÐºÐ¾ÑÒ³Ð¾
>+Name[vi]=TrÃ¬nh theo dÃµi TÃ¡c vá»¥ In áº¥n
>+GenericName=Print Jobs
>+GenericName[af]=Drukker Werke
>+GenericName[be]=ÐÐ°Ð´Ð°Ð½Ð½Ñ Ð´ÑÑÐºÑ
>+GenericName[bg]=ÐÐ°Ð´Ð°Ð½Ð¸Ñ Ð·Ð° Ð¿ÐµÑÐ°Ñ
>+GenericName[bn]=à¦®à§à¦¦à§à¦°à¦£ à¦¤à¦¾à¦²à¦¿à¦à¦¾
>+GenericName[bs]=Zadaci Å¡tampe
>+GenericName[ca]=Treballs d'impressiÃ³
>+GenericName[cs]=TiskovÃ© Ãºlohy
>+GenericName[csb]=PÃ²lÃ©tÃ« drÃ«kera
>+GenericName[cy]=Swyddi Argraffu
>+GenericName[da]=Udskriv job
>+GenericName[de]=DruckauftrÃ¤ge
>+GenericName[el]=ÎÏÎ³Î±ÏÎ¯ÎµÏ ÎµÎºÏÏÏÏÏÎ·Ï
>+GenericName[eo]=Printtaskoj
>+GenericName[es]=Trabajos de impresiÃ³n
>+GenericName[et]=Printeri tÃ¶Ã¶d
>+GenericName[eu]=Inprimaketa lanak
>+GenericName[fa]=ÚØ§Ù¾ Ú©Ø§Ø±ÙØ§
>+GenericName[fi]=TulostustyÃ¶t
>+GenericName[fr]=TÃ¢ches d'impressions
>+GenericName[fy]=printtaken
>+GenericName[ga]=Jabanna PriontÃ¡la
>+GenericName[gl]=Traballos de ImpresiÃ³n
>+GenericName[he]=×¢×××××ª ×××¤×¡×
>+GenericName[hr]=Zadaci ispisivanja
>+GenericName[hu]=NyomtatÃ¡si feladatok
>+GenericName[is]=Prentverk
>+GenericName[it]=Lavori di stampa
>+GenericName[ja]=å°å·ã¸ã§ã
>+GenericName[ka]=ááááááá¡ áááááááá
>+GenericName[kk]=ÐÐ°ÑÑÐ¿ ÑÑÒÐ°ÑÑ ÑÐ°Ð¿ÑÑÑÐ¼Ð°Ð»Ð°ÑÑ
>+GenericName[km]=áá¶ááá¶áâááááá»ááá
>+GenericName[lt]=Spausdinimo uÅ¾duotys
>+GenericName[mk]=ÐÐ°Ð´Ð°ÑÐ¸ Ð·Ð° Ð¿ÐµÑÐ°ÑÐµÑÐµ
>+GenericName[ms]=Cetak Kerja
>+GenericName[nb]=Utskriftsjobber
>+GenericName[nds]=Druckopgaven
>+GenericName[ne]=à¤®à¥à¤¦à¥à¤°à¤£ à¤à¤¾à¤°à¥à¤¯
>+GenericName[nl]=Afdruktaken
>+GenericName[nn]=Utskriftsjobbar
>+GenericName[pa]=à¨à¨ªà¨¾à¨ à¨à©°à¨®
>+GenericName[pl]=Zadania drukowania
>+GenericName[pt]=Tarefas de ImpressÃ£o
>+GenericName[pt_BR]=Tarefas de ImpressÃ£o
>+GenericName[ro]=LucrÄri de tipÄrit
>+GenericName[ru]=ÐÐ°Ð´Ð°Ð½Ð¸Ñ Ð¿ÐµÑÐ°ÑÐ¸
>+GenericName[rw]=Gucapa Imirimo
>+GenericName[se]=ÄÃ¡lihanbarggut
>+GenericName[sk]=TlaÄovÃ© Ãºlohy
>+GenericName[sl]=TiskalniÅ¡ka opravila
>+GenericName[sr]=ÐÐ¾ÑÐ»Ð¾Ð²Ð¸ ÑÑÐ°Ð¼Ð¿Ðµ
>+GenericName[sr@Latn]=Poslovi Å¡tampe
>+GenericName[sv]=Skrivarjobb
>+GenericName[ta]=à®à®à¯à®à¯à®ªà¯ à®ªà®£à®¿à®à®³à¯
>+GenericName[te]=à°ªà±à°°à°à±à°°à°£ à°ªà°¨à±à°²à±
>+GenericName[tg]=ÐÐ¾ÑÒ³Ð¾Ð¸ ÑÐ¾Ð¿Ð³Ð°Ñ
>+GenericName[th]=à¸à¸²à¸à¸à¸´à¸¡à¸à¹
>+GenericName[tr]=YazdÄ±rma GÃ¶revleri
>+GenericName[tt]=BastÄ±ru EÅlÃ¤re
>+GenericName[uk]=ÐÐ°Ð´Ð°ÑÑ Ð´ÑÑÐºÑ
>+GenericName[uz]=Bosib chiqarish vazifalari
>+GenericName[uz@cyrillic]=ÐÐ¾ÑÐ¸Ð± ÑÐ¸ÒÐ°ÑÐ¸Ñ Ð²Ð°Ð·Ð¸ÑÐ°Ð»Ð°ÑÐ¸
>+GenericName[vi]=TÃ¡c vá»¥ In áº¥n
>+GenericName[wa]=Bouyes d'Â imprimaedje
>+GenericName[zh_CN]=æå°ä»»å¡
>+GenericName[zh_TW]=åå°å·¥ä½
>+
>+X-DCOP-ServiceType=Unique
>+X-KDE-autostart-after=panel
>+X-KDE-autostart-condition=kdeprintrc:Jobs:KeepWindow:true
>+X-KDE-autostart-phase=1
>+X-KDE-StartupNotify=false
>+Categories=Qt;TDE;Utility;Printing;HardwareSettings;TrayIcon;
>+ShowOnlyIn=TDE;

Actions: View | Diff

Attachments on bug 1362: 1045 | 1071 | 1342 | 1643 | 1672 | 1733 | 1734 | 2539 | 2540 | 2952