By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

[patch] libksquirrel: fix potential buffer overflow

libksquirrel-fix-potential-buffer-overflow.diff (text/plain), 619 bytes, created by Slávek Banko on 2015-09-13 09:30:03 CDT

(hide)

Description: libksquirrel: fix potential buffer overflow

Filename:

MIME Type:

Creator: Slávek Banko

Created: 2015-09-13 09:30:03 CDT

Size: 619 bytes

patch

obsolete

>diff --git a/kernel/kls_hdr/fmt_codec_hdr.cpp b/kernel/kls_hdr/fmt_codec_hdr.cpp >index 9819504..33af0a0 100644 >--- a/kernel/kls_hdr/fmt_codec_hdr.cpp >+++ b/kernel/kls_hdr/fmt_codec_hdr.cpp >@@ -283,7 +283,8 @@ bool fmt_codec::getHdrHead() > bool done = false; > s8 a, b; > s8 x[2], y[2]; >- s8 buff[80]; >+ const u32 buffSize = 80; >+ s8 buff[buffSize]; > u32 count = 0; > > if(!frs.readK(hdr.sig, sizeof(hdr.sig)-1)) return false; >@@ -320,6 +321,9 @@ bool fmt_codec::getHdrHead() > if(!frs.readK(&a, sizeof(s8))) return false; > > ++count; >+ if (count > buffSize-1) { >+ return false; >+ } > } > > buff[count] = '\0'; View Attachment As Diff View Attachment As Raw

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    [x]
  • | Forgot Password
    Login: [x]