Attachment 828 Details for Bug 1235 – kdepim: Fix more SEGV in imapparser

By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

[patch] kdepim: Fix more SEGV in imapparser

kdepim-3.5.13.1-fix_imapparser_segv.patch (text/plain), 1.12 KB, created by Francois Andriot on 2012-09-26 03:46:51 CDT

(hide)

Description:

Filename:

MIME Type:

Creator: Francois Andriot

Created: 2012-09-26 03:46:51 CDT

Size: 1.12 KB

patch

obsolete

>--- kdepim-3.5.13.1/kioslaves/imap4/imapparser.cc.segv	2012-09-08 12:06:42.000000000 +0200
>+++ kdepim-3.5.13.1/kioslaves/imap4/imapparser.cc	2012-09-25 13:51:53.496792670 +0200
>@@ -345,6 +345,7 @@
>   parseOneWordC(result);        // *
>   TQByteArray what = parseLiteral (result); // see whats coming next
> 
>+  if(!what.isEmpty ()) {
>   switch (what[0])
>   {
>     //the status responses
>@@ -482,6 +483,7 @@
>       if (valid)
>       {
>         what = parseLiteral (result);
>+	if(!what.isEmpty ()) {
>         switch (what[0])
>         {
>         case 'E':
>@@ -520,10 +522,12 @@
>         default:
>           break;
>         }
>+	}
>       }
>     }
>     break;
>   }                             //switch
>+  }
> }                               //func
> 
> 
>@@ -1915,9 +1919,10 @@
>   if (!inWords.isEmpty() && inWords[0] == '{')
>   {
>     TQCString retVal;
>-    ulong runLen = inWords.find ('}', 1);
>-    if (runLen > 0)
>+    long srunLen = inWords.find ('}', 1); // Can return -1, so use a signed long
>+    if (srunLen > 0)
>     {
>+      ulong runLen = (ulong)srunLen;
>       bool proper;
>       ulong runLenSave = runLen + 1;
>       TQCString tmpstr(runLen);

Actions: View | Diff

Attachments on bug 1235: 826 | 827 | 828 | 829