By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

[patch] Add GUI control for HoverCloseButton option

tdebase-konq-hoverbutton.diff (text/plain), 5.24 KB, created by Darrell on 2012-10-09 19:53:19 CDT

(hide)

Description: Add GUI control for HoverCloseButton option

Filename:

MIME Type:

Creator: Darrell

Created: 2012-10-09 19:53:19 CDT

Size: 5.24 KB

patch

obsolete

>diff -urN tdebase/kcontrol/konqhtml/advancedTabDialog.cpp tdebase.new/kcontrol/konqhtml/advancedTabDialog.cpp >--- tdebase/kcontrol/konqhtml/advancedTabDialog.cpp 2012-09-14 17:58:16.000000000 -0500 >+++ tdebase.new/kcontrol/konqhtml/advancedTabDialog.cpp 2012-10-09 19:05:11.000000000 -0500 >@@ -63,6 +63,7 @@ > connect(m_advancedWidget->m_pTabConfirm, TQT_SIGNAL(clicked()), this, TQT_SLOT(changed())); > connect(m_advancedWidget->m_pTabCloseActivatePrevious, TQT_SIGNAL(clicked()), this, TQT_SLOT(changed())); > connect(m_advancedWidget->m_pPermanentCloseButton, TQT_SIGNAL(clicked()), this, TQT_SLOT(changed())); >+ connect(m_advancedWidget->m_pHoverCloseButton, TQT_SIGNAL(clicked()), this, TQT_SLOT(changed())); > connect(m_advancedWidget->m_pKonquerorTabforExternalURL, TQT_SIGNAL(clicked()), this, TQT_SLOT(changed())); > connect(m_advancedWidget->m_pPopupsWithinTabs, TQT_SIGNAL(clicked()), this, TQT_SLOT(changed())); > >@@ -79,6 +80,7 @@ > m_advancedWidget->m_pNewTabsInBackground->setChecked( ! (m_pConfig->readBoolEntry( "NewTabsInFront", false )) ); > m_advancedWidget->m_pOpenAfterCurrentPage->setChecked( m_pConfig->readBoolEntry( "OpenAfterCurrentPage", false ) ); > m_advancedWidget->m_pPermanentCloseButton->setChecked( m_pConfig->readBoolEntry( "PermanentCloseButton", false ) ); >+ m_advancedWidget->m_pHoverCloseButton->setChecked( m_pConfig->readBoolEntry( "HoverCloseButton", false ) ); > m_advancedWidget->m_pKonquerorTabforExternalURL->setChecked( m_pConfig->readBoolEntry( "KonquerorTabforExternalURL", false ) ); > m_advancedWidget->m_pPopupsWithinTabs->setChecked( m_pConfig->readBoolEntry( "PopupsWithinTabs", false ) ); > m_advancedWidget->m_pTabCloseActivatePrevious->setChecked( m_pConfig->readBoolEntry( "TabCloseActivatePrevious", false ) ); >@@ -86,6 +88,10 @@ > m_pConfig->setGroup("Notification Messages"); > m_advancedWidget->m_pTabConfirm->setChecked( !m_pConfig->hasKey("MultipleTabConfirm") ); > >+ if ( m_advancedWidget->m_pPermanentCloseButton->isChecked() ) >+ m_advancedWidget->m_pHoverCloseButton->setEnabled(false); >+ else >+ m_advancedWidget->m_pHoverCloseButton->setEnabled(true); > actionButton(Apply)->setEnabled(false); > } > >@@ -95,12 +101,13 @@ > m_pConfig->writeEntry( "NewTabsInFront", !(m_advancedWidget->m_pNewTabsInBackground->isChecked()) ); > m_pConfig->writeEntry( "OpenAfterCurrentPage", m_advancedWidget->m_pOpenAfterCurrentPage->isChecked() ); > m_pConfig->writeEntry( "PermanentCloseButton", m_advancedWidget->m_pPermanentCloseButton->isChecked() ); >+ m_pConfig->writeEntry( "HoverCloseButton", m_advancedWidget->m_pHoverCloseButton->isChecked() ); > m_pConfig->writeEntry( "KonquerorTabforExternalURL", m_advancedWidget->m_pKonquerorTabforExternalURL->isChecked() ); > m_pConfig->writeEntry( "PopupsWithinTabs", m_advancedWidget->m_pPopupsWithinTabs->isChecked() ); > m_pConfig->writeEntry( "TabCloseActivatePrevious", m_advancedWidget->m_pTabCloseActivatePrevious->isChecked() ); > m_pConfig->sync(); > >- // It only matters wether the key is present, its value has no meaning >+ // It only matters whether the key is present, its value has no meaning > m_pConfig->setGroup("Notification Messages"); > if ( m_advancedWidget->m_pTabConfirm->isChecked() ) m_pConfig->deleteEntry( "MultipleTabConfirm" ); > else m_pConfig->writeEntry( "MultipleTabConfirm", true ); >@@ -110,11 +117,19 @@ > kapp->dcopClient()->attach(); > KApplication::kApplication()->dcopClient()->send( "konqueror*", "KonquerorIface", "reparseConfiguration()", data ); > >+ if ( m_advancedWidget->m_pPermanentCloseButton->isChecked() ) >+ m_advancedWidget->m_pHoverCloseButton->setEnabled(false); >+ else >+ m_advancedWidget->m_pHoverCloseButton->setEnabled(true); > actionButton(Apply)->setEnabled(false); > } > > void advancedTabDialog::changed() > { >+ if ( m_advancedWidget->m_pPermanentCloseButton->isChecked() ) >+ m_advancedWidget->m_pHoverCloseButton->setEnabled(false); >+ else >+ m_advancedWidget->m_pHoverCloseButton->setEnabled(true); > actionButton(Apply)->setEnabled(true); > } > >diff -urN tdebase/kcontrol/konqhtml/advancedTabOptions.ui tdebase.new/kcontrol/konqhtml/advancedTabOptions.ui >--- tdebase/kcontrol/konqhtml/advancedTabOptions.ui 2012-09-16 19:03:38.000000000 -0500 >+++ tdebase.new/kcontrol/konqhtml/advancedTabOptions.ui 2012-10-09 17:43:36.000000000 -0500 >@@ -95,6 +95,17 @@ > </widget> > <widget class="TQCheckBox"> > <property name="name"> >+ <cstring>m_pHoverCloseButton</cstring> >+ </property> >+ <property name="text"> >+ <string>&amp;Show close button instead of website icon with mouse hover</string> >+ </property> >+ <property name="whatsThis" stdset="0"> >+ <string>This will display a close button inside each tab instead of websites' icons when the mouse pointer hovers the icon.</string> >+ </property> >+ </widget> >+ <widget class="TQCheckBox"> >+ <property name="name"> > <cstring>m_pPopupsWithinTabs</cstring> > </property> > <property name="text"> View Attachment As Diff View Attachment As Raw

• • Home
  • | New
  • | Browse
  • | Search
  • |
    [?]
  • | Reports
  • | Help
  • | New Account
  • | Log In
    [x]
  • | Forgot Password
    Login: [x]