By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1013

Summary:	Kandy (from kdepim) has no icon in application menu
Product:	TDE	Reporter:	Francois Andriot <albator78>
Component:	tdepim	Assignee:	Timothy Pearson <kb9vqf>
Status:	RESOLVED FIXED
Severity:	trivial	CC:	bugwatch, darrella, slavek.banko
Priority:	P5
Version:	3.5.13 [Trinity]
Hardware:	All
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Attachments:	Patch to add default kandy icon

Description Francois Andriot 2012-05-30 15:56:30 CDT

Hello, the "kandy" application has no icon installed at all in my kdepim 3.5.13 package.
Where could we get an icon for it ?

Comment 1 Slávek Banko 2012-05-31 09:47:28 CDT

I tried to install Kandy. Already in the package I can see folder /opt/trinity/share/pixmaps with kandy-16.xpm and kandy.xpm. In the KMenu then I see Kandy including icon.

It seems to be all right.
Where's the problem?

Slavek

Comment 2 Francois Andriot 2012-05-31 11:11:33 CDT

Hello, I think XPM icons are for debian/ubuntu only, not other distro.
At least, they are not used in Fedora/RHEL.

Comment 3 Slávek Banko 2012-05-31 11:54:32 CDT

(Odpověď na komentář #2)
> Hello, I think XPM icons are for debian/ubuntu only, not other distro.
> At least, they are not used in Fedora/RHEL.

Ah, that explains it. The solution would thus be either convert XPM to PNG during compilation or add icon in PNG?

Comment 4 Timothy Pearson 2012-05-31 12:39:01 CDT

Best would be to convert the XPM to PNG during compilation, so that the high-quality original is retained in the source tree.

Comment 5 Slávek Banko 2012-05-31 12:44:40 CDT

(Odpověď na komentář #4)
> Best would be to convert the XPM to PNG during compilation, so that the
> high-quality original is retained in the source tree.

Is on Fedora / RedHat available xpmtoppm and pnmtopng?
On Debian this is in the package netpbm.

Comment 6 Darrell 2012-06-01 21:15:44 CDT

There are others with missing icons:

Office->KThesaurus
Office->Kugar Designer
Development->Web Development->XSLT Debugger
Games->Games for Kids menu entry

We discussed this in the developer's mail list and learned that the problem is dependent upon the icon set. That explains why some people see icons and some don't.

Comment 7 Darrell 2012-08-16 17:00:09 CDT

Created attachment 786 [details]
Patch to add default kandy icon

I tested the patch in R14. Please test in 3.5.13 SRU. Thanks. :-)

Comment 8 Slávek Banko 2012-08-18 11:21:24 CDT

I tried to use patch with v3.5.13-sru and I did not find any problems.

Comment 9 Darrell 2012-08-18 13:55:04 CDT

Okay, thanks. Pushed to GIT in commit f1ec987d.

Of the other four missing icons mentioned in this discussion:

Office->KThesaurus
Office->Kugar Designer
Development->Web Development->XSLT Debugger
Games->Games for Kids menu entry

I pushed patches for both XSLT Debugger (commit e87eaf68) and Games for Kids (commits 471cc2df & 5d81f9a9).

I have icons for kthesaurus and kugar designer but haven't yet tested the make files. As soon as I successfully run my next koffice build I'll push those to GIT.

As those two icons are not part of the original problem report, I'll close this report as resolved.

Thanks for reporting!

Comment 10 Slávek Banko 2012-08-18 19:37:34 CDT

Darrell, please commit does not contain picture :)

Comment 11 Darrell 2012-08-19 12:48:18 CDT

Oops. Fixed in commit e85c6d1a. Thanks!