| Summary: | Build issue: Fix covariant return check | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Nix <nix-bugs> |
| Component: | tdebase | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | bugwatch, darrella |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: |
Use check_cxx_source_runs, not check_c_source_runs
Include the TQT_CFLAGS in TQT_CXX_FLAGS as well |
||
Created attachment 653 [details]
Include the TQT_CFLAGS in TQT_CXX_FLAGS as well
I'm tagging the Summary as a "Build issue" for easier tracking and identification, and bumping the status to Major. Comment on attachment 652 [details]
Use check_cxx_source_runs, not check_c_source_runs
Pushed to GIT in hash 33aada3.
(Note that both of these patches are necessary for covariant checking to work. You probably noticed that, but your wording suggests that you applied-and-pushed only one of them...) Yes I am aware that both patches are needed; I waited to push the second one to see if I needed to push an unrelated patch to the common/cmake module at the same time. Second patch committed to GIT in hash 477d071. Thanks for reporting, and for the patches! |
Created attachment 652 [details] Use check_cxx_source_runs, not check_c_source_runs The covariant return check fails for two reasons: 1) it's using check_c_source_runs: C has no covariant return types :) 2) even if the right language was being used, most of the -I flags are missing because main/common/cmake/modules/FindTQt.cmake is buggy. Patches attached.