| Summary: | Ark broken show filenames into real UTF-8 (Cyrillic) | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Roman Savochenko <rom_as> |
| Component: | tdeutils | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | bugwatch, darrella, slavek.banko |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: |
Ark FilenameEncode ZipUTFProc patch
For set global encoding environment, need for ZIP Use 7zip instead of zip/unzip Ark × ark in kpart OK: Ark-7Z into konqueror window ALTLinux extension ARK patch ALTLinux extension ARK patch |
||
Created attachment 664 [details]
For set global encoding environment, need for ZIP
I tried the 7zip open in a separate window Ark - works great. But when I open 7zip in Konqeuror as a new tab (uses Ark as kpart) patch has no effect - UTF-8 characters are wrong. (In reply to comment #2) > I tried the 7zip open in a separate window Ark - works great. But when I open > 7zip in Konqeuror as a new tab (uses Ark as kpart) patch has no effect - UTF-8 > characters are wrong. In my case ark_part.desktop is disabled by default but after it enabling I have seen that correct work everywhere (ark, konqueror, krusader) for all tested archives: ZIP, TAR.GZ, TAR.BZ2, RAR, ARJ, 7Z. Created attachment 667 [details]
Use 7zip instead of zip/unzip
The unzip is another problem. His support for UTF-8 is a bit crappy - when listing the contents of ZIP archives instead of UTF-8 characters is listed '??'. Is there a work-around - instead of zip / unzip use 7z, which works without problems. Is it too daring?
Created attachment 668 [details]
Ark × ark in kpart
I use 3.5.13.1 and recompiled just a kdeutils.
(In reply to comment #4) > The unzip is another problem. His support for UTF-8 is a bit crappy - when > listing the contents of ZIP archives instead of UTF-8 characters is listed > '??'. Is there a work-around - instead of zip / unzip use 7z, which works > without problems. Is it too daring? Better fix zip/unzip for your Linux distributive. In my distributive, ALTLinux with UTF-8 no any problem present: [roman@roman tmp]$ unzip -v Прил.1_ТТ.zip Archive: Прил.1_ТТ.zip Length Method Size Cmpr Date Time CRC-32 Name -------- ------ ------- ---- ---------- ----- -------- ---- 14076 Defl:N 11594 18% 2012-06-07 21:53 3a5d9451 Дефектная ведомость внутр Прил к ТТ 8-2.xlsx 11819 Defl:N 9340 21% 2012-06-07 21:54 aeb9331c Дефектная ведомость фасад - кровля Прил к ТТ 7-1.xlsx 1266438 Defl:N 1230737 3% 2012-06-07 21:52 249112b8 ПРил.1_ТТ 1-ТПиР-КВВГЭС Приложения .pdf 616598 Defl:N 603159 2% 2012-06-07 21:50 a616c66c Прил.1_ТТ 1-ТПиР-КВВГЭС .pdf -------- ------- --- ------- 1908931 1854830 3% 4 files I also noticed that the Ark incorrectly parses the output from 7zip - in the name of the file leaves the leading space. Between column of compressed size and column with file names are the two spaces. But Ark removes only one - the second leaves as a part of the filename. Because it does not work properly with the contents of the archive - eg preview. Created attachment 669 [details] OK: Ark-7Z into konqueror window (In reply to comment #7) > I use 3.5.13.1 and recompiled just a kdeutils. For me all correct, use 3.5.13 partially patched from GIT and original ALTLinux patches. What is your locale? You have UTF-8 on the console? I have the cs_CZ.UTF-8. I tried to give just cs_CZ (that mean output in ISO8859-2) and the output from unzip is better, although it would be wrong (ISO × UTF). (In reply to comment #9) > What is your locale? You have UTF-8 on the console? I have the cs_CZ.UTF-8. I > tried to give just cs_CZ (that mean output in ISO8859-2) and the output from > unzip is better, although it would be wrong (ISO × UTF). My locale is: [roman@roman ark]$ env | grep LANG LANG=uk_UA.UTF-8 (Odpověď na komentář #10) > (In reply to comment #9) > > What is your locale? You have UTF-8 on the console? I have the cs_CZ.UTF-8. I > > tried to give just cs_CZ (that mean output in ISO8859-2) and the output from > > unzip is better, although it would be wrong (ISO × UTF). > > My locale is: > [roman@roman ark]$ env | grep LANG > LANG=uk_UA.UTF-8 I found the explanation for unzip: https://bugzilla.altlinux.org/show_bug.cgi?id=21137 You have also a problem with a leading space in the files names with 7zip in Ark? > You have also a problem with a leading space in the files names with 7zip in
> Ark?
No I have not that problem. the leading space in name file correct display and open/extract...
Created attachment 670 [details]
ALTLinux extension ARK patch
Combined patch for ARK from ALTLinux.
New functions: ARJ support, TEST archives, Archives password processing.
FIX: File-names into UTF-8 for all archives, LHA unpack check, Single directories pass for RAR and 7Z, some other.
Comment on attachment 667 [details]
Use 7zip instead of zip/unzip
There is a solution that corrects unzip - work-around is not needed.
It looks good - with 7zip is all already well - for me everything works as it should. But with zip for me still does not work preview by kpart. (In reply to comment #15) > It looks good - with 7zip is all already well - for me everything works as it > should. > But with zip for me still does not work preview by kpart. For ZIP you can and allowed to change file's names encoding by Konqueror menu item "Instruments"->"Network disk encoding" and the encoding selection will be save for further. Comment on attachment 670 [details]
ALTLinux extension ARK patch
Update patch for ZIP encoding into KPart.
Created attachment 671 [details] ALTLinux extension ARK patch >> It looks good - with 7zip is all already well - for me everything works as it >> should. >> But with zip for me still does not work preview by kpart. > For ZIP you can and allowed to change file's names encoding by Konqueror menu > item "Instruments"->"Network disk encoding" and the encoding selection will be > save for further. That is for KIO ZIP. For KPART_ARK_ZIP I have updated the patch. Great, thank you. With the latest version of the patch for me it all works flawlessly. I made a few TQt adjustments to be more consistent patch between 3.5.13.1 and R14. Fixed in GIT hash 1c84948d (and also in v3.5.13-sru branch). Sorry - I forgot to thank you in the commit log. Slavek, The ark portion of the patch pushed in GIT hash 1c84948d causes tdeutils to fail to build: rar.cpp:191: error: 'KPasswordDialog' has not been declared Note: Reversing the patch from 1c84948d allows tdeutils to build. (Odpověď na komentář #20)
> Slavek,
>
> The ark portion of the patch pushed in GIT hash 1c84948d causes tdeutils to
> fail to build:
>
> rar.cpp:191: error: 'KPasswordDialog' has not been declared
Interesting, I tested it with the v3.5.13.1 in Squeeze and Precise and with the current nightly builds in Squeeze and I have no problem encountered.
FTBFS fixed in GIT hash e782ad1b
One more patch needed for GIT: hash 219a425c. :-) (Odpověď na komentář #23)
> One more patch needed for GIT: hash 219a425c. :-)
Thank you. For me was compilation successful also before these patches. Therefore, it is difficult for me to find these problems.
There must be some no-so-obvious differences between 3.5.13 and GIT. Anyway, all done! :-) |
Created attachment 663 [details] Ark FilenameEncode ZipUTFProc patch Into 3.5.10 the problem is missing, but ZIP archive processing actuale also broken. From 3.5.12 you fix ZIP processing by broken filenames into UTF-8 display, for all archives. I has fix the problems. Filenames into UTF-8 (Cyrillic) correct display and ZIP correct processing now. The fix has tested on archives ZIP, ARJ, 7Z and RAR.