By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1050

Summary: Build issue: tdebase FTBFS against Qt3
Product: TDE Reporter: Darrell <darrella>
Component: tdebaseAssignee: Timothy Pearson <kb9vqf>
Status: RESOLVED FIXED    
Severity: blocker CC: bugwatch, darrella, robxu9
Priority: P1    
Version: R14.0.0 [Trinity]   
Hardware: Other   
OS: Other   
Compiler Version: TDE Version String:
Application Version: Application Name: tdebase

Description Darrell 2012-06-17 18:16:26 CDT
tdebase builds without error against TQt3 but fails to build against Qt3. The build output at the error:

[ 57%] Building CXX object kicker/kicker/core/CMakeFiles/kicker_core-static.dir/kmenubase.cpp.o
cd /dev/shm/tdebase.build/kicker/kicker/core && /usr/bin/c++   -DHAVE_CONFIG_H -O2 -march=i486 -mtune=i686 -ggdb -fvisibility=hidden -fvisibility-inlines-hidden  -DQT_NO_ASCII_CAST -DQT_CLEAN_NAMESPACE -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -I/opt/trinity/include -I/usr/include/tqt -DQT_NO_ASCII_CAST -DQT_CLEAN_NAMESPACE -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -I/dev/shm/tdebase.build/kicker/kicker/core -I/dev/shm/tdebase/kicker/kicker/core -I/dev/shm/tdebase.build/kicker/libkicker -I/dev/shm/tdebase.build -I/dev/shm/tdebase/kicker/libkicker -I/dev/shm/tdebase/kicker/kicker/ui -I/dev/shm/tdebase/kicker/kicker/buttons -I/opt/trinity/include -I/usr/include/tqt   -fPIC -o CMakeFiles/kicker_core-static.dir/kmenubase.cpp.o -c /dev/shm/tdebase.build/kicker/kicker/core/kmenubase.cpp
In file included from /dev/shm/tdebase.build/kicker/kicker/core/kmenubase.cpp:26:
/dev/shm/tdebase.build/kicker/kicker/core/kmenubase.ui.h: In member function 'void KMenuBase::init()':
/dev/shm/tdebase.build/kicker/kicker/core/kmenubase.ui.h:7: error: 't_xdisplay' was not declared in this scope
make[2]: *** [kicker/kicker/core/CMakeFiles/kicker_core-static.dir/kmenubase.cpp.o] Error 1
make[2]: Leaving directory `/dev/shm/tdebase.build'
make[1]: *** [kicker/kicker/core/CMakeFiles/kicker_core-static.dir/all] Error 2
make[1]: Leaving directory `/dev/shm/tdebase.build'
make: *** [all] Error 2
Comment 1 Timothy Pearson 2012-06-19 13:04:53 CDT
kicker/kicker/core/kmenubase.ui.h t_xdisplay is probably supposed to be tq_xdisplay.
Comment 2 Timothy Pearson 2012-06-25 22:39:57 CDT
This has been fixed in GIT hash 4c0b4c7.  At some point instances of t_xdisplay should be replaced with the proper tqt_xdisplay variable, but this is a relative nit.
Comment 3 Darrell 2012-06-26 10:33:39 CDT
Patch did not resolve the error:-(

/dev/shm/tdebase.build/kicker/kicker/core/kmenubase.ui.h:7: error: 't_xdisplay' was not declared in this scope
Comment 4 Darrell 2012-08-20 15:58:16 CDT
I don't know when, where, or how, but the original problem seems to have been resolved with no related build failures.

Yet as of today (Aug. 20) tdebase fails to build against Qt3 with the following:

/dev/shm/tdebase.build/tqt3integration/utils/tqtkde_functions.cpp:34: error: 'tqAppClass' was not declared in this scope
Comment 5 Darrell 2012-10-11 23:44:25 CDT
/dev/shm/tdebase.build/tqt3integration/utils/tqtkde_functions.cpp:34: error: 'tqAppClass' was not declared in this scope

Just checking but this bug still exists. I don't know how the tqtinterface build macros are supposed to change these things on-the-fly during a build. When building against TQt3 I'm sure tqAppClass is correct and when building against Qt3 qAppClass is correct.
Comment 6 Darrell 2012-10-12 00:39:52 CDT
The following patch allows tdebase to build against Qt3 but as might be expected, fails against TQt3.

diff -urN tdebase/tqt3integration/utils/gen.cpp tdebase.new/tqt3integration/utils/gen.cpp
--- tdebase/tqt3integration/utils/gen.cpp 2012-09-14 17:58:36.000000000 -0500
+++ tdebase.new/tqt3integration/utils/gen.cpp 2012-10-11 23:47:50.000000000 -0500
@@ -260,7 +260,7 @@
                 arg.create = "tqAppName";
                 function.args.append( arg );
                 arg.name = "wmclass2";
-                arg.create = "tqAppClass";
+                arg.create = "qAppClass";
                 function.args.append( arg );
                 }
             check( !function.return_type.isEmpty());
Comment 7 Timothy Pearson 2012-10-12 08:32:12 CDT
This should be fixed in GIT hash ecbb9fb (tqtinterface).  tqAppClass is the name TDE should be using, not qAppClass.

Tim
Comment 8 Darrell 2012-10-12 17:19:27 CDT
I just built tdebase against Qt3 with no incidents. I believe we can close this report as resolved.