By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1067

Summary:	Konqueror: Tab popup context menu does not include Move Tab Left/Right options
Product:	TDE	Reporter:	Darrell <darrella>
Component:	tdebase	Assignee:	Michele Calgaro <michele.calgaro>
Status:	RESOLVED FIXED
Severity:	minor	CC:	bugwatch, darrella, michele.calgaro, slavek.banko
Priority:	P1
Version:	R14.0.0 [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Attachments:	Patch to add items to tab context menu Konqueror move tab right/left patch

Description Darrell 2012-06-24 14:40:34 CDT

The Window menu includes options to move a tab to the left or right of the current position in the tab bar. These options do not exist in the popup context menu.

Comment 1 Darrell 2012-10-17 11:51:47 CDT

Created attachment 905 [details]
Patch to add items to tab context menu

This is a partial patch but very close to finish. I need help with one item: disabling the respective Move Tab Left/Right menu options when the tab is already the left-most/right-most tab. As commented in the patch, I tried adapting the code from konq_mainwindow.cc but the build always fails.

currently those menu items are not disabled in that mode, but selecting either menu option results in nothing happening and no crashes. Still, to match the parent Window menu, the items should be disabled.

Otherwise everything works as expected. :)

Please help!

Comment 2 Darrell 2013-03-02 21:11:09 CST

Patch in attachment 905 [details] pushed to GIT in commit 33b2e522.

Work is needed to disable the respective Move Tab Left/Right menu options when the tab is already the left-most/right-most tab.

Comment 3 Michele Calgaro 2013-10-17 09:56:30 CDT

I will look into this bug

Comment 4 Darrell 2013-10-17 16:06:51 CDT

Great! In case you are unaware, look at the konqueror Window menu to see the missing disabling effect from the tabs.

Comment 5 Michele Calgaro 2013-10-18 09:46:36 CDT

Created attachment 1560 [details]
Konqueror move tab right/left patch

This patch fixes this bug completely.
If you apply this patch after the ones for bug 909 and bug 910, there will be no fuzzs and no offsets

Comment 6 Michele Calgaro 2013-10-18 09:48:29 CDT

Changed status to PATCHAVAIL

Comment 7 Darrell 2013-10-18 13:25:48 CDT

Patch works great!

Comment 8 Slávek Banko 2013-10-19 18:00:52 CDT

Pushed to GIT in hash dd68da8.