| Summary: | Amarok: Incompatible sender/receiver arguments | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | non-core programs | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugwatch, darrella, kb9vqf, slavek.banko |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
I understand that signals and slots must use the same signature/argument types. As this is the only warning message related to using ratingOrScoreOrLabelsChanged as the slot, of which there are several, the problem must be with the signal ratingsColorsChanged. ratingsColorsChanged is declared in amarok/amarok/src/starmanager.h:44: void ratingsColorsChanged(); But ratingOrScoreOrLabelsChanged requires an argument type of ratingOrScoreOrLabelsChanged(const TQString&). A signal is emitted in amarok/amarok/src/starmanager.cpp:104 emit ratingsColorsChanged(); but nothing in that section of code seems to deal with a path. At this point I don't know how to proceed to fix ratingsColorsChanged. I read about using a helper slot, but then I'm quickly in over my head. At least some of this is already solved in commit 670b8acb. Please, can you try this and update this bug report? The messages originally reported at startup no longer appear. Good job! When closing Amarok I see the same messages as originally reported: TQObject::disconnect: Unexpected null parameter TQObject::connect: Cannot connect (null)::activePartChanged( KParts::Part * ) to TDEHTMLPart::slotActiveFrameChanged( KParts::Part * ) The remainder of this report should be fixed in GIT hash ecaf622. Thanks for reporting! Tested. All quiet and clean. Thanks! (Odpověď na komentář #4)
> The remainder of this report should be fixed in GIT hash ecaf622.
>
> Thanks for reporting!
I do not see GIT hash ecaf622 in amarok.
Is it hash 0c399be5?
tdelibs, not amarok. I got fooled by that too. :-) |
I notice the following messages in my xsession log when I start Amarok: TQLayout "unnamed" added to TQVBox "unnamed", which already has a layout TQLayout: Adding KToolBar/mainToolBar (child of TQVBox/unnamed) to layout for PlaylistWindow/PlaylistWindow TQObject::connect: Incompatible sender/receiver arguments StarManager::ratingsColorsChanged() --> ContextBrowser::ratingOrScoreOrLabelsChanged(const TQString&) That looks like two different bugs. When quitting Amarok I see the following: TQObject::disconnect: Unexpected null parameter TQObject::connect: Cannot connect (null)::activePartChanged( KParts::Part * ) to KHTMLPart::slotActiveFrameChanged( KParts::Part * ) Note: I observe the same equivalent messages in KDE3. Therefore these "bugs" have existed before Trinity: KDE3 startup: QLayout "unnamed" added to QVBox "unnamed", which already has a layout QLayout: Adding KToolBar/mainToolBar (child of QVBox/unnamed) to layout for PlaylistWindow/PlaylistWindow QObject::connect: Incompatible sender/receiver arguments StarManager::ratingsColorsChanged() --> ContextBrowser::ratingOrScoreOrLabelsChanged(const QString&) KDE3 quitting: QObject::disconnect: Unexpected null parameter QObject::connect: Cannot connect (null)::activePartChanged( KParts::Part * ) to KHTMLPart::slotActiveFrameChanged( KParts::Part * ) I am not noticing any failures with Amarok, but that does not mean other people don't or that the bugs are not related to other Amarok bug reports. :-)