Bug 1109

It seems that in 3.5.13.x is kde-style-qtcurve compiled incorrectly - style is just as pure qt style. See: QTC_QT_ONLY.

In any case, it is still much better than the R14-nighly because there are packages qtcurve completely broken - there is nothing in them.

Created attachment 795 [details]
Build log for 3.5.13-sru on Squeeze

I tried to find why qtcurve does not compile as TDE style, but only as "plain QT" style. I added to cmake parameters:
 -DQTC_QT_ONLY=false
 -DQTC_BUILD_CONFIG_MODULE=true
 -DQTC_DEFAULT_TO_KDE3=true

But in build configuration module occurs error.
See build log.

Hello, it looks like the CMakeLists.txt files are designed to use kde3 macros , not TDE . There are hardcoded path to kde3 etc ... so it can't work in TDE.
I will look into it, but there will be several modifications.

Okay, I'll try to backport changes for replace CMake to the TDE standard and TQt conversion. Stay tuned :)

Also, there are FTBFS in the "config" module.
I guess that's why there is an explicit message in the main "CMakeLists.txt":

message("**************************************************************\n"
                "Warning: The KDE3 config module is deprecated, and is no longer\n"
                "         actively maintained. This module NO LONGER COMPILES!\n"
                "         It is recommended to use the KDE4 version instead.\n"
                "**************************************************************\n")

Oh well... either we can build it by disabling unsupported features, or we have to give up with this module ...

When there is no compiled configuration module, style is compiled only as plain qt3 style, not as a TDE style. See CMakeLists.txt:

if (QTC_BUILD_CONFIG_MODULE)
    if (NOT QTC_QT_ONLY)
        find_package(KDE3)
        if (NOT KDE3_FOUND)
            set(QTC_QT_ONLY true)
            message("INFO: KDE3 not found! Compiling for Qt only! (Not building the config modu
le)")
        endif (NOT KDE3_FOUND)
    endif (NOT QTC_QT_ONLY)
else (QTC_BUILD_CONFIG_MODULE)
    set(QTC_QT_ONLY true)
endif (QTC_BUILD_CONFIG_MODULE)

For this reason, I try to build including config module.

Packaging for R14 fixed in GIT hash 55642292
Problem in v3.5.13-sru yet remains unresolved.

Created attachment 798 [details]
Workaround config module FTBFS

The attached patch allow build of "config" module without FTBFS. But at this time I still do not know if it works ...

Created attachment 799 [details]
Fix inadvertent TQ/Q renaming of #ifdef

It looks like automatic Q/TQ renaming has modified #ifdef variables. This patch reverts the changes.

Created attachment 800 [details]
Initial CMake conversion from KDE3 to TDE

The attached patch is an attempt to update the CMakeLists.txt files to the TDE-style.
I manage to build qtcurve TDE style with it, but it still does not work at runtime.

With all 3 attached patches, I'm now building with:

cmake \
	-DTDEPREFIX=/opt/trinity \
	-DTDE_INCLUDE_DIR=/opt/trinity/include/kde \
	-DQTC_QT_ONLY=false \
	-DQTC_BUILD_CONFIG_MODULE=true \
	-DQTC_DEFAULT_TO_KDE3=true \
	-DQTC_STYLE_SUPPORT=true \
	..

And as a result, I get the following files:

/opt/trinity/lib64/trinity/kstyle_qtcurve_config.la
/opt/trinity/lib64/trinity/kstyle_qtcurve_config.so
/opt/trinity/lib64/trinity/plugins/styles/qtcurve.la
/opt/trinity/lib64/trinity/plugins/styles/qtcurve.so
/opt/trinity/share/apps/QtCurve/Agua.qtcurve
/opt/trinity/share/apps/QtCurve/Agua_II.qtcurve
/opt/trinity/share/apps/QtCurve/Curve.qtcurve
/opt/trinity/share/apps/QtCurve/Flat.qtcurve
/opt/trinity/share/apps/QtCurve/Human.qtcurve
/opt/trinity/share/apps/QtCurve/Inverted.qtcurve
/opt/trinity/share/apps/QtCurve/Klearlooks.qtcurve
/opt/trinity/share/apps/QtCurve/Milk.qtcurve
/opt/trinity/share/apps/QtCurve/Murrine.qtcurve
/opt/trinity/share/apps/QtCurve/Ozone.qtcurve
/opt/trinity/share/apps/QtCurve/Plastic.qtcurve
/opt/trinity/share/apps/QtCurve/Silk.qtcurve
/opt/trinity/share/apps/kdisplay/color-schemes/QtCurve.kcsrc
/opt/trinity/share/apps/kstyle/themes/qtcurve.themerc
/opt/trinity/share/doc/trinity-style-qtcurve
/opt/trinity/share/doc/trinity-style-qtcurve/AUTHORS
/opt/trinity/share/doc/trinity-style-qtcurve/COPYING
/opt/trinity/share/locale/tr/LC_MESSAGES/qtcurve.mo

But, I still do not see the "QTcurve" (or TQTCurve) style in the "kcmshell style" dialog box ...

I forgot to mention, that you need to add the "cmake" submodule in order to build with TDE macros.

Thank you, I look forward to try it, because with backport patches from R14, I just got into a blind alley.

François, thank you. With small modifications (tqt I have in /usr/include/tqt, qt in /usr/include/qt3) I have also builded the package!

Then I prepared next patch. And with that QtCurve is working again - I see QtCurve in the style settings, I can select it and style is working.

Now I have to go away - I'll attach my updated patches later.

Created attachment 801 [details]
Revert TQtCurve to QtCurve and fix build along qt3

François, first faster way, to you could also test the patch. I've noticed that perhaps still not work config window. Please, test it.

Now I try to combine your patches, my patches and backport patches to consolidated patches for v3.5.13-sru.

Created attachment 802 [details]
Revert TQtCurve to QtCurve and fix build along qt3 (1)

Update: re-added missing #include "qtcurve.moc"

OK with your latest patch I now have qtcurve in the style chooser window.
I can select and activate it => it works.

I can also open the "configure" window, some settings seem to work, some seems to not. There are too many of them I did not test everything.

Also, I've noticed some settings have label "KDE4 only" or "KDE4/GTK2 only" in this configure window.

Patches consolidated and settings also work well for me. Wow - such a huge number of settings I did not expect :)

I do not know which of those settings affect really only KDE4. Or which of them also have an influence on TDE. I propose to close this bug report and to move the discussion about them into mailing list.

I agree, we can close this bug now since the build issue is solved.
If there are usability problems with Qtcurve, we will open another bug report.