| Summary: | Nightly twin crashes when running Wine 1.5 | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Julius Schwartzenberg <julius.schwartzenberg> |
| Component: | tdebase | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | CC: | bugwatch, darrella |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: | Backtrace that's generated when twin crashes | ||
This upstream glibc bug may be related: http://sourceware.org/bugzilla/show_bug.cgi?id=13138 Simply put, there is no reason for an elementary function such as fscanf to fail after fopen succeeds when it has been passed correct arguments! Do you think it would be difficult to create a simple test case? It would help with reporting this as a bug against Ubuntu (if that hasn't been done already). For reference, here is the crashing code:
procfile = fopen("stat", "r");
<verify that procfile is not NULL, other unrelated code>
long long int procpid;
<unrelated code>
fscanf(procfile, "%lld ", &procpid);
(In reply to comment #2) > Do you think it would be difficult to create a simple test case? It would help > with reporting this as a bug against Ubuntu (if that hasn't been done already). Well, here is an almost direct copy+paste from the twin sources: int main() { long long pid = <insert extant large PID here>; FILE *procfile; if(chdir(TQString("/proc/%1").arg(pid).ascii()) == 0) { procfile = fopen("stat", "r"); } if(!procfile) { return false; } else { long long int procpid; char tcomm[PATH_MAX]; char state; fscanf(procfile, "%lld ", &procpid); fscanf(procfile, "%s ", tcomm); fscanf(procfile, "%c ", &state); if( state == 'T' ) { fclose(procfile); return true; } else { fclose(procfile); return false; } } } This code could probably be converted to use TQFile, which would avoid the crash. I'll see what I can do. Converted to TQFile in GIT hash c7ae64e. If twin still crashes after packages have been rebuilt, please reopen this report with a new backtrace. |
Created attachment 709 [details] Backtrace that's generated when twin crashes Nightly twin crashes when running Wine 1.5 on Ubuntu Precise. I have attached a backtrace.