Bug 1133

Created attachment 718 [details]
Fix compilation for 'kdeaccessibility'

Created attachment 719 [details]
Fix compilation for 'kdebindings'

Created attachment 720 [details]
Fix compilation for 'kdeedu'

Created attachment 721 [details]
Fix compilation for 'kdegames'

Created attachment 723 [details]
Fix compilation for 'kdemultimedia'

Created attachment 724 [details]
Fix compilation for 'kdetoys'

Created attachment 725 [details]
Fix compilation for 'kdeutils'

Comment on attachment 724 [details]
Fix compilation for 'kdetoys'

SOrry wrong file !!!

Created attachment 726 [details]
Fix compilation for 'kdetoys'

OK it looks like I've found all TDE base packages missing LDFLAGS for Mageia 2. I set the bug as patchavail.

Created attachment 727 [details]
Fix compilation for 'kdewebdev'

Created attachment 730 [details]
Fix compilation for 'kdemultimedia' (2)

Created attachment 739 [details]
Fix compilation for 'kaffeine'

François, thank you for your good work. Please, can be used $(LIB_QT), $(LIB_KDEUI), $(LIB_KDECORE) (and others) also in all previous patches? In some of them is used -lqt_mt, -lkdecore,... I'd rather see all with variables. Is it possible?

Created attachment 740 [details]
Fix compilation for 'kdeaccessibility' (2)

There is no $(LIB_DCOP) variable in kdeaccessibility, so we have to use -lDCOP directly (it is already hardcoded in several places anyway).

Created attachment 741 [details]
Fix compilation for 'kdegames' (2)

These flags are not defined in any variable so they are hardcoded for now: -lkdefx -lartsmodules

Created attachment 742 [details]
Fix compilation for 'kdebindings' (2)

The following flags are not defined in any variable and are hardcoded for now: -lDCOP -lkdefx

Created attachment 743 [details]
Fix compilation for 'kdeedu' (2)

The following flag is not defined in any variable and is hardcoded for now: -lDCOP

Created attachment 744 [details]
Fix compilation for 'kdemultimedia' (3)

The following flags are not defined in any variables and are hardcoded for now:
-lartsflow_idl
-lkdefx
-lglib-2.0
-lgthread-2.0
-lDCOP
-lktexteditor
-lartsflow_idl
etc ... There are many many already hardcoded flags in kdemultimedia !

Created attachment 745 [details]
Fix compilation for 'kdetoys' (2)

The following flag must be hardcoded: -lDCOP

OK I think I've updated all patches for TDE base components.
Alas there are still flags that are always hardcoded (-lDCOP, -lkdefx ...)

(Odpověď na komentář #21)
> OK I think I've updated all patches for TDE base components.
> Alas there are still flags that are always hardcoded (-lDCOP, -lkdefx ...)

Thank you, good work. That I know some are hardcoded.
For now, remain as they are.

For juk are added -lakode.
It is not necessary to use $(akode_libs)?

Created attachment 746 [details]
Fix compilation for 'kdemultimedia' (4)

Yes, -lakode can be replaced with $(akode_libs) , confirmed working.

Created attachment 748 [details]
Fix compilation for 'digikam'

Created attachment 750 [details]
Fix compilation for 'gwenview'

Comment on attachment 750 [details]
Fix compilation for 'gwenview'

grrr already obsolete

Created attachment 751 [details]
Fix compilation for 'gwenview' (2)

Created attachment 752 [details]
Fix compilation for 'k3b'

Created attachment 753 [details]
Fix compilation for 'k9copy'

Created attachment 754 [details]
Fix compilation for 'k9copy'

Created attachment 755 [details]
Fix compilation for 'kbfx'

Created attachment 756 [details]
Fix compilation for 'k3b' (2)

Created attachment 757 [details]
Fix compilation for 'kdbusnotification'

Created attachment 760 [details]
Fix compilation for 'kerry'

Created attachment 761 [details]
Fix compilation for 'kmplayer'

Created attachment 762 [details]
Fix compilation for 'kmyfirewall'

Created attachment 764 [details]
Fix compilation for 'koffice'

Created attachment 765 [details]
Koffice: fix lcms library detection due to incomplete linker command line (needed for chalk building)

Created attachment 767 [details]
Fix compilation for 'kpilot'

Created attachment 768 [details]
Fix compilation for 'kstreamripper'

Created attachment 770 [details]
Fix compilation for 'ktechlab'

Created attachment 771 [details]
Fix compilation for 'ktorrent'

Created attachment 772 [details]
Fix compilation for 'kuickshow'

Created attachment 773 [details]
Fix compilation for 'kvirc'

There are no automake variables like LIB_KIO, etc ... in kvirc.
So we have to hardcode the linker flags for now.

Created attachment 774 [details]
Fix compilation for 'kerry' (2)

(Odpověď na komentář #16)
> Vytvořena příloha 741
> Fix compilation for 'kdegames' (2)
> 
> These flags are not defined in any variable so they are hardcoded for now:
> -lkdefx -lartsmodules

I tried to include a patch for kdegames, but -lartsmodules causes FTBFS on both my test machines - Squeeze and Precise:

/usr/bin/ld: cannot find -lartsmodules

Is -lartsmodules necessary on your distributions?

Yes kvirc FTBFS if I do not use the flag -lartsmodule.

/opt/trinity/lib/libartmodules.so comes with tdemultimedia-devel .

I think that kvirc wants to use it as soon as it is installed, probably it is autodetected in ./configure .

(Odpověď na komentář #47)
> Yes kvirc FTBFS if I do not use the flag -lartsmodule.
> 
> /opt/trinity/lib/libartmodules.so comes with tdemultimedia-devel .
> 
> I think that kvirc wants to use it as soon as it is installed, probably it is
> autodetected in ./configure .

Thanks for the hint. I added kdemultimedia-trinity-dev to build-deps and has already successfully builded kdegames.

(Odpověď na komentář #18)
> Vytvořena příloha 743
> Fix compilation for 'kdeedu' (2)
> 
> The following flag is not defined in any variable and is hardcoded for now:
> -lDCOP

Please, I came across another problem - with kdeedu: 

/usr/bin/ld: cannot find -lkdecore
/usr/bin/ld: cannot find -lkio
/usr/bin/ld: cannot find -lkdeui
/usr/bin/ld: cannot find -lDCOP
collect2: ld returned 1 exit status
make[6]: *** [libkvoctraincore.la] Error 1

You have paths defined outside - in QT_LDFLAGS?

You can try to remove the "libkvoctraincore_la_LDFLAGS = $(QT_LDFLAGS)" line to see if it helps.
But the QT_LDFLAGS variables is supposed to contain QT only directive, not linker flags.

E.g it may contain:
-DQT_SHARED -DQT_NO_DEBUG -DQT_THREAD_SUPPORT -D_REENTRANT -I/usr/lib/qt3//include

(Odpověď na komentář #50)
> You can try to remove the "libkvoctraincore_la_LDFLAGS = $(QT_LDFLAGS)" line to
> see if it helps.
> But the QT_LDFLAGS variables is supposed to contain QT only directive, not
> linker flags.
> 
> E.g it may contain:
> -DQT_SHARED -DQT_NO_DEBUG -DQT_THREAD_SUPPORT -D_REENTRANT
> -I/usr/lib/qt3//include

Unfortunately, even after you delete a row with QT_LDFLAGS.

But I tried another - add $(all_libraries) $(KDE_RPATH) to libkvoctraincore_la_LIBADD and the success came.
The final state of the part of patch:

diff --git a/kvoctrain/kvoctrain/kvt-core/Makefile.am b/kvoctrain/kvoctrain/kvt-core/Makefile.am
index fe35690..d12eb34 100644
--- a/kvoctrain/kvoctrain/kvt-core/Makefile.am
+++ b/kvoctrain/kvoctrain/kvt-core/Makefile.am
@@ -12,6 +12,6 @@ libkvoctraincore_la_SOURCES = langset.cpp LineList.cpp kvoctrainexpr.cpp \

 SUBDIRS = kvt-xml

-libkvoctraincore_la_LIBADD= kvt-xml/libkvtxml.la
+libkvoctraincore_la_LIBADD= $(all_libraries) $(KDE_RPATH) kvt-xml/libkvtxml.la ../common-dialogs/libcommondlg.la $(LIB_QT) $(LIB_KDECORE) $(LIB_KIO) $(LIB_KDEUI) -lDCOP

 noinst_HEADERS = grammarmanager.h

Please try for yourself.

Your patch is working for me .

First part - patches for base packages pushed to GIT (into master and also v3.5.13-sru):
+ kdemultimedia - GIT hash 023e7b38
+ kdeutils - GIT hash 81a4c134
+ kdetoys - GIT hash 41013366
+ kdegames - GIT hash 098b76c8
+ kdeaccessibility - GIT hash 39836a51
+ kdeedu - GIT hash 2b25aaa0
+ kdewebdev - GIT hash bc2d0c74
+ kdebindings - GIT hash 50ec787f

Created attachment 776 [details]
Fix compilation for 'kdebase'

François, for kbfx were in v3.5.13-sru branch picked patches, which is fundamentally changing CMake files. Therefore, patch for kbfx can not be applied.

Note: The second part of kmplayer patch is already included in the commit 611a89f3 (also cherry-picked in v3.5.13-sru). Therefore, I used only the first part.

François, I think that patch for kvirc is not needed because in both the R14 and v3.5.13-sru is already included commit 136d2c86 that adds the specified libraries if kvirc is compiled with KDE / TDE support (see SS_LIBLINK). Please can you confirm this?

Second part - patches for applications pushed to GIT (into master and also
v3.5.13-sru):
+ digikam - 87ea6d1b
+ gwenview - 9ed52cc7
+ k3b - 730967a4
+ k9copy - b9fa9216
+ kaffeine - fd9e0b2a
+ kdbusnotification - 45f1f04b
+ kerry - 48da9e7f
+ kmplayer - 1b07da42
+ kmyfirewall - 4d139e0e
+ koffice - d388dc54, 02061797
+ kpilot - f4e58947
+ kstreamripper - 149306dd
 (only in v3.5.13-sru, in master already solved in another commit)
+ ktechlab - e61b40d3
+ ktorrent - fbbc3160
+ kuickshow - 2864ae94

Last - patch for kdebase - pushed to GIT (into master and also
v3.5.13-sru) - hash 02f53174.