| Summary: | Build issue: TDEEDU FTBFS when linking with --no-undefined | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Francois Andriot <albator78> |
| Component: | tdeedu | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | CC: | albator78, bugwatch, darrella, kb9vqf, slavek.banko |
| Priority: | P5 | ||
| Version: | 3.5.13 [Trinity] | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: |
kdeedu 3.5.13.2 : log file FTBFS under Mageia 2
kdeedu 3.5.13.2 : generated Makefiles on mageia2 |
||
|
Description
Francois Andriot
2012-08-01 10:48:23 CDT
I cannot reproduce this bug when building from GIT with the no-undefined flag set. Can you confirm that this is still an issue? Thanks! Francois, is this still an issue? :) Yes, problem still exists, no change at all. (In reply to comment #3) > Yes, problem still exists, no change at all. Can you give detailed instructions on how to reproduce the issue? I have tried several times to force no-undefined, and can in fact see the -no-undefined flag in the compiler/linker commands, but I cannot reproduce this bug. Created attachment 1139 [details]
kdeedu 3.5.13.2 : log file FTBFS under Mageia 2
First, here is the complete log file of FTBFS.
There you can find my CXXFLAGS and ./configure command, among others.
Created attachment 1140 [details]
kdeedu 3.5.13.2 : generated Makefiles on mageia2
And here are the generated Makefiles under Mageia 2, in case you find something useful in there.
(I suspect something is wrong with autotools here, since it is working on other distribution without problems, only Mageia 2 has problem)
OK, I see the problem in kvoctrain. Essentially, the original developer tried to avoid duplication of code (method getCsvOrder), but that is only possible if undefined symbols are allowed during build. I have copied that method into the kvoctrain core library, which allows kvoctrain to build as far as I can tell. This has been pushed to GIT in hash c5dacf5. Please let me know if tdeedu now builds on Magia, as I have no way to test a full build on that platform here. Nice find, it is working now, FTBFS has gone on Mageia 2. I don't know why this does not fail on Mageia2, but tdeedu FTBFS for me on Slackware 14: kvd_csv.cpp:66:9: error: '::find' has not been declared The code was added in commit c5dacf57 2013-04-07. (Odpověď na komentář #9)
> I don't know why this does not fail on Mageia2, but tdeedu FTBFS for me on
> Slackware 14:
>
> kvd_csv.cpp:66:9: error: '::find' has not been declared
>
> The code was added in commit c5dacf57 2013-04-07.
Added in c5dacf57, but removed in subsequent 2e1267ad.
Please, try it with latest GIT == 2e1267ad.
I have GIT == 2e1267ad. I updated my GIT repo this afternoon, which includes the gwenview patches too. I don't think my local repo is updating correctly. Using git log -p I see the patch from 2e1267ad but the sources of kvd_csv.cpp still has the ::find code. How do I force my local repo to update? Then again perhaps my local repo is fine. My copy of kvd_csv.cpp is the same as upstream: http://git.trinitydesktop.org/cgit/tdeedu/plain/kvoctrain/kvoctrain/kvt-core/kvd_csv.cpp Notice upstream has ::find as well. What gives? I see the confusion. The removal of ::find in commit 2e1267ad was for file kva_clip.cpp. My fail error was in kvd_csv.cpp. So the failure still stands and I can't build tdeedu. (In reply to comment #14) > I see the confusion. The removal of ::find in commit 2e1267ad was for file > kva_clip.cpp. My fail error was in kvd_csv.cpp. > > So the failure still stands and I can't build tdeedu. Try adding this line to the #include block of kvd_csv.h, under #include <vector>: #include <algorithm> If that works go ahead and commit it to GIT. > Try adding this line to the #include block of kvd_csv.h, under #include <vector>: > #include <algorithm> > If that works go ahead and commit it to GIT. Patch pushed to GIT in commit d4ee0601. |