By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1195

Summary:	Desktop icon 'My computer'
Product:	TDE	Reporter:	Alexis PM <alexispm_stellaluna>
Component:	debian	Assignee:	Timothy Pearson <kb9vqf>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	bugwatch, darrella, slavek.banko
Priority:	P5
Version:	3.5.13 [Trinity]
Hardware:	All
OS:	All
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Attachments:	Fix kubuntu links in konqueror Patch to restore konueror links to 3.5.10

Description Alexis PM 2012-09-01 15:16:13 CDT

The 'My computer' and 'Menu T > System menu' icons has the Kubuntu logo. It is important to clean Kubuntu references (images and text) in TDE.

Comment 1 Darrell 2012-09-02 01:51:19 CDT

Fixed in GIT.

Slavek, is this fixed in 3.5.13.1 SRU?

Comment 2 Slávek Banko 2012-09-02 20:01:29 CDT

Unfortunately not. Plaase, you know patch hash?

However, the small icon is nothing against big inscriptions: About Kubuntu and Kubuntu Documentation on Konqueror about page. :)

Comment 3 Darrell 2012-09-02 20:04:11 CDT

I don't have Kubuntu. Post a screenshot of the problem and that might help me remember which of the many branding patches might be the cure.

Comment 4 Slávek Banko 2012-09-03 09:52:19 CDT

I found the following:

1. Icons device/system and aboutkde are replaced in the debian / ubuntu packages (in tde-packaging). I suggest cancel this replacement icons. I'll ask Tim.

2. tdebase/konqueror/about/konq_aboutpage.cc lines 171 and 172, tdebase/konqueror/about/launch.html lines 113 and 116 still refer to Kubuntu. That should be changed.

Comment 5 Darrell 2012-09-03 13:53:27 CDT

Created attachment 803 [details]
Fix kubuntu links in konqueror

I presume Tim wants to retain the Kubuntu links for Kubuntu builds. I'm attaching a proposed patch.

Comment 6 Timothy Pearson 2012-09-03 15:04:29 CDT

(In reply to comment #5)
> Created attachment 803 [details]
> Fix kubuntu links in konqueror
> 
> I presume Tim wants to retain the Kubuntu links for Kubuntu builds.

Not really.  I do not build or provide packages for Kubuntu and therefore should not be linking to its homepage.

Tim

Comment 7 Slávek Banko 2012-09-03 15:24:48 CDT

Darrell, please, can you find out from KDE 3.5.10, what used originally in the place where it is now About Kubuntu?

Comment 8 Slávek Banko 2012-09-03 15:29:06 CDT

Tim, can I also disable the replacement of icons device/system and aboutkde in tde-packaging?

Comment 9 Timothy Pearson 2012-09-03 15:41:39 CDT

(In reply to comment #8)
> Tim, can I also disable the replacement of icons device/system and aboutkde in
> tde-packaging?

I'd like to keep the replacement of device/system if possible, as that provides a non-obtrusive clue that the base system is Ubuntu.  The aboutkde replacement could probably be disabled though.

Tim

Comment 10 Darrell 2012-09-03 15:46:43 CDT

Created attachment 804 [details]
Patch to restore konueror links to 3.5.10

Here is a patch restoring to 3.5.10 links. I'm rebuilding right now to test.

Comment 11 Slávek Banko 2012-09-03 15:48:55 CDT

(Odpověď na komentář #9)
> (In reply to comment #8)
> > Tim, can I also disable the replacement of icons device/system and aboutkde in
> > tde-packaging?
> 
> I'd like to keep the replacement of device/system if possible, as that provides
> a non-obtrusive clue that the base system is Ubuntu.  The aboutkde replacement
> could probably be disabled though.
> 
> Tim

Ok, sure, replacement device/system icons is really non-obtrusive. A replacement will only keep for Ubuntu or even for Debian?

Comment 12 Timothy Pearson 2012-09-03 16:06:36 CDT

(In reply to comment #11)
> (Odpověď na komentář #9)
> > (In reply to comment #8)
> > > Tim, can I also disable the replacement of icons device/system and aboutkde in
> > > tde-packaging?
> > 
> > I'd like to keep the replacement of device/system if possible, as that provides
> > a non-obtrusive clue that the base system is Ubuntu.  The aboutkde replacement
> > could probably be disabled though.
> > 
> > Tim
> 
> Ok, sure, replacement device/system icons is really non-obtrusive. A
> replacement will only keep for Ubuntu or even for Debian?

Ubuntu only.  If Debian provides a similar replacement icon with its logo, we should use that.

Tim

Comment 13 Darrell 2012-09-03 16:30:17 CDT

The patch works. Here is a screen grab of the restored link:

http://humanreadable.nfshost.com/trinity/build_logs/konq-about-1.png

Here is a screen grab after selecting the restored link:

http://humanreadable.nfshost.com/trinity/build_logs/konq-about-2.png

Comment 14 Slávek Banko 2012-09-03 19:06:04 CDT

Replacement aboutkde logo (on Debian and Ubuntu)
and icons device/system (on Debian)
disabled in GIT hash 8c8660b7

Comment 15 Slávek Banko 2012-09-04 10:30:37 CDT

I tried patch also in v3.5.13-sru and it looks good.
I believe that you can push it.

Comment 16 Darrell 2012-09-04 13:25:39 CDT

Patch pushed in commit 495b5680.

Does that conclude the concerns of this bug report?

Comment 17 Slávek Banko 2012-09-04 18:54:05 CDT

Yes, I believe that this issue can be closed. Icons were resolved in commit to tde-packaging, and commit to tdebase in addition resolves about page.

Both pushed also to GIT branch v3.5.13-sru.