Bug 1199

Created attachment 806 [details]
Fix library dir for Xrender

The attached patch adds the Xrender library directory to the CMakeLists.txt files used by tdelibs.

Please, we can expect that similar patches will also be for other modules?
If I should wait for them for 3.5.13.1.

I will post other patches but you should not wait for them to release 3.5.13.1, since RHEL 4 will not be an officially supported distribution for now. I will stick with patches for the moment.

RHEL4 was released in 2005 and support ended in 2012.
It is providing, among other:
- kernel 2.6.9
- KDE 3.3 / qt 3.3.3
- Xorg 6.8.2
- hal 0.4.8
- dbus 0.22
- gcc 3.4.6

Even though it is obsolete, I guess it was really a stable distribution and I would not be surprized if some companies still use it.
I will post here some patches that allow building TDE on RHEL4.

These patches are ugly hacks that should NOT go upstream, they are given for information only.
It will help people wanting to build on old distributions.
It may also give ideas to us to enhance our build scripts and make better patches.


The main problems when building TDE on RHEL4 are:
- You need to install CMAKE 2.8
- Dbus is too old and does not meet TDE's requirement. Dbus-tqt will not build at all, but we can still use dbus-qt.
- Dbus is built without QT support, so you have to rebuild RHEL4's dbus with QT support.
- Hal is too old and does not meet TDE's requirement, hopefully we can build without HAL.
- Xorg is installed under /usr/X11R6 , so you need to set "-I/usr/X11R6/include -L/usr/X11R6/lib" in CXXFLAGS and other variables ...
- Xorg lacks some features that are marked as mandatory in TDE (not really mandatory, but CMAKE wants them. E.g: consolekit)
- Many development packages lack a pkgconfig file, so CMAKE checks often fails even if the library is installed

Created attachment 1156 [details]
kdebase: workaround some libraries detection lacking pkgconfig files

Created attachment 1157 [details]
kdebase: build without dbus-tqt

Created attachment 1158 [details]
kdebase: disable hardcoded consolekit support

Created attachment 1159 [details]
kdebase: build without dbus-tqt (3.5.13.2)

Created attachment 1160 [details]
kdebase: allow to build without COMPOSITE support

Created attachment 1161 [details]
kdebase: downgrade HAL backend to support HAL 0.4

This HAL related patch does not work, it is based on older KDE3 code when HAL 0.4 was supported.
Even after applying it, it looks like TDE does not use HAL properly.

Created attachment 1162 [details]
kdebase: kompmgr FTBFS on RHEL4

So, what is the conclusion ?
TDE 3.5.13.2 is buildable on RHEL4 with these patches, and it works pretty well.
There are some features missing (mostly HAL and multimedia related). Still, most package build, and it offers a very nice upgrade to the legacy KDE 3.3 .

I've read on some places that "Trinity should have been available for old KDE3-based distributions, not just modern distributions". As you can see, it is possible !

I will release a RHEL4 repository for TDE 3.5.13.2 , as an ultimate upgrade to this old-but-good distribution.

Created attachment 1225 [details]
kdeutils: allow building when libXext is missing

Francois, what is the status of this bug with the current v14 sources?
Any update needed?

Comment on attachment 806 [details]
Fix library dir for Xrender

Updated and pushed to GIT in hash 1d49899.

Are there any other patches in this report that should make their way into GIT, or are the remaining patches Ugly Hacks(TM)?

If no further changes should be made to GIT I'd like to mark this report WONTFIX.

(In reply to Timothy Pearson from comment #15)
> Comment on attachment 806 [details]
> Fix library dir for Xrender
> 
> Updated and pushed to GIT in hash 1d49899.

I believe that much of this patch was unnecessary. Wherever in the folders specified ${TDECORE_LIBRARY_DIRS} is already ${XRENDER_LIBRARY_DIRS} contained in this variable => ${XRENDER_LIBRARY_DIRS} is now redundant, unnecessary. And the other cases I doubt if is needed adding ${XRENDER_LIBRARY_DIRS}.

I was hoping François will test and update this patch before pushing. Pity that the patch has been pushed.

(In reply to Slávek Banko from comment #17)
> I was hoping François will test and update this patch before pushing.
> Pity that the patch has been pushed.
We can always revert the patch and check whether it is really necessary or not ;-)

Latest commit causes FTBFS because there is a trailing backslash.
These patches were/are intended to build TDE 3.5.13.2 on RHEL4.
I do not intend to update them for R14 because I won't build TDE 14.0.0 for RHEL4.

You can close the bug as WONTFIX.

If commit 1d49899 was not necessary as Slavek said, I suggest we revert it before closing the bug as WONTFIX.

Commit 1d49899 reverted.
As already mentioned, the patches are not designed to be pushed into the GIT.

OK, my fault.  Sorry for not understanding the first time around!