| Summary: | Broken KPowersave icons | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Jan Stolarek <jwstolarek> |
| Component: | tdenetwork | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | bugwatch, darrella, jwstolarek |
| Priority: | P5 | ||
| Version: | 3.5.13 [Trinity] | ||
| Hardware: | amd64 | ||
| OS: | Debian Squeeze | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: |
A broken icon
Correct KPowersave icon in system tray |
||
Created attachment 848 [details]
Correct KPowersave icon in system tray
(In reply to comment #1) > Created attachment 848 [details] > Correct KPowersave icon in system tray If you look closely at that icon you will see that its edges are clipped. This is likely due to incomplete implementation of the tray icon resizing feature in OpenSUSE. That being said, I note that kpowersave in TDE provides the small ("broken") icons in question specifically for use in a 16x16 pixel environment: http://git.trinitydesktop.org/cgit/kpowersave/tree/src/pics If those small icons are so ugly as to prompt a bug report (as they apparently are!), we definitely need to so something about that. :-) Also, the icon set-switching behaviour you describe is definitely a bug. (In reply to comment #2) > If those small icons are so ugly as to prompt a bug report (as they apparently > are!), we definitely need to so something about that. :-) The original bigger icons scale down nicely to 16x16 format so I don't see a reason for another set. (In reply to comment #3) > (In reply to comment #2) > > If those small icons are so ugly as to prompt a bug report (as they apparently > > are!), we definitely need to so something about that. :-) > The original bigger icons scale down nicely to 16x16 format so I don't see a > reason for another set. At first glance I tend to agree; let me run a few tests here just to ensure that the smaller icons can be safely removed. (In reply to comment #4) > At first glance I tend to agree; let me run a few tests here just to ensure > that the smaller icons can be safely removed. I think a safe way of doing this would be to scale down bigger icons to 16x16 and replace the "ugly" ones. This would however hide the icon switching bug, without really fixing it. (In reply to comment #5) > (In reply to comment #4) > > At first glance I tend to agree; let me run a few tests here just to ensure > > that the smaller icons can be safely removed. > I think a safe way of doing this would be to scale down bigger icons to 16x16 > and replace the "ugly" ones. This would however hide the icon switching bug, > without really fixing it. It looks like the icon switching bug is actually a problem with loading the correct icon on startup or icon size change. Subsequent device change events force kpowersave to load the correct icon set. (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > At first glance I tend to agree; let me run a few tests here just to ensure > > > that the smaller icons can be safely removed. > > I think a safe way of doing this would be to scale down bigger icons to 16x16 > > and replace the "ugly" ones. This would however hide the icon switching bug, > > without really fixing it. > > It looks like the icon switching bug is actually a problem with loading the > correct icon on startup or icon size change. Subsequent device change events > force kpowersave to load the correct icon set. The icon set switching issue has been resolved in GIT hashes 301ec19 and ea31ec6. I am now regenerating icons for the 16x16 size. High quality 16x16 icons now in GIT as of hashes b45e2d5 and 7b16418. Thanks for reporting! (In reply to comment #8) > High quality 16x16 icons now in GIT as of hashes b45e2d5 and 7b16418. > > Thanks for reporting! Thanks for fixing :) BTW. Where are these icons located in the filesystem? I figured I could replace the ones I don't like with the prettier ones, but I can't find them n the disk. I thought the will be somewhere in /opt/trinity/share/icons/kdeclassic/SOME_SIZE/actions but I don't see them. |
Created attachment 842 [details] A broken icon When tray icon size is set to 16x16, the KPowersave icons break after firs change. Example: - login with power plug connected. The icon is OK - disconnect the cable. Icon changes to show battery, but instead of using normal battery icon (the one that is used when icons are larger), a very ugly icon is used. - reconnect the cable. Again, a very primitive and ugly icon is used (see attachment). If I log in with power cable disconnected then battery icon is displayed correct. Icon becomes broken after connecting power cable.