By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1263

Summary: Amarok: db-setup links in first run wizard need fixed
Product: TDE Reporter: Kris <krisgamrat>
Component: tdemultimediaAssignee: Timothy Pearson <kb9vqf>
Status: NEW ---    
Severity: minor CC: bugwatch, darrella, michele.calgaro
Priority: P5    
Version: R14.0.x [Trinity]   
Hardware: All   
OS: Linux   
Compiler Version: TDE Version String:
Application Version: Application Name:
Attachments: Page showing incorrect links are definitely in existence
Quick fix for the URLs

Description Kris 2012-10-12 12:23:55 CDT
In the Amarok first-run wizard, the links pointing to the setup instructions for MySQL and Postgres still point to kde.org. Both these articles should either be moved to the TDE wiki, or (preferable) into the Amarok Handbook so the Internet isn't required to read these.
Comment 1 Darrell 2012-10-13 00:31:36 CDT
Is this R14? Please provide a screen shot. I don't see any such references or links. :(
Comment 2 Kris 2012-10-13 08:59:38 CDT
Created attachment 880 [details]
Page showing incorrect links are definitely in existence

(In reply to comment #1)
> Is this R14? Please provide a screen shot. I don't see any such references or
> links. :(

The links are there. They always have been.

Page three of the first-run wizard. Unless whoever maintains the packages for your distro patched Amarok with a preconfigured setup (not a good idea for testing development version of TDE), there will be two links:

Instructions for configuring MySQL.
Instructions for configuring Postgresql.

Both of them, when clicked, go to a page on kde.org, which is obviously the wrong site to go to for TDE.
Comment 3 Darrell 2012-10-13 13:30:34 CDT
Thanks for the image. What version of Trinity are you running?
Comment 4 Darrell 2012-10-13 13:58:28 CDT
I believe there are a couple of problems here.

I found the Amarok 1.4 web pages. Migrating the 1.4 web pages to the wiki or to the Amarok help handbook can be done. Fixing the links thereafter is straightforward.

By the way, in the Settings dialog, the link to the moodbar web page needs to be deleted. I can't find an Amarok 1.4 web page anywhere online to migrate.

The reason you see that dialog and I don't is Amarok has to be built with MySQL and Postgres support for that first-run wizard dialog to appear. My guess is your Amarok package was built with autotools rather than cmake. Building Amarok with that support was lost with the cmake conversion --- refer to bug report 818.
Comment 5 Darrell 2012-10-13 15:01:41 CDT
Created attachment 881 [details]
Quick fix for the URLs

This patch includes a quick fix to update the database URLs in the first-time wizard. The patch changes the links to the correct Amarok 1.4 web pages.

As the web pages are hosted at the KDE web site, there is no guarantee those pages will be retained by the web site maintainers. The web pages should be migrated to the Trinity wiki and the links updated to that new location.

The patch includes two additional nominal changes: 1) deleting the moodbar link in the Settings dialog (I can't find an Amarok 1.4 web page) and 2) updating a contact email address.
Comment 6 Kris 2012-10-13 18:33:53 CDT
(In reply to comment #3)
> Thanks for the image. What version of Trinity are you running?

R14.

(In reply to omment #4)
<snip>
> The reason you see that dialog and I don't is Amarok has to be built with MySQL
and Postgres support for that first-run wizard dialog to appear. My guess is
your Amarok package was built with autotools rather than cmake. Building Amarok
with that support was lost with the cmake conversion --- refer to bug report
818.

Then the build server that does the official nightlies for Debian needs to be adjusted. That is where I got this version of Amarok from.

I've actually seen builds (from the KDE 3.5 days) with no MySQL and Postgres support, and the first run wizard still appeared (just skipped that page). I think those builds were patched, though (I think to automatically assume SQLite).

P.S. Since you posted a patch, I'm changing status to PATCHAVAIL.
Comment 7 Darrell 2012-10-13 21:04:50 CDT
I believe this is the build script for the nightlies:

http://git.trinitydesktop.org/cgit/tde-packaging/tree/ubuntu/maverick/applications/amarok/debian/rules

The build script is using autotools rather than cmake. Nothing wrong with that, only that the cmake conversion remains incomplete, as addressed in bug report 818.

In that build script both MySQL and PostgreSQL are enabled.

In addition to R14, I have a 3.5.10 and a 3.5.13 virtual machine for testing. In all three the first-time wizard runs with any new profile or just by deleting the amarok config files. In all three systems, amarok was built without MySQL and PostgreSQL support. That is why I don't see the dialog in the wizard. The wizard skips that particular dialog when built without that support, which makes sense.

There is another build option to use an internal sqlite (--without-included-sqlite). When that build option is used then amarok is built using an external system sqlite engine. That build option is one of those not yet supported in the cmake conversion. The default is to use the internal engine, making amarok more portable.

Yes, I forgot to tag the bug report as PATCHAVAIL. Thanks. :)
Comment 8 Darrell 2012-10-16 15:52:06 CDT
The patch seems to work fine for me. The updated links now refer to the Amarok 1.4 web pages at the KDE web site. Yet we really should move that information to the Trinity web site or wiki.
Comment 9 Kris 2012-10-16 20:31:51 CDT
(In reply to comment #8)
> The patch seems to work fine for me. The updated links now refer to the Amarok
> 1.4 web pages at the KDE web site. Yet we really should move that information
> to the Trinity web site or wiki.

Eventually, preferrably, it should be moved to the docbooks in the TDE Help System. The less people need to go to their browsers to get documentation, the better, especially for those of us with unreliable connections.
Comment 10 Darrell 2013-03-02 23:31:30 CST
Patch in attachment 881 [details] pushed to GIT in commit 975f3a15.

The patch is a temporary fix. The web page contents should be merged to a docbook file to preserve the information.
Comment 11 Michele Calgaro 2014-04-12 08:28:53 CDT
Changing status back to NEW for too long inactivity