| Summary: | k9copy: Crashes when opening a video file in DVD Author mode | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | non-core programs | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | albator78, bugwatch, darrella, kb9vqf, slavek.banko |
| Priority: | P1 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 2014 | ||
| Attachments: | k9copy : fix 1st crash | ||
|
Description
Darrell
2012-10-16 21:36:47 CDT
Created attachment 1438 [details]
k9copy : fix 1st crash
It looks like this particular crash is caused by uninitialized pointers in k9copy's code.
The attached patch fixes this crash, but now, it crashes just after, when "adding" the video.
I think there are more places to look for uninitialized pointers ...
It looks like the crash I've get is due to deprecation of some functions in ffmpeg. The "img_convert" function does not exist anymore in ffmpeg 1.0. Even the last official k9copy has the problem (discontinued in 2011, last version is Z.3.8), but some distributions still ship patched versions to support newer ffmpeg. I don't know if it's realistic to maintain our old 1.2.3 version ... . k9copy is pretty fragile, but I think I repaired the major crashes in GIT ending with hash 0e82473. Can you test and confirm? I don't want to drop it yet as it might be perfectly feasible to keep it going and fix some of the remaining crashes. >k9copy is pretty fragile,
And unmaintained, even in the Qt4 branch.
I no longer see a crash as described in the original report. I'll let Francois tickle some more to his satisfaction.
The crashing regression is repaired as far as I can tell; this should not block R14. Francois, if you can verify that k9copy is no longer crashing in author mode when interacting with the video files please close this report. Thanks! The crash described in initial post does not occur anymore. Closing the bug Commit 0e824732 causes FTBFS on all Debian / Ubuntu distributions: /tmp/buildd/k9copy-trinity-14.0.0-s~157/./k9author/k9avidecode.cpp:126: error: 'av_free_packet_internal' was not declared in this scope (In reply to Slávek Banko from comment #7) > Commit 0e824732 causes FTBFS on all Debian / Ubuntu distributions: > > /tmp/buildd/k9copy-trinity-14.0.0-s~157/./k9author/k9avidecode.cpp:126: > error: 'av_free_packet_internal' was not declared in this scope Fixed in GIT hash 2897194b and 24e31dab. |