| Summary: | Build issue: tdenetwork cmake conversion lacks support for OpenSLP or XMMS | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | tdenetwork | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugwatch, darrella, slavek.banko |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: |
Added OpenSLP support to CMake
Added XMMS supoort to CMake |
||
|
Description
Darrell
2012-10-18 19:06:40 CDT
I don't see anything in the cmake files indicating support for XMMS (nowlistening plugin). The nowlistening plugin builds as far as I can tell, but I don't know whether XMMS support is added. In automake, there was a direct configure option, --with-xmms. I installed the OpenSLP package and built tdenetwork with autotools. There were no build failures, but I don't know how to validate OpenSLP support was built. What usability tests would suffice? There are no references in the cmake build log or cmake cache file about XMMS, although there are a few lines about building nlxmms.cpp. So don't know one way or another whether XMMS support is being built. I'm not sure if xmms support is still applicable? I think that was for xmms 1.x and with xmms 2.x does not work. I don't know. I have xmms-1.2.11 installed. Even if no longer compatible with xmms 2.x, I think we should keep the configure option functional for xmms 1.2.x. I don't know how to test whether the support builds correctly. Ok, I understand. Currently can be xmms support builded only by automake build - with using --with-xmms. I'll try into the upcoming 'cmake' patch also add support for xmms and OpenSLP. Stay tuned :) Anyway, today I tried to build with jingle support, but so far build failed. I'm changing the bug report summary to include XMMS. I too am unable to build jingle support. Created attachment 936 [details]
Added OpenSLP support to CMake
Added WITH_SLP option, checking for library presence and linking.
Please try it - this time cmake build :)
I tested the cmake OpenSLP patch and -DWITH_SLP=ON. The package builds, but I don't know what usability test proves the hooks built correctly. I presume when building with automake that the OpenSLP support builds already, but again, what is a good usability test? In krdc is Browse button, which would (hopefully) can be used to scan using SLP services on the network. For me (build with autotools) but still nothing is there. So I'm not sure how to verify functionality. Created attachment 937 [details]
Added XMMS supoort to CMake
I tried to prepare a patch, but I have no idea if it will work.
Testing is yours.
Comment on attachment 936 [details]
Added OpenSLP support to CMake
Pushed to GIT in hash 354555a2
Comment on attachment 937 [details]
Added XMMS supoort to CMake
I made one typographical change to the XMMS patch (missing parentheses). The patch builds without incident. We'll have to look later how to test usability. I am pushed the patch in commit 10026753.
As this bug report addressed cmake build issues (and not usability), I'm closing the bug report as resolved. The libjingle build issues mentioned in the comments should be addressed through bug report 1097. Thanks everybody! Darrell, you forgot in commit 10026753 to add new file kopete/plugins/nowlistening/ConfigureChecks.cmake Oops. Done! |