| Summary: | Add mouse double-click test area in KControl->Peripherals->Mouse->Advanced | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | tdebase | Assignee: | Michele Calgaro <michele.calgaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | bugwatch, darrella, michele.calgaro, slavek.banko |
| Priority: | P1 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Other | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: |
First image for double-click test
Second image for double-click test First image for double-click test with correct file name Second image for double-click test with correct file name Patch to add new images to tdelibs Preliminary patch to add double-click test area Updated preliminary patch to add double-click test area Screen shot of first image in kcontrol module Screen shot of second image in kcontrol module patch for tdebase module patch for tde-packaging (debian/ubuntu distribution) |
||
|
Description
Darrell
2012-11-15 14:57:40 CST
Created attachment 984 [details]
First image for double-click test
This is the first (default) image to use in the double-click test.
Created attachment 985 [details]
Second image for double-click test
This is the second (toggle) image to use in the double-click test.
To whomever hacks code for this request: Please remember the code is not a simple double-click test but is to test the double-click time interval the user selects. The images toggle only when the double-click event is less than or equal to the user's selected interval. A double-click interval greater than user's setting does not toggle the images. Created attachment 990 [details]
First image for double-click test with correct file name
This is the same image as originally posted but with a correct file name.
The new file name is cr32-action-doubleclick-1.png and should be added in GIT to tdelibs/pics/crystalsvg/.
When building tdelibs, the file will be installed as $TDEDIR/share/icons/crystalsvg/32x32/actions/doubleclick-1.png.
Created attachment 991 [details]
Second image for double-click test with correct file name
This is the same image as originally posted but with a correct file name.
The new file name is cr32-action-doubleclick-2.png and should be added in GIT to tdelibs/pics/crystalsvg/.
When building tdelibs, the file will be installed as $TDEDIR/share/icons/crystalsvg/32x32/actions/doubleclick-2.png.
Created attachment 992 [details]
Patch to add new images to tdelibs
Two images are needed to resolve this enhancement request. The images are attached to this report.
The patch adds the two new images in GIT to tdelibs/pics/crystalsvg/.
When building tdelibs, the two mage files will be installed to $TDEDIR/share/icons/crystalsvg/32x32/actions/doubleclick-1(2).png. Subsequent code changs in tdebase/kcontrol will need to reference those file names as:
doubleclick-1.png
doubleclick-2.png
Created attachment 995 [details] Preliminary patch to add double-click test area I have a partial patch completed. I'm still trying to learn more about this but at this point I have the What's This help, the TQLabel, spacing, and the first image in place. I need coaching how to measure the time between clicks, but I'm tickled I even got this far. :) The previous tdelibs patch (attachment 992 [details]) is unnecessary. The new tdebase patch installs the two images in $(kde_datadir)/kcminput/pics. Created attachment 996 [details]
Updated preliminary patch to add double-click test area
This patch is the best I can do. I tried many times to copy similar eventFilter code, but I'm over my head trying to understand what is involved. Hopefully I learn something when the patch is completed.
Code is still needed to detect a double-click event, which in turn changes the image when the test time is <= to the user's configured double-click interval.
The latest patch includes both images, builds without failure, and looks great in KControl. Get the double-click event finished and we have a nice new feature.
Created attachment 999 [details]
Screen shot of first image in kcontrol module
Created attachment 1000 [details]
Screen shot of second image in kcontrol module
Patch in attachment 996 [details] pushed to GIT in commit 48e7fc5a.
The patch does not fully resolve the bug report. Work is needed to toggle the icon image after testing the double-click.
I will work on this bug, but won't be until at least middle of next week due to other commitments Created attachment 1649 [details]
patch for tdebase module
Created attachment 1650 [details]
patch for tde-packaging (debian/ubuntu distribution)
Attached above the proposed patches for this bug report. 1) attachment 1649 [details] adds the missing logic to test the mouse double click in KControl -> Peripherals -> Mouse -> Advanced tab This patch is for tdebase 2) attachment 1650 [details] is only required for Debian/Ubuntu distributions and makes sure the two images needed are installed in the correct place. This patch is for the tde-packaging repository and addresses all Debian/Ubuntu tdebase/debian/tdebase-data-trinity.install files (avoiding link repetition) Ooh, yeah, it works :) Good job. I am adding patches into my queue to commit... >I am adding patches into my queue to commit...
Please push. Works great for me!
Thank you!
Pushed to GIT in hash c4083c1d (tdebase) and hash 3393e97a (tde-packaging). |