| Summary: | Build Issue: tdenetwork, multiple cmake issues. | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Alexander Golubev (Fat-Zer) <fatzer2> |
| Component: | tdenetwork | Assignee: | Slávek Banko <slavek.banko> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | bugwatch, darrella, slavek.banko |
| Priority: | P1 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | All | ||
| OS: | All | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 1300 | ||
| Attachments: |
Issue#1 fix
Issue#2 build.log Issue#2 fix Issue#2 fix with automake Issue#2 fix with automake (2) |
||
|
Description
Alexander Golubev (Fat-Zer)
2012-11-19 23:35:33 CST
Created attachment 1003 [details]
Issue#1 fix
This missing export blocks at least separate compilation of dcoprss.
Created attachment 1004 [details]
Issue#2 build.log
here is a parallel compilation Issue. filesharing fails to compile in parallel. no fix yet.
error message is:
/var/tmp/portage/trinity-base/tdenetwork-filesharing-9999/work/tdenetwork-filesharing-9999/filesharing/advanced/propsdlgplugin/../kcm_sambaconf/sharedlgimpl.h:39:19: fatal error: share.h: No such file or directory
Created attachment 1005 [details] Issue#2 fix here is a patch to fix the issue. See the cmake FAQ about that all this stuff for: http://www.cmake.org/Wiki/CMake_FAQ Especially chapters 4.6, 4.7, 4.8. can somebody test it with autotools as well? I've also changed some includes... > fatal error: share.h: No such file or directory I have see this error but not in a repeatable manner. The tdenetwork package always built on a second attempt. I will add the patch and test but looks to me if Tim or Slavek review then we should just push right away. Please notice there are several open bug reports affecting tdenetwork: http://bugs.pearsoncomputing.net/buglist.cgi?quicksearch=tdenetwork Two of those reports contain patches. I tried building with both automake and cmake. If have to be adjusted paths in propertiespage.cpp, it is necessary to modify also automake build, otherwise it leads to FTBFS. Created attachment 1008 [details] Issue#2 fix with automake (In reply to comment #5) > I tried building with both automake and cmake. If have to be adjusted paths in > propertiespage.cpp, it is necessary to modify also automake build, otherwise it > leads to FTBFS. here is a patch but I'm not familiar with automake and I even can't test if it works. (In reply to comment #4) > > fatal error: share.h: No such file or directory > > I have see this error but not in a repeatable manner. The tdenetwork package > always built on a second attempt. I will add the patch and test but looks to me I've achieved repeatability with cmake -DBUILD_FILESHARING=ON && make -j14 or -j8 some times. Eventually I've built with -j2 through -j32 with step 6 for test. All worked well. I tested both patches building with cmake. I haven't yet tried automake. No build issues. Of course, I only saw the share.h failure intermittently os the only test for me is to keep watch over the weeks. We still need somebody else to approve before I can push. Created attachment 1009 [details]
Issue#2 fix with automake (2)
I modified automake part of the patch.
Now I can build successfully with both automake and also cmake.
If there are no objections, I'll push both patches into the GIT.
I tested the latest Issue#2 fix with automake and had no problems. I say push both to GIT. We probably should get the patches in bug report 1040 tested and pushed too. Then we could close that report as well as this one. Pushed to GIT in hash 14f7445d and 6ab3b4d3. And also into v3.5.13-sru branch. |