By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1408

Summary:	Konqueror icon view flickering
Product:	TDE	Reporter:	Jan Janeček <janjanjanx>
Component:	qt3	Assignee:	Slávek Banko <slavek.banko>
Status:	RESOLVED FIXED
Severity:	blocker	CC:	bugwatch, janjanjanx, kb9vqf, slavek.banko
Priority:	P5
Version:	R14.0.0 [Trinity]
Hardware:	amd64
OS:	Debian Wheezy
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Attachments:	The mentioned patch. Fix footpring while dragging icons Fix footpring while dragging icons (2)

Description Jan Janeček 2013-02-18 11:58:09 CST

Konqueror is redrawing/refreshing the icon view when browsing directories (mostly when browsing those that were already visited).
The redrawing/flickering also occurs when a tooltip disappears.

It looks like this bug is years old. It has been reported in 2004: https://bugs.kde.org/show_bug.cgi?id=93884
https://bugs.kde.org/show_bug.cgi?id=67790

I've found out, that someone made (in 2004) a couple of patches for this issue:
http://robotics.dei.unipd.it/~koral/KDE/kflicker.html
All of them have been merged into KDE or Qt, except the first one. The patch uses backbuffer for iconview.
I patched my Qt with it and the result is amazing: absolutely no flickering.

Is there any reason the patch was never merged into Qt?
If there's no problem, may I suggest merging this patch?

The patch is in attachment.

Comment 1 Jan Janeček 2013-02-18 12:01:02 CST

Created attachment 1109 [details]
The mentioned patch.

Comment 2 Timothy Pearson 2013-02-18 13:13:02 CST

I can't think of any reason not to include this patch off the top of my head.  I will push it to GIT after making the appropriate patch to TQt3 and verifying proper compilation.

Tim

Comment 3 Timothy Pearson 2013-02-18 20:38:46 CST

Pushed to GIT in hashes 82b71e4 (Qt3) and cff522f (TQt3).

Thanks for reporting, and for the patch!

Comment 4 Slávek Banko 2013-02-28 10:36:59 CST

When moving the icons in Konqeuror it remains visible footprint of the selection frame.

Comment 5 Timothy Pearson 2013-02-28 11:50:32 CST

(In reply to comment #4)
> When moving the icons in Konqeuror it remains visible footprint of the
> selection frame.

Now I remember why that patch was never merged!  I ran into this on Ubuntu years ago and traced the problem into an Ubuntu specific patch that must be the same one attached to this report.

Can you see any easy way to fix this issue, or do I need to revert the patch?

Thanks!

Comment 6 Slávek Banko 2013-02-28 22:06:43 CST

Created attachment 1114 [details]
Fix footpring while dragging icons

I tried to prepare a patch that changes bufferedPaintEvent use only if it does not during dragging. Please test if it solved both - flickering and also footprint while dragging icons.

Comment 7 Slávek Banko 2013-03-01 06:17:45 CST

Created attachment 1116 [details]
Fix footpring while dragging icons (2)

Sense of patch remains the same - bufferedPaintEvent will be used only if it does not during dragging. Just a little cleaned a series of identical conditions.

Comment 8 Jan Janeček 2013-03-01 14:25:52 CST

I tested Slávek's patch and it looks like it works - there are no "footprints" left anymore when dragging icons.

Thanks for solving this.

Comment 9 Timothy Pearson 2013-03-01 23:20:32 CST

(In reply to comment #7)
> Created attachment 1116 [details]
> Fix footpring while dragging icons (2)
> 
> Sense of patch remains the same - bufferedPaintEvent will be used only if it
> does not during dragging. Just a little cleaned a series of identical
> conditions.

As Jan has confirmed a fix, this has been committed to GIT in hashes d10d232 and cb6a50a (Qt3 and TQt3, respectively).

Thanks for reporting, and to Slavek for the patch!