| Summary: | Provide better vertical layout support to Lock/Logout kicker applet | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | tdebase | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | NEW --- | ||
| Severity: | enhancement | CC: | bugwatch, darrella |
| Priority: | P5 | ||
| Version: | R14.0.x [Trinity] | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
|
Description
Darrell
2013-04-06 20:02:57 CDT
I noticed when I increase the height of the panel to 43 pixels the lock/logout buttons automatically rotate to vertical. At any smaller panel height they remain horizontal. I looked at the source code and there is a comment about the buttons having a size of 44 pixels and then substracting 2 pixels for spacing. That would be 42 pixels, which would explain why the buttons rotate at 43. I don't know how this all plays out, but in KDE4 the buttons are vertical and I don't need to stretch the panel height to such a large size. I wonder whether the button icons in KDE4 are smaller or svg. I updated the report summary to not focus on adding a config option. Perhaps the solution is optimizing the code to better support vertical layout. Note for future reference: The sources are located in tdebase/kicker/applets/lockout/lockout.cpp. Seems the spacing used between the two button (16x16) icons is rather large (8 pixels?). Perhaps we could reduce that to 2 or 4 pixels (seems the spacing between the two is tighter in KDE4). My hope is to use the vertical layout for the buttons yet have as narrow a panel as possible. :) I would like to expand the scope of this request. In KDE4 the applet/widget has a configuration dialog that allows showing both or either of the buttons. A note: if the spacing is reduced to 1 pixel above, below, and between the two icons, the minimum panel height that could be used with vertical icons would be 35 pixels (1+16+1+16+1). At 2 pixels spacing the minimum height would be 38 pixels. Both are lower than the current 43 pixels minimum. |