By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1444

Summary:	[Regression] Digikam and kipi-plugins persistent image rotation is broken
Product:	TDE	Reporter:	Darrell <darrella>
Component:	non-core programs	Assignee:	Slávek Banko <slavek.banko>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugwatch, darrella, slavek.banko
Priority:	P5
Version:	R14.0.0 [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Attachments:	Fix rotated jpeg image save Fix rotated jpeg image save (2) kipi-plugins: Fix rotated jpeg image save

Description Darrell 2013-04-09 22:17:23 CDT

Same problem affects digikam as found in bug report 1436 for gwenview.

Comment 1 Slávek Banko 2013-04-10 21:48:00 CDT

Created attachment 1151 [details]
Fix rotated jpeg image save

I've tried to "duplicate" patch from gwenview to digikam.
Please, try it.

Note: There is still a same code in kipi-plugins.

Comment 2 Darrell 2013-04-10 22:45:11 CDT

I'll test this. I'm updating the bug report summary to include kipi-plugins.

Comment 3 Darrell 2013-04-11 14:35:29 CDT

I tested the proposed digikam patch and received a failure error in the digikam dialog. Rotating a PNG worked without error with the dialog confirming.

Comment 4 Slávek Banko 2013-04-14 22:31:17 CDT

Created attachment 1163 [details]
Fix rotated jpeg image save (2)

I added version duality also for jpegint.h - for jpeg 8 version I was added a small hack due to the definition of INT32.

Please try it. And can anyone assess this little hack for INT32?

Comment 5 Darrell 2013-04-15 12:09:01 CDT

I'll test the updated patch in the next day or so.

Comment 6 Slávek Banko 2013-04-15 20:38:02 CDT

Created attachment 1167 [details]
kipi-plugins: Fix rotated jpeg image save

Analogous patch for kipi-plugins.
Based on attachment 1163 [details].
Please, try it.

Comment 7 Darrell 2013-04-15 23:43:07 CDT

Both patches failed to build with the same error:

In file included from /usr/include/jpeglib.h:1148:0,
                 from transupp.cpp:11:
./jpegint.h:405:14: error: 'Q_INT32' does not name a type
transupp.cpp:1551:1: warning: unused parameter 'option' [-Wunused-parameter]
make[4]: *** [transupp.lo] Error 1

Comment 8 Darrell 2013-04-16 00:34:50 CDT

In both patches, changing the following allowed both to compile without failure:

AS IS:

+#define INT32  Q_INT32

CHANGED TO:

+#define INT32  TQ_INT32

Rotation also works with both patches (and the above changes).

Comment 9 Slávek Banko 2013-04-16 11:10:27 CDT

Yes, of course, as I tried patch on v3.5.13-sru branch, so I used Q_INT32 and after then I realized that it should be TQ_INT32.

No objection to this a small hack for adding a definition INT32?
So I'll proceed further to commit patches.

Comment 10 Slávek Banko 2013-04-16 12:52:33 CDT

Digikam patch pushed to GIT in hash 9dd05e7a.
Kipi-plugins patch pushed to GIT in hash 209cc81e.
Both also cherry-picked into v3.5.13-sru branch.