By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1466

Summary:	Build issue: tdesdk: .git files are pulled into the final package
Product:	TDE	Reporter:	Darrell <darrella>
Component:	tdesdk	Assignee:	Slávek Banko <slavek.banko>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugwatch, darrella, slavek.banko
Priority:	P5
Version:	R14.0.0 [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Attachments:	kapptemplate: fix installation of unwanted git files kapptemplate: fix installation of unwanted git files (2) kapptemplate: fix installation of unwanted git files (3)

Description Darrell 2013-04-20 12:58:47 CDT

The tdesdk package, kapptemplate, contains a bunch of admin/.git files that get installed to $PREFIX/share/apps/kapptemplate/admin/.git/.

Currently I have to use my build script to strip those files.

Why is the build pulling these admin/.git files into the package? My guess is somehow, like the replication of all admin and cmake directories in each module, those directories are being replicated in tdesdk/kapptemplate. I understand that to a point, but the .git files should not be replicated.

Comment 1 Slávek Banko 2013-04-20 13:11:25 CDT

If you use create_tarball script from tde/scripts, .git nor .gitmodules not included in the source tarball.

Comment 2 Darrell 2013-04-20 13:20:03 CDT

Yes, I realize that, but that is an extra step when building from GIT and a tad time consuming too. There should be no reason not to build by directly grabbing the GIT sources. tdesdk is the only module affected, so let's provide a remedy. :)

Comment 3 Slávek Banko 2013-04-20 13:38:46 CDT

Created attachment 1170 [details]
kapptemplate: fix installation of unwanted git files

Yes, you're right, of course :)
Please try the attached patch.

Comment 4 Slávek Banko 2013-04-20 13:41:49 CDT

Created attachment 1171 [details]
kapptemplate: fix installation of unwanted git files (2)

Quick fix: doubling slash before the dot.

Comment 5 Darrell 2013-04-20 14:50:16 CDT

I tested with and without the patch. The patch works. Good job! :)

Comment 6 Darrell 2013-04-20 17:33:46 CDT

Slavek, if you tested the patch at your end, then we can push to GIT. :)

Comment 7 Slávek Banko 2013-04-20 18:04:04 CDT

Created attachment 1173 [details]
kapptemplate: fix installation of unwanted git files (3)

One more update: Tightening of expression, to not exclude possible files ending with ".git", but only full names. Please test it.

Comment 8 Darrell 2013-04-20 19:19:30 CDT

Same happy results: no git files in the package. Push to GIT. :)

Comment 9 Slávek Banko 2013-04-20 19:28:55 CDT

Fixed in GIT hash e27dd07d