|
Description
Francois Andriot
2013-05-06 15:56:22 CDT
Created attachment 1219 [details]
tdebase 3.5.13.2 : fix halbackend does not manage to invoke 'fuser' command
This patch solves the issue that prevents halbackend to umount busy directories with the "fuser" command.
You can see directly in command line:
$ /usr/bin/env fuser -vm /bin/bash
/usr/bin/env: fuser: Aucun fichier ou dossier de ce type
$ /usr/bin/env /sbin/fuser -vm /bin/bash
UTIL. PID ACCÈS COMMANDE
/bin/bash: root kernel mount /
root kernel knfsd /exports
albator 27090 .r.e. bash
albator 29029 .rc.m gpg-agent
albator 29092 .r.e. bash
albator 29561 .r.e. bash
Created attachment 1220 [details]
tdebase 3.5.13.2 : make unlock dialog box vibrate when bad password is given
This patch adds a little animation to the kdesktop_lock password prompt popup window.
If you enter a wrong password and validate, the window vibrates horizontally, as if it said "no no no" :-)
Created attachment 1228 [details]
tdebase 3.5.13.2 : add missing icon for "lock current & start new session" in kicker
In kicker classic menu, there is no icon under "Switch User / Lock Current & Start New Session".
This patch reenables the icon.
Created attachment 1229 [details]
tdebase 3.5.13.2 : add tooltip support in KMenu
This patch adds tooltips in kicker classic menu.
When you move the mouse on an application icon, a tooltip appears and display the application description.
Created attachment 1230 [details]
tdebase 3.5.13.2 : use hal to detect media types in halbackend (pardus)
The patch was originally written for Pardus Linux.
It changes the halbackend way of detecting optical media type (VCD, SVCD, DVD).
Instead of doing the job itself, it queries the HAL daemon directly.
I have no idea if it requires a patched HAL daemon or if it works currently.
Created attachment 1231 [details]
tdebase 3.5.13.2 : fix media name translations (pardus)
This patch was originally written for Pardus Linux.
It allows halbackend to correctly transle media name types, e.g "501M Removable media device".
Created attachment 1232 [details]
tdebase 3.5.13.2 : fix halbackend mount point if media name contains UTF8 caracters (pardus)
Created attachment 1233 [details]
tdebase 3.5.13.2 : fix "safely remove device" command (pardus)
According to the help:
kio_media_mounthelper
Options:
-d Decrypt given URL
-u Unmount given URL
-m Mount given URL (default)
-e Eject given URL via kdeeject
-s Unmount and Eject given URL (necessary for some USB devices)
I do not know the exactly if it's better to use -s or -u ...
Created attachment 1234 [details]
tdebase 3.5.13.2 : renames Control Center icon
In some distributions (at least Mageia/Mandriva), there is an application called "Control Center". In Trinity, there is too a "Control Center". This can be confusing for the end-user which does not know which application he should run.
The attached patch simply renames our control center to "Trinity Control Center".
Created attachment 1236 [details]
tdebase 3.5.13.2 : add kpowersave shortcut in kcontrol "energy" feature
This patch changes the "energy" configuration panel of kcontrol.
Run with:
kcmshell energy
If kpowersave is started, the kcontrol settings are hidden and a button is added to run kpowersave.
If kpowersave is NOT started, kcontrol displays the usual settings.
Created attachment 1237 [details]
tdebase 3.5.13.2 : add crossfade effect when changing wallpaper
This patch is very cool: when changing wallpaper (manually or via a configured slide-show), it adds a smooth crossfade effect to switch between the old wallpaper and the new one.
Created attachment 1238 [details]
tdebase 3.5.13.2 : add option to choose WM
Another cool patch from Mandriva :-)
Under Control Center / KDE Components / Session Manager , it adds a combo box to choose the window manager that TDE must use. Current choices are kwin, kwin4, metacity and compiz.
Created attachment 1239 [details]
tdelibs 3.5.13.2 : add support for supplementary XDG directories
This patch adds support for XDG directories: music, pictures, videos, download.
Created attachment 1240 [details]
tdebase 3.5.13.2 : add XDG directories in Kickoff menu
This patch adds the Music, Pictures, Videos and Download folders under Computer tab of kickoff menu.
This patch requires the previous tdelibs patch.
Created attachment 1241 [details]
tdebase 3.5.13.2 : add ability to unmount hotplug devices before suspend
This patch allows kpowersave to unmount all hotplug devices (e.g usb keys) before suspending, then remounting them on wakeup.
It is useful if you decide to unplug your USB key while the computer is suspended.
Created attachment 1242 [details]
tdebase 3.5.13.2 : copy global bookmarks if user has no personal bookmarks
This patch copies the global "bookmarks.xml" file in user profile, in case he does not have a personal "bookmarks.xml" file.
This allow to give default bookmarks to the user upon first konqueror startup.
Created attachment 1243 [details]
tdelibs 3.5.13.2 : fix detect default printing system
Created attachment 1244 [details]
tdemultimedia 3.5.13.2 : start kmix hidden by default
Created attachment 1245 [details]
tdemultimedia 3.5.13.2 : use digital reading in KSCD by default
Created attachment 1246 [details]
tdebase 3.5.13.2 : add crossfade effect when changing wallpaper (2)
Updated patch with bug fix.
Created attachment 1247 [details]
tdebase 3.5.13.2 : add theme selector in kcontrol / kdm
Another very cool patch (modified from Mandriva-specific themes to TDE themes ...) that adds a configuration item in kcontrol, that allows to choose a KDM theme.
Created attachment 1250 [details]
tdebase 3.5.13.2 : add scheduled slide show support
This patch requires the "crossfade" patch above.
It adds support for "scheduled slide show" in wallpaper section. Basically, a scheduled slide show is an XML file which contains a list of pictures to display, and the duration each one must be displayed.
It was (still is ?) used in Mandriva distribution to show wallpapers changing during the day (e.g. you see different pictures of the same landscape with sun enlightnement changing depending on the hour of the day. you even see the landscape by night during the night).
It seems it does not work currently in TDE (I only get a black wallpaper), maybe I don't have a correct XML file now.
(there is an harcoded mandriva path too)
Created attachment 1251 [details]
tdebase 3.5.13.2 : add UTF8 support in KDM password dialog box (pardus)
This patch was originally developed for Pardus Linux.
It is unclear to me exactly what it does.
Comment on attachment 1244 [details]
tdemultimedia 3.5.13.2 : start kmix hidden by default
It is good that kmix in the new profile starts automatically, but is wrong, it is not hidden by default. This patch fix it.
Pushed to GIT in hash 617bd268 and also into v3.5.13-sru branch.
Comment on attachment 1245 [details]
tdemultimedia 3.5.13.2 : use digital reading in KSCD by default
Many new machines does not have analog connections from cdrom into the motherboard - digital playback is essential.
Pushed to GIT in hash 920e2cf5 and also into v3.5.13-sru branch.
Francois, interesting set of patches! One comment about the patch to add tooltips to the classic menu, there needs to be a way to disable the tooltips. Many people do not like tooltips (a common complaint about KDE4). :-) Just chattering out loud, many of these patches involve HAL, which no longer is supported except in older distros. Testing those patches will be a challenge for many of us because HAL is not installed and tdelibs/tdebase will have been compiled using TDEHWLIBS. Darrell, most (all?) the HAL-related stuff are Pardus patches. I will provide HAL as dependencies for all TDE 3.5.13.2 builds, even on recent distributions (I build and package HAL myself). Most Pardus patches aim to better support internationalization (there are still patches that I did not convert that enhance Turkish support). They can be used as inspiration for the new R14: we must ensure that every bug that was fixed by Pardus in HAL must also work in R14 without HAL. BTW I'm currently using all these patches in 3.5.13.2 and I see no regression on my current usage (I'm not using weird UTF8 encoded caracters in devices name nor passwords so I cannot really say if they fix the original issue or not). Created attachment 1255 [details]
tdebase 3.5.13.2 : add tooltip support in KMenu (2)
Tooltip support for Kmenu again, this time with a kcontrol option to enable/disable. (default is disabled).
Created attachment 1262 [details]
tdebase 3.5.13.2 : fix halbackend does not manage to invoke 'fuser' command (2)
Because on Debian / Ubuntu is fuser located in /bin, previously proposed patch could not be approved.
I have prepared another patch to dynamically looking for a path to fuser binary.
Please try it.
Slavek, your modified patch works for me, with actual command being /sbin/fuser . Created attachment 1265 [details]
tdebase 3.5.13.2 : fix halbackend causes KDED stop on assertion failed
... and now that the "fuser -vmk" feature works, it reveals another bug: there is an assertion fails invoking "dbus_message_unref (reply);"
Step to reproduce:
1) mount the usb key
2) open konsole, go to the mounted directory (ex: /media/usbkey)
3) try to eject the key.
4) when it says the device is in use, confirm the forced ejection (it then uses "fuser -vmk ...")
The KDED daemon dies on assetion ...
process 24578: arguments to dbus_message_unref() were incorrect, assertion "message != NULL" failed in file dbus-message.c line 1554.
This is normally a bug in some application using the D-Bus library.
D-Bus not built with -rdynamic so unable to print a backtrace
Program received signal SIGABRT, Aborted.
0x0000003e62634245 in raise () from /lib64/libc.so.6
(gdb) bt
#0 0x0000003e62634245 in raise () from /lib64/libc.so.6
#1 0x0000003e626357cb in abort () from /lib64/libc.so.6
#2 0x0000003e6a230435 in _dbus_abort () at dbus-sysdeps.c:94
#3 0x0000003e6a2272c1 in _dbus_warn_check_failed (
format=0x3e6a2366f0 "arguments to %s() were incorrect, assertion \"%s\" failed in file %s line %d.\nThis is normally a bug in some application using the D-Bus library.\n") at dbus-internals.c:289
#4 0x00007ffff0e1e0f4 in HALBackend::unmount (this=0x777ef0, _udi=<optimized out>)
at /usr/src/debug/trinity-tdebase-3.5.13.2~pre100+073a32f9/kioslave/media/mediamanager/halbackend.cpp:1755
#5 0x00007ffff0dfe985 in MediaManager::unmount (this=<optimized out>, name=<optimized out>)
at /usr/src/debug/trinity-tdebase-3.5.13.2~pre100+073a32f9/kioslave/media/mediamanager/mediamanager.cpp:229
#6 0x00007ffff0e01a18 in MediaManager::process (this=0x6cf6d0, fun=<optimized out>, data=<optimized out>, replyType=..., replyData=...)
at /usr/src/debug/trinity-tdebase-3.5.13.2~pre100+073a32f9/build/kioslave/media/mediamanager/mediamanager_skel.cpp:115
#7 0x00007ffff65d7736 in DCOPClient::receive (this=0x627820, objId=..., fun=..., data=..., replyType=..., replyData=...)
[...]
Attached patch fixes this.
Comment on attachment 1262 [details]
tdebase 3.5.13.2 : fix halbackend does not manage to invoke 'fuser' command (2)
Pushed to GIT in hash 42fc3b28 along with same patch for tdehardwardbackend in hash 134af52f.
Comment on attachment 1265 [details]
tdebase 3.5.13.2 : fix halbackend causes KDED stop on assertion failed
Pushed to GIT in hash 52aae1d1.
François, I'm a little suspicious to use .ascii() in the patch from attachment 1231 [details]. It should be used .utf8()?
It's hard to tell which bug exactly is fixed by this patch ... Apparently, Pardus Linux is a turkish distribution so they've done lots of efforts to support turkish language. So I guess this must fix a turkish-specific translation problem. I think we can ignore this patch for now. Created attachment 1275 [details]
tdebase R14 : fix media name translations
With an understanding of the meaning of the patch I have no problem. The point is that the translation could be a separate "Removable Media" or "Media", without specifying the capacity. I prepared a similar patch for tdehw library in R14 - see attachment.
It is true that the replaced words in this case will always be "Removable Media" or "Media" so ascii() is not the real problem.
Created attachment 1278 [details]
tdebase 3.5.13.2 : make unlock dialog box vibrate when bad password is given (2)
Updated patch for "vibrating unlock dialog box", now with a Kcontrol menu entry (checkbox) to enable/disable this feature.
(En réponse au commentaire 36)
> Fichier joint créé 1275
> tdebase R14 : fix media name translations
>
> With an understanding of the meaning of the patch I have no problem. The point
> is that the translation could be a separate "Removable Media" or "Media",
> without specifying the capacity. I prepared a similar patch for tdehw library
> in R14 - see attachment.
>
> It is true that the replaced words in this case will always be "Removable
> Media" or "Media" so ascii() is not the real problem.
OK I see, the purpose is to allow translation of the "Removable Media" string in tde-i18n packages, and to avoid translating the "501M" part (which may varies ... a lot of course !)
Yes I agree, the ascii() conversion should be no problem, even if it is useless.
Created attachment 1279 [details]
tdebase 3.5.13.2 : add crossfade effect when changing wallpaper (3)
Crossfading wallpaper again, this time with a kcontrol option to enable/disable effect (default is disable).
I noticed that the icons of identical items in Switch user menu is in classic menu and kickoff menu different.
I suggest that instead of patch from attachment 1228 [details] unite icons to be identical in both menus. As a basis, I would recommend icons as is in the kickoff menu. What is your opinion?
Comment on attachment 1231 [details]
tdebase 3.5.13.2 : fix media name translations (pardus)
Pushed to GIT in hash 9a491179 and also into v3.5.13-sru branch.
Comment on attachment 1275 [details]
tdebase R14 : fix media name translations
The patch is not necessary.
Comment on attachment 1232 [details]
tdebase 3.5.13.2 : fix halbackend mount point if media name contains UTF8 caracters (pardus)
Pushed to GIT in hash 4186c3ef and also into v3.5.13-sru branch.
Comment on attachment 1230 [details]
tdebase 3.5.13.2 : use hal to detect media types in halbackend (pardus)
Pushed to GIT in hash 7fdec719 and also into v3.5.13-sru branch.
Comment on attachment 1255 [details]
tdebase 3.5.13.2 : add tooltip support in KMenu (2)
Pushed to GIT in hash 718f6ae3 and also into v3.5.13-sru branch.
Created attachment 1281 [details] tdebase 3.5.13.2 : change icons in the switch user menu to be consistent between the classic and kickoff menu The patch according to the changes proposed in the comment 40. Yes this is a good idea about the lock icon. Just push your patch instead of original one. Comment on attachment 1281 [details]
tdebase 3.5.13.2 : change icons in the switch user menu to be consistent between the classic and kickoff menu
Pushed to GIT in hash e988e6ee and also into v3.5.13-sru branch.
Comment on attachment 1236 [details]
tdebase 3.5.13.2 : add kpowersave shortcut in kcontrol "energy" feature
Pushed to GIT in hash 533941e5 and also into v3.5.13-sru branch.
There are no tooltips in the launcher menu after applying commit 718f6ae3. Well, sort of no tooltips. Enabling only the new checkbox in the Panels->Menu configuration dialog is insufficient. The tooltips checkbox in Panels->Appearance must be enabled as well. The What's This help should provide that detail. I haven't tested any other patches committed here, but the new checkbox What's This help is hard-coded with the term "KMenu." In GIT we moved away from that and use T-Menu. Yet rather than T-Menu I propose the following change: AS IS: When this option is selected a tooltip will appear on the KMenu items. CHANGE TO: When this option is selected a tooltip will appear when hovering the mouse pointer over Application Launcher Menu items. To enable this option also requires that tooltips be enabled in the Panels->Appearance configuration. Good point Darrell. I agree with your new description. I'd write like this, exactly: "When this option is selected, a tooltip will appear when hovering the mouse pointer over Application Launcher Menu items. Enabling this option also requires that tooltips are enabled in the Panels->Appearance configuration menu." The bad news: My fears of use .ascii() in patch from attachment 1231 [details] have been confirmed. If the file system has its own label, is used as media name instead of general 501M Removable Media. Attempt to translate it uses .ascii(), which causes the utf8 in label is destroyed.
There are two possible solutions:
1) only translate common names such as 501M Removable Media and leave the rest as they are.
2) translate all but use .utf8() instead of ascii().
What is your opinion?
>I agree with your new description.
Updated in GIT R14 in commit 5c1cfcf1. Needs to be backported to 3.5.13.2?
(Odpověď na komentář #53)
> >I agree with your new description.
> Updated in GIT R14 in commit 5c1cfcf1. Needs to be backported to 3.5.13.2?
Cherry-picked also into v3.5.13-sru branch.
(En réponse au commentaire 52)
> The bad news: My fears of use .ascii() in patch from attachment 1231 [details] have been
> confirmed. If the file system has its own label, is used as media name instead
> of general 501M Removable Media. Attempt to translate it uses .ascii(), which
> causes the utf8 in label is destroyed.
>
> There are two possible solutions:
> 1) only translate common names such as 501M Removable Media and leave the rest
> as they are.
> 2) translate all but use .utf8() instead of ascii().
>
> What is your opinion?
If you have the opportunity to test with .utf8() and that it works, try and fix it ... I've just upgraded my distro to MGA3 and have trouble making HAL work for now ... So I can not test it right now.
OK I've managed to get HAL working. I've labeled my FAT32 USB key with french UTF8 caracters. And I confirm that thé current patch corrupts them. Changing ascii() to utf8() solves the problem. (Odpověď na komentář #56)
> OK I've managed to get HAL working.
> I've labeled my FAT32 USB key with french UTF8 caracters. And I confirm that
> thé current patch corrupts them.
> Changing ascii() to utf8() solves the problem.
Yes, I also tested it on czech utf8 characters :)
Already fixed in GIT commit 63989b0b and also in v3.5.13-sru branch.
Hello, I've tested the following patches for several weeks now and I've seen no problem at all. Can we please push to them to R14 ? These 2 allow to show Music, Video, Download, etc. .. folders in Kickoff menu, just as in KDE4: #1239 tdelibs 3.5.13.2 : add support for supplementary XDG directories #1240 tdebase 3.5.13.2 : add XDG directories in Kickoff menu Thie one allows to autodetect the printing system if the user has made no printing choice in kcontrol. #1243 tdelibs 3.5.13.2 : fix detect default printing system Useless but funny stuff. Can be enabled/disabled in kcontrol. #1278 tdebase 3.5.13.2 : make unlock dialog box vibrate when bad password is given (2) Nice fading effect when changing wallpaper. Tested OK on dual screen computer. #1279 tdebase 3.5.13.2 : add crossfade effect when changing wallpaper (3) Comment on attachment 1247 [details]
tdebase 3.5.13.2 : add theme selector in kcontrol / kdm
This feature is useless since we have the "tdmtheme" application in Trinity.
Created attachment 1353 [details]
tdelibs 14.0.0 : add support for supplementary XDG directories
Created attachment 1354 [details]
tdelibs 14.0.0 : fix detect default printing system
Created attachment 1355 [details]
tdebase 14.0.0 : make unlock dialog box vibrate when bad password is given
Created attachment 1356 [details]
tdebase 14.0.0 : add crossfade effect when changing wallpaper
Created attachment 1357 [details]
tdebase 14.0.0 : add XDG directories in Kickoff menu
Created attachment 1358 [details]
tdebase 14.0.0 : add ability to unmount hotplug devices before suspend
Created attachment 1359 [details]
tdebase 14.0.0 : copy global bookmarks if user has no personal bookmarks
Created attachment 1361 [details]
tdebase 14.0.0 : renames Control Center icon
Comment on attachment 1361 [details]
tdebase 14.0.0 : renames Control Center icon
Pushed in commit 22fdb5f, together with the updated Italian translation.
Comment on attachment 1234 [details] tdebase 3.5.13.2 : renames Control Center icon Superseded by attachment 1361 [details], which was pushed previously. Comment on attachment 1353 [details]
tdelibs 14.0.0 : add support for supplementary XDG directories
Pushed in commit 4ca4791. Thanks!
Comment on attachment 1239 [details]
tdelibs 3.5.13.2 : add support for supplementary XDG directories
Superseded by v14.0.0 patch, committed above.
Comment on attachment 1357 [details]
tdebase 14.0.0 : add XDG directories in Kickoff menu
Pushed in commit 5723220. Thanks!
Comment on attachment 1240 [details]
tdebase 3.5.13.2 : add XDG directories in Kickoff menu
Superseded by v14.0.0 patch, committed above.
Created attachment 2077 [details]
tdebase 14.0.0 : make unlock dialog box vibrate when bad password is given (2)
Updated patch.
(In reply to Francois Andriot from comment #74) > tdebase 14.0.0 : make unlock dialog box vibrate when bad password is given (2) I have been testing this patch, but there are some side-effects using it, I think due to the fact that in Trinity the kdesktop_lock has been expanded with new functionality compared to KDE3. I will see if I can have a detail look at this next week to fix those problems, then I can push Comment on attachment 1359 [details]
tdebase 14.0.0 : copy global bookmarks if user has no personal bookmarks
Fixed and pushed in commit e96ee72. Thanks!
Comment on attachment 1242 [details]
tdebase 3.5.13.2 : copy global bookmarks if user has no personal bookmarks
Superseded by v14.0.0 patch, committed above.
Comment on attachment 1356 [details]
tdebase 14.0.0 : add crossfade effect when changing wallpaper
Pushed in commit db19d36. Thanks!
Comment on attachment 1279 [details]
tdebase 3.5.13.2 : add crossfade effect when changing wallpaper (3)
Superseded by v14.0.0 patch, committed above.
Comment on attachment 1233 [details] tdebase 3.5.13.2 : fix "safely remove device" command (pardus) > According to the help: > kio_media_mounthelper > Options: > -d Decrypt given URL > -u Unmount given URL > -m Mount given URL (default) > -e Eject given URL via kdeeject > -s Unmount and Eject given URL (necessary for some USB devices) > > I do not know the exactly if it's better to use -s or -u ... Pushed in commit 4ac914f. "-u" only unmounts the device. "-s" or "-e" are the same: they first unmount the device and if there are no errors they invoke eject. As the help for "-s" says, unmount+eject are necessary for some USB devices. So I pushed the patch, even though I can't see any difference on my system. Should any problem arise in future, we can simply revert it and ignore it. >Should any problem arise in future, we can simply revert it and ignore it.
Commit 4ac914fa 2014-07-03 causes the Safely Remove option to fail on my Slackware 14.1 system. Reverting the -u back to -s resolves the failure.
(In reply to Darrell from comment #81) OK, commit 4ac914fa has been reverted. As noted when pushed, since it seems to cause problems we will just ignore that patch. Created attachment 2222 [details]
tqt3: enhance warning verbosity in qfile_unix
Patch from Mandriva's QT3 package, modified for TQT3.
Created attachment 2223 [details]
tqt3: enhance warning verbosity in qfile_unix (2)
Same patch, without FTBFS "not a string literal" ...
Created attachment 2224 [details]
tqt3: fix crash in qtranslator
Patch from mandriva QT3.
Created attachment 2225 [details]
tqt3: fix DPI detection when using XFT2
Created attachment 2231 [details]
tdelibs: fix kurlbar global
Patch from Mandriva kdelibs3. Not sure what it's intended for.
Created attachment 2232 [details]
tdelibs: disable kfiledialogbox OK button if user has no permission on file
Patch from Mandriva kdelibs3. The title is what I'm guessing it does, but I'm not 100% sure.
Created attachment 2233 [details]
tdelibs: fix https loop
Patch from Mandriva kdelibs3. I guess it avoids having a loop of invalid certificates warnings.
Created attachment 2234 [details]
tdelibs: fix groups in kdialogpropertiesdialog
Patch from Mandriva kdelibs3. I have no idea what this patch is intended for. Probably better handling of file owner/group ??
Created attachment 2235 [details]
tdelibs: fix security issue CVE-2009-3736 in libltdl
This patch fixes a security issue in libltdl library.
It also applies to arts, and every package that embed the libltdl library.
Created attachment 2236 [details]
tdelibs: avoid assertion in tdeio karchive
Patch from Mandriva kdelibs3. I've never experienced the assert() so I have no idea in which circunstances it may happen.
Created attachment 2237 [details]
tdelibs: add postofficebox suppot in tdeabc
Patch from Mandriva kdelibs3.
Created attachment 2238 [details]
kdelibs3: workaround wrong dcop messages order
Unmodified patch for kdelibs3.
I have no idea if TDE still has the bug mentioned in this patch, so I've not adapted it.
Created attachment 2239 [details]
kdelibs3: add support for configuration files located in LDAP directory
Unmodified kdelibs3 from Mandriva.
Since I have no way to test such patch, I have not ported it to TDE.
I post it here for reference, if someone wants to do the job.
Created attachment 2240 [details]
tdebase: fix kdesktop resize bug
Patch ported from Mandriva kdebase3. Not sure what the original bug was.
Comment on attachment 2235 [details]
tdelibs: fix security issue CVE-2009-3736 in libltdl
Pushed to GIT in hash 7aeb4e9d.
Comment on attachment 2223 [details]
tqt3: enhance warning verbosity in qfile_unix (2)
Pushed to GIT in hash c86b8f17 (TQt3) and fdc4699b (Qt3).
Comment on attachment 2224 [details]
tqt3: fix crash in qtranslator
Pushed to GIT in hash 3e57876e (TQt3) and a9448305 (Qt3).
Comment on attachment 2225 [details]
tqt3: fix DPI detection when using XFT2
Pushed to GIT in hash f059feb9 (TQt3) and e4b05c8f (Qt3).
Created attachment 2251 [details]
tdebase: updates default Xorg arguments in TDM
This patch changes the default Xorg arguments used by TDM.
Most notably, it adds the "-nolisten TCP" argument, which is the default (I think) in all current other DM.
Created attachment 2252 [details]
tdebase: add ability to restrict the konqueror side bar
Not sure what this one does.
From what I understand, it allows to restrict what the user can see in the Konqueror side bar.
I guess this allows a system administrator to restrict the end-users (security feature).
Created attachment 2253 [details]
tdebase: add side top pixmap in kicker menu
This patch allows more decoration in the classic TDE Menu (not kickoff).
From what I Understand, it allows to add a "top-side" image in the menu. (currently there is only a "left side" image)
I have no sample image yet, I will try to find one.
Created attachment 2254 [details]
tdebase: new picture for tdewizard
The former name of Mandriva distribution was "Mandrake".
Then a copyright issue with Hearst Corporation forced them to change name.
They also took care of removing anything that could look like "Mandrake the Magician" character.
That's why the attached image is supposed to replace this one (magician hat):
/opt/trinity/share/apps/tdewizard/pics/wizard_small.png
Also, they intentionally removed the following wallpaper:
/opt/trinity/share/wallpapers/default_blue.jpg
because of a potential lawsuit issue with Apple.
Created attachment 2255 [details]
tdebase: enable user icon installation on first login
The attached patch allows to copy system-global TDE icons on the user personal desktop upon first TDE login.
Previously, the icons were copied ONLY if "$HOME/Desktop" does not exist at all. This is incorrect, since the "Desktop" folder may have been created by another DE (Gnome, KDE4 ...) but still not containing TDE specific icons that the user expects to have.
Created attachment 2257 [details]
tdebase: kside_top pictures from Mandriva 2008.1 Free
I've found the famous "top side pixmaps" from Mandriva 2008.1.
To test them, just untar them under /opt/trinity/share/apps/kicker/pics/ , apply the related patch, and restart kicker.
In the classic TDE menu, you should see a top blue line, displaying "Free" on the left, and "KDE 3.5" on the right.
I believe that this patch was intended to make KDE3 start menu look like KDE4 classic start menu.
Note 1: using the top side pixmap automatically disable the left side pixmap.
Note 2: there is currently no user option to enable/disable the feature, by default it is enabled and can only be disabled in configuration file.
Created attachment 2258 [details]
tdebase: snapshot of TDE menu using top side pixmap
I just came across this bug on the R14 list. Lots of good work here, but at over 100 comments and over 25 outstanding patches it's a bit overwhelming. Can I have an "executive summary" on the outstanding patches, specifically which ones you would like considered for inclusion in R14? Thanks! Tim, the patches pushed have already been marked as obsolete, so the other ones still apply AFAIK. Comment on attachment 2254 [details]
tdebase: new picture for tdewizard
While I understand (somewhat) why MandrakeSoft would have to do this, from our perspective the original picture is a generic magician's hat and wand. How this could be linked in a TDE context with "Mandrake the Magician" instead of the far more common and apropos "Wizard" style dialogs is beyond me--in our case the association with "Wizard" style dialogs is what is intended. I don't think King Features owns copyright on all magic-related symbols and icons? ;-)
Further, replacing with an image of Konqi introduces serious and immediate copyright concerns as we do not own the KDE trademark and/or symbols. Just because KDE (probably) wouldn't sue us is no reason to go stomping all over their trademarks, that would be unethical to say the least. :-)
As far as I know the only major places Konqi remains in TDE are in a children's wallpaper (generic usage) or as a homage in the About dialog. Let's not go introducing more.
Marking as obsolete and not pushing.
Comment on attachment 2253 [details]
tdebase: add side top pixmap in kicker menu
While I don't particularly like the graphical effect of this I know others do, so I see no reason not to push as long as a graphical configuration option is provided.
The new "Show top image" checkbox should go in the Panel-->Menus configuration screen, directly below the existing "Show side image" checkbox.
Comment on attachment 2232 [details]
tdelibs: disable kfiledialogbox OK button if user has no permission on file
Pushed to GIT in hash 9cb7d73.
Comment on attachment 2233 [details]
tdelibs: fix https loop
Pushed to GIT in hash 9cb7d73.
Comment on attachment 2234 [details]
tdelibs: fix groups in kdialogpropertiesdialog
Pushed to GIT in hash 9cb7d73.
Comment on attachment 2236 [details]
tdelibs: avoid assertion in tdeio karchive
Pushed to GIT in hash 9cb7d73.
Comment on attachment 2231 [details]
tdelibs: fix kurlbar global
I have no idea what this patch is supposed to fix. Any additional information?
Tim, just as additional info, at the time this bug was added to the v14.0.0 bug list (March 2014), it did not contain so many patches. If you consider it appropriate, I think we can remove it from blocking v14.0.0 and push the patches later. This would also avoid introducing last-minute errors due to unclear/non-well-understood patches pushed too quickly. (In reply to Michele Calgaro from comment #117) > Tim, > just as additional info, at the time this bug was added to the v14.0.0 bug > list (March 2014), it did not contain so many patches. > If you consider it appropriate, I think we can remove it from blocking > v14.0.0 and push the patches later. This would also avoid introducing > last-minute errors due to unclear/non-well-understood patches pushed too > quickly. Agreed, but I wanted to see if there were any patches that would obviously help before removing this from the R14 blocker list. Many of these patches will probably merge just fine, however these need careful analysis and testing and therefore should be delayed until after R14: Attachment 1238 [details] (duplicates existing functionality in TDE) Attachment 1241 [details] Attachment 1243 [details] Attachment 1278 [details] (a bit corny; additionally the tdesktop locker is very different from the KDE days) Attachment 1354 [details] Attachment 1358 [details] Attachment 2077 [details] Attachment 2238 [details] The remaining patches are fair game for R14. as of attachment 2077 [details], see comment 75. I did some tests a while ago and had some side effects with kdesktop_lock. Definitely should be left to after v14.0.0 :-) (In reply to Michele Calgaro from comment #119) > as of attachment 2077 [details], see comment 75. I did some tests a while > ago and had some side effects with kdesktop_lock. Definitely should be left > to after v14.0.0 :-) Right, just so that everyone is clear: All patches listed in Comment 118 are NOT to be considered for or merged into R14. :-) Comment on attachment 2239 [details]
kdelibs3: add support for configuration files located in LDAP directory
Where did this patch come from?
I *think* I understand some of what it is trying to do, but is the goal to move the text-based configuration system in ~/.trinity/share/config into an LDAP database?
If so, it's kind of interesting but I suspect it needs a lot of work given the age of the patch (KDE 3.5.5). Definitely post-R14.
Comment on attachment 2237 [details]
tdelibs: add postofficebox suppot in tdeabc
Patch looks useful and sane; pushed to GIT in hash c109867.
(In reply to Timothy Pearson from comment #121) > Comment on attachment 2239 [details] > kdelibs3: add support for configuration files located in LDAP directory > > Where did this patch come from? > > I *think* I understand some of what it is trying to do, but is the goal to > move the text-based configuration system in ~/.trinity/share/config into an > LDAP database? > > If so, it's kind of interesting but I suspect it needs a lot of work given > the age of the patch (KDE 3.5.5). Definitely post-R14. Sorry I only have the source package for the old Mandriva 2008 distribution. All information I have is the build script for RPM package and associated patches. There are very few comments in there. This patch is probably doing what you say, replacing local ~/.kde/share/config/ files with files located in LDAP directory. Since Mandriva is (was?) selling an enterprise-class distribution for both servers and workstations, where all central configuration items were based on LDAP directory, I think they had developed this patch on this purpose... Googling the LDAP patch name, I've found this: (Cooker is the codename for Mandriva in-development distribution) https://www.mail-archive.com/cooker-commits@mandrivalinux.org/msg11121.html The "kurl global" patch original name is: kdelibs-3.3.2-fix-kurlbar-global.patch It contains no comment. I've found nothing in google. In RPM spec file, the patch is applied with command: patch -p1 -b .add_kfile_item_in_global THe "add_kfile_item_in_global" may give a clue; *maybe* it's simply a matter of configuration file organization, e.g. some data go in "kdeglobals" file, where other data go in an application-specific file ... Comment on attachment 2255 [details]
tdebase: enable user icon installation on first login
This patch essentially does a rather poor job of detecting the first login of a new user. As nothing relies on that ability, and there are better ways to do it at any rate, I'm going to reject this patch.
(In reply to Francois Andriot from comment #124) > Googling the LDAP patch name, I've found this: > (Cooker is the codename for Mandriva in-development distribution) > https://www.mail-archive.com/cooker-commits@mandrivalinux.org/msg11121.html Thanks for digging that up! Looks interesting but definitely post-R14. Comment on attachment 2231 [details]
tdelibs: fix kurlbar global
After analyzing the source I realized what this patch does.
In TDE applications, in the file open/save dialog, there is a list of favorite places on the left hand side. It had always puzzled me that after creating an entry in that list it only showed up in the same application (create an entry in the save dialog for kpdf and it won't show up in the save dialog of e.g. kwrite).
This patch makes those favorites global by default, which makes much more sense from a usability standpoint.
Pushed to GIT in hash bba85ed.
Comment on attachment 2240 [details]
tdebase: fix kdesktop resize bug
Patch looks useful and sane; pushed to GIT in hash 4d21a12.
Comment on attachment 2251 [details]
tdebase: updates default Xorg arguments in TDM
Patch looks sane and useful; pushed to GIT in hash 4724b1a.
Comment on attachment 2252 [details]
tdebase: add ability to restrict the konqueror side bar
Patch looks sane and useful; pushed to GIT in hash 4724b1a.
Comment on attachment 2238 [details]
kdelibs3: workaround wrong dcop messages order
I suspect this patch is repairing something that does not exist in TDE. In any case, the patch simply retries the dcop operation until it succeeds, which only masks the problem and might cause other issues.
Rejecting.
Comment on attachment 2253 [details] tdebase: add side top pixmap in kicker menu Pushed to GIT in a default-disabled form (with slight modifications) in GIT hash f4dab23. Bug 2149 has been created to update the artwork and expose GUI controls. None of the remaining patches are applicable to R14, so removing from blocker list. Looks like attachment 2253 [details] (tdebase: add side top pixmap in kicker menu) did not get pushed as part of commit f4dab230.
(In reply to Darrell from comment #134) > Looks like attachment 2253 [details] (tdebase: add side top pixmap in kicker > menu) did not get pushed as part of commit f4dab230. Fixed in GIT hash 276f3d1. Sorry about that! Comment on attachment 1251 [details]
tdebase 3.5.13.2 : add UTF8 support in KDM password dialog box (pardus)
We are working on a better solution for R14.1.0. Patch obsoleted.
|