| Summary: | Build Issue: xrandr support in tdelibs must depend on cmake options rather than on system configuration | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Alexander Golubev (Fat-Zer) <fatzer2> |
| Component: | tdelibs | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | CC: | bugwatch, fatzer2, slavek.banko |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 1300 | ||
| Attachments: |
01-tdelibs-make-xrandr-optional.patch
0001-added-new-build-option-WITH_XRANDR.patch |
||
BTW: If you think xrandr support is mandatory, than cmake should fail on the configuration time if is' missing. tderandr library is required by tdebase package if it's configured WITH_XRANDR. It builds well without it except the issue in bug 1582. Everything seems to work fine with it as well as without, but I'm not sure what functionality is lost in kdm. I think that would be the right way when the WITH_XRANDR is ON, but xrandr not found, it should occur tde_message_fatal. What do you think? Created attachment 1524 [details] 0001-added-new-build-option-WITH_XRANDR.patch (In reply to comment #3) > I think that would be the right way when the WITH_XRANDR is ON, but xrandr not > found, it should occur tde_message_fatal. > > What do you think? Yes, sure... Seems, I've just uploaded the wrong one patch... Pushed to GIT in hash 4626871a. |
Created attachment 1312 [details] 01-tdelibs-make-xrandr-optional.patch Currently, xrandr support depends on the package install or not. It shouldn't be so. The build should be complitly determined by the options givven to cmake, not by the system configuration. I've tested: the tdelibs builds with the option as well as without, but I haven't tested usability and if tderandr library required by other modules or not yet.