By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1560

Summary: Build issue: several FTBFS building R14.0.0
Product: TDE Reporter: Francois Andriot <albator78>
Component: tdelibsAssignee: Francois Andriot <albator78>
Status: RESOLVED FIXED    
Severity: normal CC: albator78, bugwatch, darrella, michele.calgaro, slavek.banko
Priority: P5    
Version: R14.0.0 [Trinity]   
Hardware: All   
OS: Linux   
Compiler Version: TDE Version String:
Application Version: Application Name:
Bug Depends on:    
Bug Blocks: 2014    
Attachments: tdebindings : add missing LDFLAGS causing FTBFS
tdemultimedia : add missing LDFLAGS causing FTBFS
tqt3 : fix ftbfs in qvfb with libpng >= 1.5
libtdeldap : add missing LDFLAGS causing FTBFS
libtqt-perl : fix build with automake >= 1.13
python-trinity : fix FTBFS because invalid include directory
kbiff : fix FTBFS because missing LDFLAGS
gtk3-tqt-engine: fix FTBFS because missing LDFLAGS
kvirc FTBFS build log
tdelibs : fix FTBFS because of libart_lgpl and libudev
tdebase : fix FTBFS when libart_lgpl has nonstandard directory
tqt3 : build as shared library instead of static library
python-tqt : fix FTBFS
python-tqt : fix FTBFS (2)
tdenetwork : use alternate 'resolv.conf' in kppp, if available (redhat legacy)
tdenetwork : update krfb_httpd script (redhat legacy)
tdeio-apt : fix FTBFS when using --enable-final
tellico : fix FTBFS "not a string literal error"
k9copy : fix FTBFS with newer libavcodec library
krecipes : fix FTBFS because missing LDFLAGS
tdemultimedia : add missing LDFLAGS causing FTBFS (2)
kvirc : install in correct folder
tqt3 : remove dead symlink under 'mkspecs/default'
tqt3 : fix "not a string literal" error
tqt3 : fix "not a string literal" error (2)
tdebindings : fix libtool refuses to install in RUBY directory
tdesdk : fix cervisia pod
koffice : fix FTBFS on Fedora 19
ktechlab : fix FTBFS on Fedora 19
krusader : fix FTBFS on Fedora 19
tdelibs: add version to pkgconfig file
tqt3: fix symlink 'mkspecs/default'
tdebindings : fix ruby 2.0 detection
libksquirrel : add support for Giflib 5.0 (FTBFS in opensuse 13.1)
libksquirrel : add support for Giflib 5.0 (FTBFS in opensuse 13.1) (2)
koffice : fix ruby 2.0 detection
krusader : fix FTBFS on tmpvfs
kvirc : install in correct folder (2)
k3b : fix FTBFS with newer ffmpeg
kkbswitch : fix FTBFS because missing include
arts : add requires to pkgconfig file
tdemultimedia : add missing LDFLAGS causing FTBFS (3)
sip4-tqt : Revert pyqt3TQtSignal to pyqt3QtSignal
tdeio-sword: fix sword detection
tqt3 : fix FTBFS due to hidden visibility when building as a shared library
bibletime: fix FTBFS on Fedora 20, fix custom-installed Sword detection
koffice-i18n: fix invalid syntax in pt_BR translation

Description Francois Andriot 2013-07-04 13:08:31 CDT
Hello, I'm currently building TDE R14.0.0 and I will post here all the build patches that I needed to write.
Comment 1 Francois Andriot 2013-07-04 13:09:59 CDT
Created attachment 1328 [details]
tdebindings : add missing LDFLAGS causing FTBFS
Comment 2 Francois Andriot 2013-07-04 13:13:37 CDT
Created attachment 1329 [details]
tdemultimedia : add missing LDFLAGS causing FTBFS

Note: $(VORBIS_LIBS) is mandatory.
I have to add "-lmad" too, but this may be a consequence of building AKODE support. I'm not sure "-lmad" is required without AKODE.
Comment 3 Francois Andriot 2013-07-04 13:16:06 CDT
Created attachment 1330 [details]
tqt3 : fix ftbfs in qvfb with libpng >= 1.5
Comment 4 Francois Andriot 2013-07-04 13:17:10 CDT
Created attachment 1331 [details]
libtdeldap : add missing LDFLAGS causing FTBFS
Comment 5 Francois Andriot 2013-07-04 13:17:52 CDT
Created attachment 1332 [details]
libtqt-perl : fix build with automake >= 1.13
Comment 6 Francois Andriot 2013-07-04 13:19:14 CDT
Created attachment 1333 [details]
python-trinity : fix FTBFS because invalid include directory
Comment 7 Darrell 2013-07-04 21:56:27 CDT
I added the report to the R14 etherpad road map.
Comment 8 Francois Andriot 2013-07-05 16:39:49 CDT
I have no automake 1.13 support in "admin" folder in following component:
  tdeio-apt
  tdeio-umountwrapper
  tderadio
  tdmtheme
Comment 9 Slávek Banko 2013-07-06 05:44:11 CDT
(Odpověď na komentář #8)
> I have no automake 1.13 support in "admin" folder in following component:
>   tdeio-apt
>   tdeio-umountwrapper
>   tderadio
>   tdmtheme

I did update modules. We'll see if automated system revert updates back or leave current state.
Comment 10 Francois Andriot 2013-07-07 06:23:27 CDT
Created attachment 1337 [details]
kbiff : fix FTBFS because missing LDFLAGS

kbibtex builds out of the box, but kbiff requires the attached patch.
Comment 11 Francois Andriot 2013-07-07 07:42:45 CDT
kvirc FTBFS because in all .h file, there is Q_OBJECT defined but no TQ_OBJECT .

Update source code with:
sed -i src/*/*/*.h src/*/*/*.sh -e "s|Q_OBJECT|TQ_OBJECT|"
Comment 12 Slávek Banko 2013-07-07 08:13:23 CDT
Comment on attachment 1337 [details]
kbiff : fix FTBFS because missing LDFLAGS

Pushed to GIT in hash 79960d05.
Thank you for testing and patch.
Comment 13 Francois Andriot 2013-07-07 08:16:25 CDT
Created attachment 1338 [details]
gtk3-tqt-engine: fix FTBFS because missing LDFLAGS
Comment 14 Slávek Banko 2013-07-07 08:23:12 CDT
(Odpověď na komentář #11)
> kvirc FTBFS because in all .h file, there is Q_OBJECT defined but no TQ_OBJECT
> .
> 
> Update source code with:
> sed -i src/*/*/*.h src/*/*/*.sh -e "s|Q_OBJECT|TQ_OBJECT|"

This is strange, because in any other module is not used TQ_OBJECT, but Q_OBJECT. In addition, when using TQ_OBJECT then not working automoc to generate MOC. See:

http://trinity-users.pearsoncomputing.net/?0::5080
Comment 15 Francois Andriot 2013-07-07 08:46:13 CDT
(En réponse au commentaire 14)
> (Odpověď na komentář #11)
> > kvirc FTBFS because in all .h file, there is Q_OBJECT defined but no TQ_OBJECT
> > .
> > 
> > Update source code with:
> > sed -i src/*/*/*.h src/*/*/*.sh -e "s|Q_OBJECT|TQ_OBJECT|"
> 
> This is strange, because in any other module is not used TQ_OBJECT, but
> Q_OBJECT. In addition, when using TQ_OBJECT then not working automoc to
> generate MOC. See:
> 
> http://trinity-users.pearsoncomputing.net/?0::5080


Interesting, I have the exact opposite behaviour (in kvirc only).
When using Q_OBJECT, I get several messages like this:

/usr/bin/tqmoc  ../tal/kvi_tal_application_kde.h -o ../tal/kvi_tal_application_kde.moc
../tal/kvi_tal_application_kde.h:0: Warning: No relevant classes found. No output generated.

Then FTBFS
../tal/kvi_tal_iconview_qt3.h:77: Error: The declaration of the class "KviTalIconView" contains signals or slots
         but no TQ_OBJECT macro.

Using TQ_OBJECT solves this.
Comment 16 Francois Andriot 2013-07-07 08:47:06 CDT
Created attachment 1339 [details]
kvirc FTBFS build log
Comment 17 Slávek Banko 2013-07-07 08:57:44 CDT
(Odpověď na komentář #10)
> Vytvořena příloha 1337
> kbiff : fix FTBFS because missing LDFLAGS
> 
> kbibtex builds out of the box, but kbiff requires the attached patch.

Note: For KBiff you have in tde-packaging wrong description and dependencies.
Comment 18 Francois Andriot 2013-07-09 14:06:37 CDT
file "pkgconfig/tdelibs.pc" makes other packages FTBFS on some distro because missing variable "Version".

E.g:
echo "Version: 14.0.0" >>"tdelibs.pc"
Comment 19 Francois Andriot 2013-07-09 14:07:44 CDT
Slavek thanks for pointing kbiff mistake, it is fixed now;
Comment 20 Francois Andriot 2013-07-09 14:09:03 CDT
kdbg built successfully without any patch.
I'm done building all R14 packages on Mageia 3 now.
There should be very few build issues on other distributions.
Comment 21 Francois Andriot 2013-07-17 08:00:15 CDT
Created attachment 1348 [details]
tdelibs : fix FTBFS because of libart_lgpl and libudev

Hello, 2 more FTBFS found on CentOS 6 in tdelibs :

1) Libart LGPL libraries are not found if they are installed in a nonstandard directory;

2) "#include <libudev.h>" must be called with "extern C".
Comment 22 Francois Andriot 2013-07-17 08:29:31 CDT
Created attachment 1349 [details]
tdebase : fix FTBFS when libart_lgpl has nonstandard directory
Comment 23 Francois Andriot 2013-07-21 04:04:01 CDT
Created attachment 1360 [details]
tqt3 : build as shared library instead of static library

Not an FTBFS, but I prefer building TQT3 as shared library (libtqt-mt.so.3.5.0) instead of static.
Comment 24 Francois Andriot 2013-07-23 11:07:22 CDT
Created attachment 1370 [details]
python-tqt : fix FTBFS

I encountered 2 problems in python-tqt :

1) When using distribution-provided SIP, the C++ type "pyqt3TQtSignal" does not exist, I only have "pyqt3QtSignal". I saw that Trinity's provided SIP has renamed Qt to TQt, so the type was renamed too. But then we are now incompatible with original SIP ! Personlay, I do not want/need to build Trinity's SIP since the distribution one works correclty, apart from that renaming issue.

2) Under CentOS 6 only, makefile generation for pyuic3 and pylupdate3 fails if the target directory does not exist prior to running the command. So I need to "mkdir" the directories first.
Comment 25 Francois Andriot 2013-07-23 11:17:56 CDT
Created attachment 1371 [details]
python-tqt : fix FTBFS (2)

Better patch, check if directory exists before creating it (avoid python exception !!!)
Comment 26 Francois Andriot 2013-07-23 14:47:16 CDT
Created attachment 1373 [details]
tdenetwork : use alternate 'resolv.conf' in kppp, if available (redhat legacy)

Hey, I've found out some more legacy patches that I did not submit here !

This patch makes KPPP try to use file "/var/run/ppp/resolv.conf", if available, prior to using "/etc/ppp/resolv.conf".

I dunno what the purpose is, I guess that at some point of history, Fedora had its own configuration directory.
Comment 27 Francois Andriot 2013-07-23 14:55:27 CDT
Created attachment 1374 [details]
tdenetwork : update krfb_httpd script (redhat legacy)

Still dunno exactly what this one does.
It is related to the "Desktop Sharing" feature, which is using VNC server, which can be accessed via HTTP.
It looks like this page takes into account a new/different version of the VNC server.
Comment 28 Francois Andriot 2013-07-29 04:29:23 CDT
Created attachment 1424 [details]
tdeio-apt : fix FTBFS when using --enable-final

Hello, I've found that activating the option "--enable-final" on some packages cause FTBFS. So here is a patch for tdeio-apt .
Comment 29 Francois Andriot 2013-07-29 11:12:19 CDT
Created attachment 1425 [details]
tellico : fix FTBFS "not a string literal error"

The attached patch is for 3.5.13.2 but should work on 14.0.0 or be easily portable.
Comment 30 Francois Andriot 2013-07-29 15:02:15 CDT
Created attachment 1426 [details]
k9copy : fix FTBFS with newer libavcodec library

Another patch for 3.5.13.2 which should work for 14.0.0.
Comment 31 Francois Andriot 2013-08-01 04:06:32 CDT
Created attachment 1433 [details]
krecipes : fix FTBFS because missing LDFLAGS
Comment 32 Slávek Banko 2013-08-01 07:35:45 CDT
Comment on attachment 1433 [details]
krecipes : fix FTBFS because missing LDFLAGS

Pushed to GIT in hash 05371289.
Comment 33 Slávek Banko 2013-08-01 07:55:25 CDT
Comment on attachment 1425 [details]
tellico : fix FTBFS "not a string literal error"

Pushed to GIT in hash e22d244e.
Comment 34 Slávek Banko 2013-08-01 10:18:54 CDT
Comment on attachment 1332 [details]
libtqt-perl : fix build with automake >= 1.13

Pushed to GIT in hash 40f0f2ae.
Comment 35 Slávek Banko 2013-08-01 10:22:52 CDT
Comment on attachment 1426 [details]
k9copy : fix FTBFS with newer libavcodec library

Pushed to GIT in hash 76443cbb.
Comment 36 Slávek Banko 2013-08-01 10:31:34 CDT
Comment on attachment 1338 [details]
gtk3-tqt-engine: fix FTBFS because missing LDFLAGS

Pushed to GIT in hash 273baf5f.
Comment 37 Slávek Banko 2013-08-01 11:09:30 CDT
Comment on attachment 1348 [details]
tdelibs : fix FTBFS because of libart_lgpl and libudev

Pushed to GIT in hash 6b1e323c and 12b5e141.
Comment 38 Slávek Banko 2013-08-01 11:10:03 CDT
Comment on attachment 1349 [details]
tdebase : fix FTBFS when libart_lgpl has nonstandard directory

Pushed to GIT in hash 9f749e63.
Comment 39 Francois Andriot 2013-08-02 04:22:35 CDT
Sorry, I made a mistake in attachment 1426 [details], about k9copy and libavcodec library.
The correct version should be '54.25' NOT '53.26'

See: https://github.com/FFmpeg/FFmpeg/commit/104e10fb426f903ba9157fdbfe30292d0e4c3d72
Comment 40 Slávek Banko 2013-08-02 05:02:30 CDT
(Odpověď na komentář #39)
> Sorry, I made a mistake in attachment 1426 [details], about k9copy and libavcodec
> library.
> The correct version should be '54.25' NOT '53.26'
> 
> See:
> https://github.com/FFmpeg/FFmpeg/commit/104e10fb426f903ba9157fdbfe30292d0e4c3d72

Fixed in GIT hash b375ac5d.
Comment 41 Francois Andriot 2013-08-03 15:54:19 CDT
libcarddav FTBFS on Mageia 3 because file "ChangeLog' is empty.
The 'configure.ac' file checks the software version by running the "version.sh" script, which read the number in ChangeLog. This step fails and causes the "./autogen.sh" script to fail entirely.

I see in GIT that the ChangeLog existed in initial import, so why empty it afterward ?
Comment 42 Darrell 2013-08-03 16:14:47 CDT
I also see the following libcarddav build message:

configure.ac:26: error: AC_INIT should be called with package and version arguments
Comment 43 Francois Andriot 2013-08-04 12:59:50 CDT
Created attachment 1441 [details]
tdemultimedia : add missing LDFLAGS causing FTBFS (2)

New patch for tdemultimedia FTBFS.
Still missing flags for Vorbis stuff, but also for Mad.

Unlike what I thought before, the need for "-lmad" in tdemultimedia is NOT related to having Akode support, it's in fact related to having ARTS compiled with MAD support. So whenever Arts has -DWITH_MAD=ON set, we need the "-lmad" here.
Comment 44 Francois Andriot 2013-08-04 13:03:14 CDT
Comment on attachment 1339 [details]
kvirc FTBFS build log

The KVIRC problem is solved.

I was using:
  --with-qt-moc=/usr/bin/tqmoc

But now I use:
  --with-qt-moc=/usr/bin/tmoc

And now it works with Q_OBJECT.
Comment 45 Francois Andriot 2013-08-04 14:13:00 CDT
Created attachment 1442 [details]
kvirc : install in correct folder

By default, kvirc install its stuff under /opt/trinity/share/kvirc/ , but at runtime, it looks under /opt/trinity/lib/kvirc .

I see in the Ubuntu packaging that there is a brutal "mv" command at the end of the install ...

The attached patch makes installation directly in the correct folder.
Comment 46 Francois Andriot 2013-08-06 16:42:26 CDT
Created attachment 1451 [details]
tqt3 : remove dead symlink under 'mkspecs/default'

When installing tqt3-devel package, I always get a dead symlink '/usr/share/tqt3/mkspecs/default/linux-g++-64 , which points to  a temporary build directory.

The attached patch removes the creation of this dead link.
Comment 47 Francois Andriot 2013-08-10 18:15:10 CDT
Created attachment 1455 [details]
tqt3 : fix "not a string literal" error
Comment 48 Francois Andriot 2013-08-10 18:46:10 CDT
Created attachment 1457 [details]
tqt3 : fix "not a string literal" error (2)
Comment 49 Slávek Banko 2013-08-15 20:27:34 CDT
Comment on attachment 1457 [details]
tqt3 : fix "not a string literal" error (2)

Fixed in GIT hash 16f24a61 (Qt3) and 13618b73 (TQt3).
Comment 50 Slávek Banko 2013-08-15 20:28:45 CDT
Comment on attachment 1330 [details]
tqt3 : fix ftbfs in qvfb with libpng >= 1.5

Fixed in GIT hads af5bc055 (Qt3) and 3af9b39a (TQt3)
Comment 51 Francois Andriot 2013-08-17 04:22:44 CDT
Created attachment 1476 [details]
tdebindings : fix libtool refuses to install in RUBY directory

Strange problem on Fedora 19 ...
Our "configure.in.in" files check ruby directories using "ruby -r ...." commands.
On Fedora 19, it returns, among others:
  RUBY_ARCHDIR=/usr/lib64/ruby/
Notice there is "/" at the end of the path.

Then, during "make install", libtool exits with error, saying that "qtruby.la" cannot be installed under a path not ending with "/usr/lib64/ruby" (without the ending slash).

It looks like recent versions of libtool are very strict about path.

The attached patch makes sure that our RUBY detection removes the potential ending slashes. It works for both 3.5.13.2 and 14.0.0 .

Error log:

make[5]: Entering directory `/dev/shm/BUILD.fc19.x86_64/trinity-tdebindings-3.5.13.2/qtruby/rubylib/qtruby'
make[5]: Nothing to be done for `install-exec-am'.
 /bin/mkdir -p '/dev/shm/BUILDROOT.fc19.x86_64/trinity-tdebindings-3.5.13.2-2.fc19.opt.x86_64/usr/lib64/ruby/'
 /bin/sh ../../../libtool   --mode=install /bin/install -c -p   qtruby.la '/dev/shm/BUILDROOT.fc19.x86_64/trinity-tdebindings-3.5.13.2-2.fc19.opt.x86_64/usr/lib64/ruby/'
libtool: install: error: cannot install `qtruby.la' to a directory not ending in /usr/lib64/ruby/
make[5]: *** [install-rubylibLTLIBRARIES] Error 1
make[5]: Leaving directory `/dev/shm/BUILD.fc19.x86_64/trinity-tdebindings-3.5.13.2/qtruby/rubylib/qtruby'
make[4]: *** [install-am] Error 2
make[4]: Leaving directory `/dev/shm/BUILD.fc19.x86_64/trinity-tdebindings-3.5.13.2/qtruby/rubylib/qtruby'
make[3]: *** [install-recursive] Error 1
make[3]: Leaving directory `/dev/shm/BUILD.fc19.x86_64/trinity-tdebindings-3.5.13.2/qtruby/rubylib/qtruby'
make[2]: *** [install-recursive] Error 1
make[2]: Leaving directory `/dev/shm/BUILD.fc19.x86_64/trinity-tdebindings-3.5.13.2/qtruby/rubylib'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/dev/shm/BUILD.fc19.x86_64/trinity-tdebindings-3.5.13.2/qtruby'
make: *** [install-recursive] Error 1
Comment 52 Francois Andriot 2013-08-17 04:51:39 CDT
Created attachment 1477 [details]
tdesdk : fix cervisia pod

When building on Fedora 19, I get the error:

[  5%] Generating cervisia.1
cd /dev/shm/BUILD.fc19.x86_64/trinity-tdesdk-3.5.13.2/build/cervisia && pod2man /dev/shm/BUILD.fc19.x86_64/trinity-tdesdk-3.5.13.2/cervisia/cervisia.pod > cervisia.1.in
/dev/shm/BUILD.fc19.x86_64/trinity-tdesdk-3.5.13.2/cervisia/cervisia.pod around line 87: You forgot a '=back' before '=head1'
POD document had syntax errors at /bin/pod2man line 69.
make[2]: *** [cervisia/cervisia.1] Error 255
make[2]: Leaving directory `/dev/shm/BUILD.fc19.x86_64/trinity-tdesdk-3.5.13.2/build'
make[1]: *** [cervisia/CMakeFiles/cervisia-man.dir/all] Error 2
make[1]: Leaving directory `/dev/shm/BUILD.fc19.x86_64/trinity-tdesdk-3.5.13.2/build'
make: *** [all] Error 2

Attached patch fixes it. (both 3.5.13.2 and 14.0.0)
Comment 53 Francois Andriot 2013-08-17 09:52:03 CDT
Created attachment 1478 [details]
koffice : fix FTBFS on Fedora 19

Koffice FTBFS on Fedora 19

In file included from /usr/include/tqt/tqdom.h:32:0,
                 from basicelement.h:25,
                 from basicelement.cc:25,
                 from libkformulalib_la.all_cc.cc:2:
/usr/lib64/qt-3.3/include/qdom.h: At global scope:
/usr/lib64/qt-3.3/include/qdom.h:514:5: error: 'QDomElement::QDomElement(QDomElementPrivate*)' is private
     QDomElement( QDomElementPrivate* );
     ^
In file included from sequenceelement.cc:36:0,
                 from libkformulalib_la.all_cc.cc:8:
creationstrategy.h:89:85: error: within this context
     virtual BasicElement* createElement( TQString type, const TQDomElement& element = 0 );
Comment 54 Francois Andriot 2013-08-17 11:01:53 CDT
Created attachment 1479 [details]
ktechlab : fix FTBFS on Fedora 19
Comment 55 Francois Andriot 2013-08-17 11:59:57 CDT
Created attachment 1480 [details]
krusader : fix FTBFS on Fedora 19
Comment 56 Slávek Banko 2013-08-18 12:14:29 CDT
(Odpověď na komentář #51)
> Vytvořena příloha 1476
> tdebindings : fix libtool refuses to install in RUBY directory
> 
> Strange problem on Fedora 19 ...
> Our "configure.in.in" files check ruby directories using "ruby -r ...."
> commands.
> On Fedora 19, it returns, among others:
>   RUBY_ARCHDIR=/usr/lib64/ruby/
> Notice there is "/" at the end of the path.
> 
> Then, during "make install", libtool exits with error, saying that "qtruby.la"
> cannot be installed under a path not ending with "/usr/lib64/ruby" (without the
> ending slash).
> 
> It looks like recent versions of libtool are very strict about path.
> 
> The attached patch makes sure that our RUBY detection removes the potential
> ending slashes. It works for both 3.5.13.2 and 14.0.0 .
> 

I understand that the same fix is also suitable for KOffice?
Comment 57 Francois Andriot 2013-08-18 13:32:36 CDT
(En réponse au commentaire 56)
> (Odpověď na komentář #51)

> I understand that the same fix is also suitable for KOffice?

I did not get this particular error when building Koffice.
Comment 58 Slávek Banko 2013-08-19 17:44:37 CDT
Created attachment 1486 [details]
tdelibs: add version to pkgconfig file

In connection with the comment 18 I prepared a patch for autocompletion version number in the pkgconfig file.

François, others, please test it.
Comment 59 Slávek Banko 2013-08-19 19:04:09 CDT
Created attachment 1487 [details]
tqt3: fix symlink 'mkspecs/default'

Instead of removal symlink creation I tried to fix it.
François, others, please test it.
Comment 60 Francois Andriot 2013-08-19 23:51:04 CDT
(En réponse au commentaire 59)
> Fichier joint créé 1487
> tqt3: fix symlink 'mkspecs/default'
> 
> Instead of removal symlink creation I tried to fix it.
> François, others, please test it.

Hello, the symlink "default" is already created with correct target earlier in the "configure" script, so I don't see the point of recreating (correctly or not) here.
Comment 61 Slávek Banko 2013-08-20 12:22:30 CDT
(Odpověď na komentář #60)
> (En réponse au commentaire 59)
> > Fichier joint créé 1487
> > tqt3: fix symlink 'mkspecs/default'
> > 
> > Instead of removal symlink creation I tried to fix it.
> > François, others, please test it.
> 
> Hello, the symlink "default" is already created with correct target earlier in
> the "configure" script, so I don't see the point of recreating (correctly or
> not) here.

Yes, you're right, of course - I did not look into the configure script. It has a patch from attachment 1487 [details] is therefore invalid and I'll push your patch from attachment 1451 [details].
Comment 62 Francois Andriot 2013-08-20 12:45:04 CDT
attachement 1486 is OK for tdelibs => you can push it.
Comment 63 Slávek Banko 2013-08-20 13:17:25 CDT
Comment on attachment 1487 [details]
tqt3: fix symlink 'mkspecs/default'

Instead of this invalid patch was pushed patch from attachment 1451 [details]
Comment 64 Slávek Banko 2013-08-20 13:19:40 CDT
Comment on attachment 1486 [details]
tdelibs: add version to pkgconfig file

Pushed to GIT in hash 8e37bb97.
Comment 65 Slávek Banko 2013-08-23 09:06:13 CDT
Comment on attachment 1424 [details]
tdeio-apt : fix FTBFS when using --enable-final

Pushed to GIT in hash c4c5713c.
Comment 66 Slávek Banko 2013-08-23 09:34:22 CDT
Comment on attachment 1477 [details]
tdesdk : fix cervisia pod

Pushed to GIT in hash 737fd486.
Comment 67 Slávek Banko 2013-08-23 09:36:16 CDT
Comment on attachment 1331 [details]
libtdeldap : add missing LDFLAGS causing FTBFS

Pushed to GIT in hash ce1a8700.
Comment 68 Slávek Banko 2013-08-23 09:54:51 CDT
(Odpověď na komentář #43)
> Vytvořena příloha 1441
> tdemultimedia : add missing LDFLAGS causing FTBFS (2)
> 
> New patch for tdemultimedia FTBFS.
> Still missing flags for Vorbis stuff, but also for Mad.
> 
> Unlike what I thought before, the need for "-lmad" in tdemultimedia is NOT
> related to having Akode support, it's in fact related to having ARTS compiled
> with MAD support. So whenever Arts has -DWITH_MAD=ON set, we need the "-lmad"
> here.

We should add a check for the presence of libmad?
Or we assume that all built arts with mad?
Comment 69 Slávek Banko 2013-08-23 09:54:51 CDT
(Odpověď na komentář #43)
> Vytvořena příloha 1441
> tdemultimedia : add missing LDFLAGS causing FTBFS (2)
> 
> New patch for tdemultimedia FTBFS.
> Still missing flags for Vorbis stuff, but also for Mad.
> 
> Unlike what I thought before, the need for "-lmad" in tdemultimedia is NOT
> related to having Akode support, it's in fact related to having ARTS compiled
> with MAD support. So whenever Arts has -DWITH_MAD=ON set, we need the "-lmad"
> here.

We should add a check for the presence of libmad?
Or we assume that all built arts with mad?
Comment 70 Francois Andriot 2013-08-23 15:15:30 CDT
(En réponse au commentaire 69)
> (Odpověď na komentář #43)
> > Vytvořena příloha 1441
> > tdemultimedia : add missing LDFLAGS causing FTBFS (2)
> > 
> > New patch for tdemultimedia FTBFS.
> > Still missing flags for Vorbis stuff, but also for Mad.
> > 
> > Unlike what I thought before, the need for "-lmad" in tdemultimedia is NOT
> > related to having Akode support, it's in fact related to having ARTS compiled
> > with MAD support. So whenever Arts has -DWITH_MAD=ON set, we need the "-lmad"
> > here.
> 
> We should add a check for the presence of libmad?
> Or we assume that all built arts with mad?

I'm not sure... 
Maybe we should change the pkgconfile file from arts, so that it has the "-lmad" flag when built with MAD.
Then, tdemultimedia would simply use the pkgconfig from Arts.
Comment 71 Francois Andriot 2013-08-24 09:04:31 CDT
Created attachment 1497 [details]
tdebindings : fix ruby 2.0 detection

opensuse 13.1 will come with ruby 2.0. Here is a patch to build tdebindings with ruby 2.0 (patch for 3.5.13.2 but should work in R14 too)
Comment 72 Francois Andriot 2013-08-24 11:00:56 CDT
Created attachment 1498 [details]
libksquirrel : add support for Giflib 5.0 (FTBFS in opensuse 13.1)
Comment 73 Francois Andriot 2013-08-24 13:43:56 CDT
Created attachment 1499 [details]
libksquirrel : add support for Giflib 5.0 (FTBFS in opensuse 13.1) (2)
Comment 74 Francois Andriot 2013-08-24 14:17:50 CDT
Created attachment 1500 [details]
koffice : fix ruby 2.0 detection
Comment 75 Slávek Banko 2013-08-25 11:07:10 CDT
Comment on attachment 1328 [details]
tdebindings : add missing LDFLAGS causing FTBFS

Pushed to GIT in hash 03f7d427.
Comment 76 Slávek Banko 2013-08-25 11:07:44 CDT
Comment on attachment 1476 [details]
tdebindings : fix libtool refuses to install in RUBY directory

Pushed to GIT in hash dcb2a2fb.
Comment 77 Slávek Banko 2013-08-25 11:08:11 CDT
Comment on attachment 1497 [details]
tdebindings : fix ruby 2.0 detection

Pushed to GIT in hash 2cf2b76c
Comment 78 Slávek Banko 2013-08-25 12:42:01 CDT
Comment on attachment 1478 [details]
koffice : fix FTBFS on Fedora 19

Pushed to GIT in hash dee1a982.
Comment 79 Slávek Banko 2013-08-25 12:42:27 CDT
Comment on attachment 1500 [details]
koffice : fix ruby 2.0 detection

Pushed to GIT in hash 7d099fe4.
Comment 80 Slávek Banko 2013-08-25 13:08:46 CDT
Comment on attachment 1499 [details]
libksquirrel : add support for Giflib 5.0 (FTBFS in opensuse 13.1) (2)

In all conditions added "defined(GIFLIB_MAJOR) && " and pushed to GIT in hash a433569b.
Comment 81 Slávek Banko 2013-08-25 13:23:51 CDT
Comment on attachment 1479 [details]
ktechlab : fix FTBFS on Fedora 19

Pushed to GIT in hash cd721557.
Comment 82 Slávek Banko 2013-08-25 13:26:31 CDT
Comment on attachment 1333 [details]
python-trinity : fix FTBFS because invalid include directory

Pushed to GIT in hash a44e65a8.
Comment 83 Slávek Banko 2013-08-25 13:42:54 CDT
(Odpověď na komentář #55)
> Vytvořena příloha 1480
> krusader : fix FTBFS on Fedora 19

I think that the patch needs some adjustments. The proposed form would be umount all tmp vfs without distinction => regardless of whether is mounted.
Comment 84 Slávek Banko 2013-08-25 14:09:43 CDT
(Odpověď na komentář #45)
> Vytvořena příloha 1442
> kvirc : install in correct folder
> 
> By default, kvirc install its stuff under /opt/trinity/share/kvirc/ , but at
> runtime, it looks under /opt/trinity/lib/kvirc .
> 
> I see in the Ubuntu packaging that there is a brutal "mv" command at the end of
> the install ...
> 
> The attached patch makes installation directly in the correct folder.

Although the "mv" in debian/ubuntu packaging looks "brutally" actually moves "only" libraries - ie *.la and *.so from modules. Other "share" remain in place.

It would be possible to separate installation for data and libraries?
Comment 85 Slávek Banko 2013-08-29 12:47:09 CDT
Created attachment 1504 [details]
krusader : fix FTBFS on tmpvfs

Within the meaning of comment 83 I have prepared an alternative patch.
Please test it.
Comment 86 Francois Andriot 2013-08-29 15:13:27 CDT
(En réponse au commentaire 85)
> Fichier joint créé 1504
> krusader : fix FTBFS on tmpvfs
> 
> Within the meaning of comment 83 I have prepared an alternative patch.
> Please test it.

It builds correctly with your patch.
Comment 87 Francois Andriot 2013-08-29 15:29:56 CDT
Created attachment 1505 [details]
kvirc : install in correct folder (2)

New patch for kvirc so that only modules are moved from "share" to "lib".
Comment 88 Slávek Banko 2013-08-29 18:15:03 CDT
Comment on attachment 1504 [details]
krusader : fix FTBFS on tmpvfs

Pushed to GIT in hash d7e200c5.
Comment 89 Slávek Banko 2013-08-29 19:37:54 CDT
Comment on attachment 1505 [details]
kvirc : install in correct folder (2)

It looks good, thanks.
Pushed to GIT in hash a5b7be7d.
Comment 90 Francois Andriot 2013-09-07 05:14:56 CDT
Created attachment 1511 [details]
k3b : fix FTBFS with newer ffmpeg

It looks like the AVCODEC_MAX_AUDIO_FRAME_SIZE macro has been deprecated in FFMPEG and causes FTBFS in K3B. The attached patch use the hardcoded value 192000 instead.

See:
http://ffmpeg.org/pipermail/ffmpeg-cvslog/2012-August/053785.html
https://github.com/jiixyj/libebur128/issues/19
Comment 91 Francois Andriot 2013-09-08 05:02:18 CDT
Created attachment 1514 [details]
kkbswitch : fix FTBFS because missing include
Comment 92 Slávek Banko 2013-09-08 06:55:22 CDT
Comment on attachment 1514 [details]
kkbswitch : fix FTBFS because missing include

Pushed to GIT in hash f4cd558c.
Comment 93 Slávek Banko 2013-09-08 07:02:40 CDT
Comment on attachment 1511 [details]
k3b : fix FTBFS with newer ffmpeg

Pushed to GIT in hash 7de21d9e
Comment 94 Slávek Banko 2013-09-08 09:45:32 CDT
Created attachment 1515 [details]
arts : add requires to pkgconfig file

I have prepared a patch for the arts, as proposed in comment 70.
It remains to fix tdemultimedia to use pkg-config.

It is also possible that the patch will cause FTBFS in other packages - for example in tdelibs is called mcopidl with -I${ARTS_INCLUDE_DIRS} instead of -I{ARTS_INCLUDEDIR}. I'll fix this soon.

Please test this patch.
Comment 95 Francois Andriot 2013-09-08 10:40:36 CDT
Your patch is OK for ARTS.
Comment 96 Francois Andriot 2013-09-08 11:00:21 CDT
Created attachment 1517 [details]
tdemultimedia : add missing LDFLAGS causing FTBFS (3)

OK this new patch allows building tdemultimedia using the flags sets in 'arts.pc'.
Comment 97 Slávek Banko 2013-09-08 11:25:03 CDT
(Odpověď na komentář #96)
> Vytvořena příloha 1517
> tdemultimedia : add missing LDFLAGS causing FTBFS (3)
> 
> OK this new patch allows building tdemultimedia using the flags sets in
> 'arts.pc'.

$(VORBIS_LIBS) and $(VORBISFILE_LIBS) are still needed?
For me both are part of the $(ARTS_LIBS).
Comment 98 Francois Andriot 2013-09-08 11:33:17 CDT
No, it works even when removing them. You can remove them.
Comment 99 Slávek Banko 2013-09-08 11:40:58 CDT
Comment on attachment 1515 [details]
arts : add requires to pkgconfig file

Pushed to GIT in hash f22daba7.
tdelibs FTBFS fixed in GIT hash eeb482ba.
Comment 100 Slávek Banko 2013-09-08 11:50:38 CDT
Comment on attachment 1517 [details]
tdemultimedia : add missing LDFLAGS causing FTBFS (3)

Adjusted and pushed to GIT in hash 1f5ba242.
Thank you for your cooperation.
Comment 101 Slávek Banko 2013-09-08 12:52:44 CDT
Comment on attachment 1374 [details]
tdenetwork : update krfb_httpd script (redhat legacy)

Pushed to GIT in hash efa390ac.
Comment 102 Slávek Banko 2013-09-29 19:08:22 CDT
Created attachment 1529 [details]
sip4-tqt : Revert pyqt3TQtSignal to pyqt3QtSignal

If rename pyqt3TQtSignal is the only one violation of compatibility with the original SIP4, looks like a good idea to revert this renaming. Proposed patch attached.

What do you think?
Comment 103 Francois Andriot 2013-09-30 10:16:28 CDT
(En réponse au commentaire 102)
> Fichier joint créé 1529
> sip4-tqt : Revert pyqt3TQtSignal to pyqt3QtSignal
> 
> If rename pyqt3TQtSignal is the only one violation of compatibility with the
> original SIP4, looks like a good idea to revert this renaming. Proposed patch
> attached.
> 
> What do you think?

Yes, I think it's reasonable to revert just this part. Patch looks good.
Comment 104 Slávek Banko 2013-09-30 15:11:23 CDT
Comment on attachment 1529 [details]
sip4-tqt : Revert pyqt3TQtSignal to pyqt3QtSignal

Pushed to GIT in hash 9b74ae48.
Comment 105 Slávek Banko 2013-09-30 15:13:40 CDT
Comment on attachment 1371 [details]
python-tqt : fix FTBFS (2)

Pushed to GIT as separate commits 275a3ec4 and 92310a96.
Comment 106 Slávek Banko 2013-09-30 16:07:16 CDT
François, I'm sorry, I forgot set you as the author of patches for python-tqt.
Comment 107 Francois Andriot 2013-10-13 14:47:46 CDT
Created attachment 1547 [details]
tdeio-sword: fix sword detection

For an unknown reason, I now need the attached patch to build tdeio-sword in Mageia 3. It used to work since then on the same computer, but who knows what happened ...
Comment 108 Slávek Banko 2013-10-14 20:28:16 CDT
Comment on attachment 1547 [details]
tdeio-sword: fix sword detection

Pushed to GIT in hash 42549c3.
Comment 109 Darrell 2013-11-24 22:56:26 CST
Is this bug report still needed?
Comment 110 Slávek Banko 2013-12-04 16:27:23 CST
(Odpověď na komentář #109)
> Is this bug report still needed?

I hesitate, how to deal with the last patches.

patch in attachment 1360 [details] - seems good to me

patch in attachment 1373 [details] - I'm not sure if it is right to add non-standard path, or leave this patch as a distribution specific
Comment 111 Slávek Banko 2014-01-20 13:57:11 CST
Created attachment 1875 [details]
tqt3 : fix FTBFS due to hidden visibility when building as a shared library

I tested the patch from attachment 1360 [details] but occurred FTBFS.
I have found that it is caused due to hidden visibility.
Attached patch solve this problem.
Comment 112 Slávek Banko 2014-02-02 11:32:19 CST
Comment on attachment 1360 [details]
tqt3 : build as shared library instead of static library

Pushed to GIT in hash 1e11c1dd (Qt3) and 2ee14b64 (TQt3)
Comment 113 Slávek Banko 2014-02-02 11:33:11 CST
Comment on attachment 1875 [details]
tqt3 : fix FTBFS due to hidden visibility when building as a shared library

Pushed to GIT in hash 53479506 (Qt3) and dab0c5cd (TQt3)
Comment 114 Francois Andriot 2014-02-23 15:37:55 CST
Created attachment 1949 [details]
bibletime: fix FTBFS on Fedora 20, fix custom-installed Sword detection
Comment 115 Francois Andriot 2014-05-01 07:16:38 CDT
Created attachment 2049 [details]
koffice-i18n: fix invalid syntax in pt_BR translation

FTBFS in brasilian translation because of missing closing tag.
Comment 116 Slávek Banko 2014-05-01 08:07:50 CDT
Comment on attachment 1949 [details]
bibletime: fix FTBFS on Fedora 20, fix custom-installed Sword detection

Pushed to GIT in hash 298da70a.
Comment 117 Slávek Banko 2014-05-01 08:10:18 CDT
Comment on attachment 2049 [details]
koffice-i18n: fix invalid syntax in pt_BR translation

Pushed to GIT in hash 9a9219b2.
Comment 118 Slávek Banko 2014-07-05 11:53:16 CDT
Comment on attachment 1373 [details]
tdenetwork : use alternate 'resolv.conf' in kppp, if available (redhat legacy)

Pushed to GIT in hash e0801ae2.