| Summary: | Build issue: k9copy uses internal dvdread headers, instead of system-provided ones | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Francois Andriot <albator78> |
| Component: | non-core programs | Assignee: | Francois Andriot <albator78> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | albator78, bugwatch, darrella, kb9vqf |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: | k9copy : use system-provided dvdread headers | ||
|
Description
Francois Andriot
2013-08-02 04:42:55 CDT
Created attachment 1437 [details]
k9copy : use system-provided dvdread headers
The attached patch is an attempt to remove the included "dvdread" folder.
Apply the patch, remove the folder from sources (rm -rf ./dvdread) , then build k9copy.
Perhaps I misunderstand, but what happens when dvdread is not installed from a distro package? Should the k9copy version then be used to compile k9copy? First, if your distribution lacks the dvdread library, k9copy will miss the dvdread-related features, even with the internal headers. What I'm afraid of, when building with internal header, is that they may be obsolete or incompatible with the actual dvdread library intalled on my system. I do not see the purpose of having internal headers: - Either you don't have/want dvdread, and you should have a "--disable-dvdread" option at build time - Either you have and want it, and you install the "dvdread-devel" from your distribution to build k9copy . I suspect dvdread is standard on just about all distros. I was thinking that k9copy installed its own antiquated version when the distro version was not found Comment on attachment 1437 [details]
k9copy : use system-provided dvdread headers
Pushed to GIT in hash 71c6fa0.
Thanks for reporting and for the patch!
|