| Summary: | Some cmake-built packages are missing the translations and/or documentation (build ok with autotools) | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Francois Andriot <albator78> |
| Component: | other (any) | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | albator78, bugwatch, fatzer2, slavek.banko |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: |
tdepowersave : add language build
propoused patch for cmake module propoused patch for tdepowersave propoused patch for tdepowersave |
||
|
Description
Francois Andriot
2013-08-13 00:29:21 CDT
Created attachment 1463 [details]
tdepowersave : add language build
I've noticed that our cmake macro "tde_create_translation" (from TDEMacros.cmake) is inappropriate for this case.
In TDEPowersave, as well as other components, every language has a single file "<language>.po", all located in an unique folder.
The TDE macro expects that "po" files have all the same name, but are located in different subfolder (1 subfolder for each language).
The TDE macro does NOT rename the files when installing.
The attached patch is an incorrect attempt to use the macro.
It results that files are installed with name "<language>.po", e.g. "/opt/trinity/share/locale/fr/LC_MESSAGES/fr.mo", where it should be "/opt/trinity/share/locale/fr/LC_MESSAGES/tdepowersave.mo"
Instead of moving/renaming files in source code, and messing with the autotools build, I think we should have another Cmake macro that handle this case.
Created attachment 1464 [details]
propoused patch for cmake module
Here is a propoused patch or cmake module. I've tested it for tdepowersave(all-in-one-dir structure) and konversation(normal translation structure).
tdepowersave also lacks of documentation build support, so I'm updating the bug summary header.
Created attachment 1465 [details]
propoused patch for tdepowersave
Here is a patch for tdepowersave to add translation and documentation support.
PS: sorry if I updated the bug summary too fast... may be you want a separate bug to track documentation issues.
Created attachment 1466 [details]
propoused patch for tdepowersave
Your 2 patches work as expected for me. If there is no objection, I think they can be pushed to GIT. Comment on attachment 1464 [details]
propoused patch for cmake module
Pushed to GIT in hash b51b691c.
Comment on attachment 1463 [details] tdepowersave : add language build Superseded by attachment 1466 [details] Comment on attachment 1466 [details]
propoused patch for tdepowersave
Guys, it was really nice. The first patch proposed by François, second was from Fat-Zer and the third has already been pushed commit from Darrell. So I did merge and update the remaining part by Fat-Zer patch :)
Pushed to GIT in hash e113ed91.
Thank you to all the participating
What other modules needs to fix? (In reply to comment #9) > What other modules needs to fix? IMO The main idea idea of that bug was it had been impossible to implement the translation support in the sane way unless the patch to shared cmake module was applyed. Also I don't think there are any other yet because only a few non-core modules were ported to cmake. So this one can be closed for now and reopened as soon as anybody will find other problems. Yes, thanks to your patch to shared cmake module I currently fix building translations in kbfx. This bug for now I close. Thanks |