| Summary: | Kate tab bar plugin extension | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Michele Calgaro <michele.calgaro> |
| Component: | tdeaddons | Assignee: | Michele Calgaro <michele.calgaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | bugwatch, darrella, michele.calgaro, slavek.banko |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | All | ||
| OS: | All | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Attachments: |
Kate tab bar extension patch
Kate tab bar extension NEW patch |
||
Changed status to PATCHAVAIL Created attachment 1526 [details]
Kate tab bar extension NEW patch
Apologies, had actually left a small mistake in the previous (manually modified) patch file, so patching was actually failing. Please use the new file.
I am unable to get the tabbar extension to appear in kate (with or without the patch). I select the check box in Settings but the bar never appears. When I again open Settings the check box is unchecked. I posted a query in the dev mail list and associated stderr messages. (In reply to comment #3) > I am unable to get the tabbar extension to appear in kate (with or without the > patch). I select the check box in Settings but the bar never appears. When I > again open Settings the check box is unchecked. I have no problem on my system with the tabbar extensions, with or without my patch. Perhaps this is an idea you can look at. I assume you have installed tdeaddons. If you installed the patch for the listview file rename (bug 1677), you could have problems if you have not recompiled tdeaddons. For example on my computer Kate was always crashing at startup. After I recompiled tdeaddons it was ok again. The problems occur with an almost full package set rebuild. After that I rebuilt tdelibs before I rebuilt tdeaddons. What are your tdelibs and tdeaddons configuration options? I have a virtual machine running Trinity. The package set is from July 29. I see the same behavior there in that selecting the plugin check boxes results in the tabbar not appearing and when immediately thereafter opening the Settings dialog the check boxes are cleared. I do not see the stderr messages but I suspect that is because this older package set does not include commit 5354555. I have a 3.5.13.0 virtual machine. There I am able to enable the tabbar extension. That tells me only that something changed from 3.5.13.0 to pre R14. The problem appears with or without the tdeaddons patch. I suspect tdelibs, either a corner case I have stumbled across or something in my build script configuration options. The problem occurs with a fresh profile too. I performed a complete package set rebuild. As always, a clean build environment. Same problem. Is there a way to debug this? I have removed the dependency from bug 1687 since they are two independent bugs. Bug 1687 is about availability of Kate plugins in some distribution and is unaffected by this patch. This patch is just an enhancement for the Kate tab bar. (In reply to comment #8) > Is there a way to debug this? I have posted on the page for bug 1687 > I have removed the dependency from bug 1687 since they are two independent bugs
Yes, but when a user can't load the plugins, as in my case, attempting to test the patch is futile. As some users are not experiencing the bug there is a possibility the patch could be pushed to git and the bug gets ignored. Hence my tagging the dependency --- to ensure the bug is resolved before anybody pushed the enhancement patch to git.
After resolving bug report 1687, I successfully tested the patch. Middle-click works as expected both ways from the dialog check box. Slavek, I see no reason not to push the patch to git. Pushed to GIT in hash 7311671c. |
Created attachment 1525 [details] Kate tab bar extension patch I had actually already reported this to the DEV mailing list, but this is probably a better place to do it. Please use this patch since I made a slight change to the original one after using it for about a week. The new patch allows even the last document to be closed, the original one didn't. ------------- I modified the Kate tab bar plugin to add the possibility to close a document by a mouse middle click on the tab button. The feature can be enabled/disabled by a checkbox in the plugin config page and it's off by default to preserve the original behavior. If enabled, a middle click on a tab button *without* any key modifier pressed will close the corresponding document. I also moved most of the single line or empty function definition from the .cpp to the .h inside the class declaration. This is just a matter of personal choice. If you don't like that or it's against some sort of convention, just ignore that part of the patch. The patch also removes two "unused variable" warning messages.