By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1667

Summary:	Progress bar covers dynamic override buttons in logout dialog
Product:	TDE	Reporter:	Alex Couture <ac586133>
Component:	tdebase	Assignee:	Michele Calgaro <michele.calgaro>
Status:	RESOLVED FIXED
Severity:	critical	CC:	ac586133, bugwatch, darrella, kb9vqf, michele.calgaro, slavek.banko
Priority:	P5
Version:	R14.0.0 [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Attachments:	tdebase patch tdebase ksmserver patch for progress bar same as before, but cleaner code

Description Alex Couture 2013-10-01 10:01:51 CDT

Hi,

It would be nice (and a little bit more visual) to have a little progress bar in the window showing the logout process.

In the long run, it would probably possible to replace completely this window by something like moodinKDE splash screen, a little bit like what MS did for Windows 7 logout. The text is simply written in the middle of the screen, eliminating the need of a window. Simple and nice!

Thank you!
-Alexandre

Comment 1 Darrell 2013-10-03 12:37:36 CDT

Have you enabled the logout status dialog?

Control Center->TDE Components->Session Manager->Show logout status dialog

Comment 2 Alex Couture 2013-10-03 18:28:30 CDT

Yes, as far as I know, it is enabled by default.

This is the window I am talking about. It could probably feature a progress bar, or be completely replaced by something more simple, just as in Win7?

Thanks!
-Alexandre

Comment 3 Michele Calgaro 2013-11-20 06:12:09 CST

I will look into this bug.
I do like the logout window, so I am looking at adding a progress bar instead of replacing the whole window and just writing on the screen

Comment 4 Michele Calgaro 2013-11-20 09:06:05 CST

Created attachment 1651 [details]
tdebase patch

Proposed patch attached. It adds a progress bar to the shutdown-in-progress window below the status line and update it progressively.

Comment 5 Slávek Banko 2013-11-20 13:54:54 CST

Tested and works well.
I'll wait for the opinions of others.

Comment 6 Darrell 2013-11-20 14:41:44 CST

Progress bar looks great here. Good job!

Comment 7 Slávek Banko 2013-11-20 21:02:17 CST

Pushed to GIT in hash 1c618af7.

Comment 8 Slávek Banko 2013-12-02 21:10:33 CST

I noticed a really silly mistake. If during closing session the program is slow respond to the notification before close session (for example, due to the waiting prompt for TDEWallet password), buttons for interrupt waiting to notifications are shown in the same place as is progress bar => they are hardly visible - are hidden under progress bar.

Comment 9 Michele Calgaro 2013-12-03 08:29:47 CST

(In reply to comment #8)
> I noticed a really silly mistake. If during closing session the program is slow
> respond to the notification before close session (for example, due to the
> waiting prompt for TDEWallet password), buttons for interrupt waiting to
> notifications are shown in the same place as is progress bar => they are hardly
> visible - are hidden under progress bar.

Thanks Slavek, if I remember the code well, I think to know were the problem could be. I will update the patch when I have some time and then post it again.

Comment 10 Darrell 2013-12-03 09:02:40 CST

Just a reminder if you haven't built packages in a while, the first patch was already committed to git in commit 1c618af7. :-)

Comment 11 Timothy Pearson 2013-12-03 14:19:15 CST

(In reply to comment #9)
> (In reply to comment #8)
> > I noticed a really silly mistake. If during closing session the program is slow
> > respond to the notification before close session (for example, due to the
> > waiting prompt for TDEWallet password), buttons for interrupt waiting to
> > notifications are shown in the same place as is progress bar => they are hardly
> > visible - are hidden under progress bar.
> 
> Thanks Slavek, if I remember the code well, I think to know were the problem
> could be. I will update the patch when I have some time and then post it again.

I just noticed this today as well.  Bumping report priority and changing title.

Comment 12 Michele Calgaro 2013-12-04 02:44:01 CST

Created attachment 1696 [details]
tdebase ksmserver patch for progress bar

Attached patch to fix the problems with the buttons position. 
The buttons will now be shown below the progress bar.
Please test on your system too :)

Comment 13 Michele Calgaro 2013-12-04 02:51:04 CST

Created attachment 1697 [details]
same as before, but cleaner code

Comment 14 Darrell 2013-12-04 10:13:29 CST

I tested the patch. I don't see any difference but I saw none of the described issues. I must not run a lot of services/applets you folks run. :-)

Comment 15 Slávek Banko 2013-12-04 10:48:24 CST

I tested it - works well, the buttons are visible again.

Comment 16 Darrell 2013-12-04 11:22:20 CST

What kinds of services/apps/applets need tob e run to see these dialog buttons?

Comment 17 Slávek Banko 2013-12-04 11:29:41 CST

I performed a test in the way that I run a program that requires a password from TDEWallet (for example KOrn), and leave open prompt for TDEWallet password. In such a state, I gave close the session...

Fixed in GIT hash 91ff56bb.

Comment 18 Alex Couture 2013-12-14 13:44:46 CST

Progress bar looks great!

Thanks!
-Alexandre