By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1705

Summary:	KControl Theme Manager provides no warning that changes are irrevocable
Product:	TDE	Reporter:	Darrell <darrella>
Component:	tdebase	Assignee:	Timothy Pearson <kb9vqf>
Status:	NEW ---
Severity:	minor	CC:	bugwatch, darrella, kb9vqf, keithwdaniels
Priority:	P5
Version:	R14.0.x [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	2969

Description Darrell 2013-11-08 13:31:36 CST

I'm not a theme user. Yet I was testing the KControl Theme Manager and was surprised there is no way to revert changes after selecting the Apply button.

Adding a method to restore settings probably is challenging to fix. As a work-around a warning dialog appearing would be helpful and sooth any eventual pain.

Anybody not knowing the changes are irrevocable will be in for a surprise after selecting the Apply button.

Fortunately for me I have adequate profile backups and could restore my settings after I finished experimenting.

A WarningContinueCancel KDialog will suffice. Proposed dialog text:

You have selected to Apply changes to your desktop theme. Continuing will modify various desktop configurations such as Background, Colors, Style, Icons, Fonts, and Screen Saver. These changes are not reversible. Continue?

Comment 1 Keith 2013-11-09 14:06:18 CST

Instead of saying "These changes are not reversible." which would scare new users, I would use something like this:


The configuration changes made when a new theme is applied, will not be restored when you revert back to the original theme.  To restore these settings you will have to do it manually one at a time or use a backup copy of ~/.trinity.


This explains that the changes will be made and implies that it is fixable but with a bit of effort.

Keith

Comment 2 Darrell 2013-11-09 14:27:23 CST

I just remembered a third way. How about this:

The configuration changes made when applying a new theme are not restored when reverting to a previous theme. To avoid this result requires 1) saving the existing settings as a new theme, 2) manually configuring each setting one at a time, or 3) using a backup copy of the user's Trinity profile directory (normally $TDEHOME).

Comment 3 Timothy Pearson 2013-11-09 15:51:59 CST

Only the (potentially) changed configuration files should be backed up, as the ~/.trinity directory can contain hundreds of megabytes of image data, mailboxes, etc.

Comment 4 Darrell 2013-11-09 16:04:21 CST

> Only the (potentially) changed configuration files should be backed up
Makes sense.

Which config files are affected by modifying the theme? The six buttons at the bottom of the dialog provide only a vague clue.

My idea of a warning message was only temporary relief. Long term the dialog should provide a method to restore all previous settings. Doing that likely requires creating (temporary) *.bak files in the user's profile. :-)

Comment 5 Darrell 2013-11-10 18:13:31 CST

>Which config files are affected by modifying the theme? The six buttons at the
>bottom of the dialog provide only a vague clue.

For future reference in case somebody adds a Restore feature, several times I tested changing the theme. Looks like the following files are candidates for being modified when applying a new theme:

.trinity/share/apps/kdesktop/IconPositions
.trinity/share/apps/tdedisplay/color-schemes/thememgr.kcsrc
.trinity/share/config/clock_panelapplet_..._rc
.trinity/share/config/kcminputrc
.trinity/share/config/kcmthememanagerrc
.trinity/share/config/kdeglobals
.trinity/share/config/kdesktoprc
.trinity/share/config/kickerrc
.trinity/share/config/konquerorrc
.trinity/share/config/twinrc
.trinity/share/config/uiserverrc

Notes:

.trinity/share/config/kcmthememanagerrc might not exist before applying a new theme.

Some files do not always change:

.trinity/share/apps/kdesktop/IconPositions
.trinity/share/config/kcminputrc
.trinity/share/config/kickerrc
.trinity/share/config/konquerorrc
.trinity/share/config/twinrc
.trinity/share/config/uiserverrc

Regardless, adding a Restore function would require saving backup copies of the top list of 11 files.