Bug 172

Created attachment 1145 [details]
mplayerthumbs 0.5b : fix build under TDE 3.5.13.2

URL: http://kde-apps.org/content/show.php?content=41180
Source file for KDE3: http://rockman.altervista.org/_altervista_ht/mplayerthumbs-0.5b.tar.bz2

The attached patch allows building with TDE 3.5.13.2.
But I don't know exactly how to test if it works or not.

Do we want to add mplayerthumbs to the applications tree? If yes then we need to update some things such as kde_chunk.xsl->tde_chunk.xsl.

Compiled and working in R14 / TQT3.

You need upstream tarball:
http://rockman.altervista.org/_altervista_ht/mplayerthumbs-0.5b.tar.bz2

And patch (attached to this bug report)

Then:

# Extract upstream package
cd ~/src
rm -rf mplayerthumbs-0.5b/
tar xfj mplayerthumbs-0.5b.tar.bz2
cd mplayerthumbs-0.5b/

# Patch and clean
patch -p1 < mplayerthumbs-0.5b-trinity.patch

# Remove KDE3 stuff
rm -rf admin

# Convert QT3 to TQT3
~/tde/tde_r14/experimental/qt3-tqt3/convert_existing_qt3_app_to_tqt3

# Convert KDE3 to TDE
find ./ -type f \( -name "*.cpp" -o -name "*.h" \) -print0 |\
xargs -r0 sed -i \
  -e "s|kcmdlineargs.h|tdecmdlineargs.h|g" \
  -e "s|kapplication.h|tdeapplication.h|g" \
  -e "s|kaboutdata.h|tdeaboutdata.h|g" \
  -e "s|klocale.h|tdelocale.h|g" \
  -e "s|kconfigdialog.h|tdeconfigdialog.h|g" \
  -e "s|kwin.h|twin.h|g" \
  -e "s|kconfig.h|tdeconfig.h|g" \
  -e "s|kpopupmenu.h|tdepopupmenu.h|g" \
  -e "s|kglobal.h|tdeglobal.h|g" \
  -e "s|kmainwindow.h|tdemainwindow.h|g" \
  -e "s|KConfig|TDEConfig|g" \
  -e "s|kaboutapplication.h|tdeaboutapplication.h|g" \
  -e "s|KPopupMenu|TDEPopupMenu|g" \
  -e "s|KProcess|TDEProcess|g" \
  -e "s|KCmdLineOptions|TDECmdLineOptions|g" \
  -e "s|KCmdLineArgs|TDECmdLineArgs|g" \
  -e "s|KCmdLineLastOption|TDECmdLineLastOption|g" \
  -e "s|KAboutData|TDEAboutData|g" \
  -e "s|KMainWindow|TDEMainWindow|g" \
  -e "s|KGlobal|TDEGlobal|g" \
  -e "s|KAboutApplication|TDEAboutApplication|g" \
  -e "s|KIcon|TDEIcon|g" \
  -e "s|NEKWinInfo|NETWinInfo|g" \
  -e "s|KApplication|TDEApplication|g" \
  -e "s|kio/|tdeio/|g" \
  -e "s|KStandardDirs|TDEStandardDirs|g"

find ./ -type f \( -name "*.am" \) -print0 |\
xargs -r0 sed -i \
  -e "s|KDE_|TDE_|g" \
  -e "s|TDE_DOCS|KDE_DOCS|g" \
  -e "s|TDE_LANG|KDE_LANG|g" \
  -e "s|_KDE|_TDE|g" \
  -e "s|_QT|_TQT|g" \
  -e "s|-lkde|-ltde|g"


# Now, the sources are ready !

# Generates makefiles ...

cp -rf ~/tde/tde_r14/main/common/admin/ .

cp -f "/usr/share/aclocal/libtool.m4" "admin/libtool.m4.in"
cp -f "/usr/share/libtool/config/ltmain.sh" "admin/ltmain.sh" || cp -f "/usr/share/libtool/ltmain.sh" "admin/ltmain.sh"
make -f "admin/Makefile.common"

# And build ...
unset QTDIR QTINC QTLIB
export PATH="/opt/trinity/bin:/usr/lib64/ccache:/usr/bin:/bin"
export LDFLAGS="-L/opt/trinity/lib64 -I/opt/trinity/include"

./configure \
	--build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --target=x86_64-redhat-linux-gnu \
	--prefix=/opt/trinity \
	--exec-prefix=/opt/trinity \
	--disable-dependency-tracking \
	--disable-rpath \
	--bindir=/opt/trinity/bin \
	--libdir=/opt/trinity/lib64 \
	--datadir=/opt/trinity/share \
	--includedir=/opt/trinity/include/tde \
	--enable-closure

make

# Have fun !

Notice: the resulting package requires the "mplayer" command, it does not use library, it really invokes the command.

Initial version is now available in GIT via:
git clone http://scm.trinitydesktop.org/scm/git/mplayerthumbs

Buildability has not been tested.

Debian/Ubuntu packaging files have been added to the tde-packaging repository.

cgit, the master GIT repository, and the autobuild system have not yet been
updated.

It looks like you forgot to integrate the patch attached to this bug report.
Even though it contains a lot of obsoletes autotools stuff, it also contains FTBFS correction in "videpreview.cpp". You should integrate this part of the patch.

(In reply to comment #5)
> It looks like you forgot to integrate the patch attached to this bug report.
> Even though it contains a lot of obsoletes autotools stuff, it also contains
> FTBFS correction in "videpreview.cpp". You should integrate this part of the
> patch.

You are right; when I looked at the patch I figured it wasn't needed due to replacement of the admin directory with the admin submodule.  Fix committed to GIT in hash a102c3b.

Good, I can build from GIT now.
When you have finished the packaging-related stuff, I think you can close the bug report.
And add it to the R14 "what's new" list :-)

cgit, the master GIT repository, and the autobuild system have now been updated.  Marking NEEDINFO pending results of autobuilds on build farm.

FTBFS on recent GCC:

in "src/videopreview.cpp", you must add:
  #include <unistd.h>
just after
  #include <cstdlib>

Thanks

(Odpověď na komentář #9)
> FTBFS on recent GCC:
> 
> in "src/videopreview.cpp", you must add:
>   #include <unistd.h>
> just after
>   #include <cstdlib>
> 
> Thanks

Fixed in GIT hash 16173fc1
Thank you for patch.

Debian packaging files are ready for build.

Compilation appears to work on the build farm; marking RESOLVED FIXED.

Thank you all for your work on this request!

Note: Packages mplayerthumbs (without suffix -trinity) must be removed from the repository manually.

Done.