| Summary: | kdesktop rounded icon text fix | ||
|---|---|---|---|
| Product: | TDE | Reporter: | David C. Rankin <trin> |
| Component: | tdebase | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | bugwatch, darrella, kb9vqf, trin |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 2014 | ||
| Attachments: |
patch providing radius to desktop icon text
Rounded icon text highlighting patch updated for R14 |
||
Created attachment 1882 [details]
Rounded icon text highlighting patch updated for R14
I tested the updated patch. Selected desktop icons do have rounded highlighting around the text.
Nice patch, thank you!
Next we need a configuration option for folks who do not want rounded highlighting, much the same as in KControl->Appearance & Themes->Icons->Advanced.
(In reply to comment #1) > Created attachment 1882 [details] > Rounded icon text highlighting patch updated for R14 > > I tested the updated patch. Selected desktop icons do have rounded highlighting > around the text. > > Nice patch, thank you! > > Next we need a configuration option for folks who do not want rounded > highlighting, much the same as in KControl->Appearance & > Themes->Icons->Advanced. Agreed. I'll take a look. I've got about 10 more packages to update/build, then we will look at how to set a config option. Best place is KControl->Desktop->Behavior->General. There is a check box Show icons on desktop The new option should be a child check box: | | Show icons on desktop | | Allow programs in desktop window | | Rounded text selection When 'Show icons on desktop' is disabled then 'Rounded text selection' is disabled/ghosted, just like 'Allow programs in desktop window'. I'm trying to figure out why we need this. With the latest R14 sources kdesktop obeys the global icon rounded selection setting; do we really want the desktop and Konqueror to be able to use two different selection modes? I guess this patch is a "leftover" from when kdesktop didn't support the global icon selection setting? I have been building tdebase with the proposed patch. To rebuild tdebase w/o the patch we need to resolve bug 2145. :( As far as I can tell, building without the proposed patch results in no problems. The global kcontrol feature to use rounding changes the desktop icon text. Thus the patch does not seem needed. The proposed patch makes the rounding permanent with respect to the desktop icon text. Hence the discussion about adding controls. Perhaps when the patch was proposed there was a bug that prevented that text from rounding. So what this boils down to then is do we want to have the ability to have square icon selection boxes in Konqueror and rounded ones on the desktop. Personally I think this is not a good idea; while TDE is quite configurable I think this crosses some lines and would add a lot of confusion. As it is such a minor, yet continuous, irritant, if people didn't get the fact that there are two controls then they could form a negative long-term impression of TDE without even letting us know about it or asking any questions. Therefore, I'm going to mark this RESOLVED FIXED and not commit the patch. If anyone thinks this functionality is desired for some reason please take the resultant discussion to the mailing list. Thanks! |
Created attachment 1873 [details] patch providing radius to desktop icon text This patch provides a radius for desktop icon text to prevent the square box look to icon text background. This is part of a patchset that has been successfully applied against all tde versions.