| Summary: | [Help Handbooks] KEditBookmarks cannot access help handbook | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | tdebase | Assignee: | Michele Calgaro <michele.calgaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugwatch, darrella, michele.calgaro |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 2014 | ||
| Attachments: | A copy of keditbookmarks.desktop with a DocPath defined | ||
KEditBookmarks is an application that can live on his own, so I don't think it is correct to point to the Konqueror/Bookmarks page. Instead I find more appropriate to have a small indipendent handbook. The contents can be taken from the Konqueror/Bookmarks page, but the two handbooks should be separate entities. Fixed in commits 4b94b06 (main) and 4fbf08b (packaging Debian/Ubuntu). KEditBookmarks now has its own handbook. The contents were mostly taken from the Konqueror/Bookmark handbook page. |
Created attachment 1897 [details] A copy of keditbookmarks.desktop with a DocPath defined This bug goes back to 3.5.10. Open KEditBookmarks, either directly or from the Konqueror Bookmarks menu. In KEditBookmarks, select Help->Bookmark Editor Handbook or press F1. With the latest patches the new "Help Documentation Not Found" help handbook page appears. On previous builds or 3.5.x, the blank page and error message appears about not finding keditbookmarks/index.html. When selecting help in KEditBookmarks, the konqueror handbook should open to chapter 6: konqueror/index.html#bookmarks. This works as expected in KDE4, which means somebody finally noticed anf finally fixed the bug there. Seems KEditBookmarks uses the default tdelibs help function, which defaults to looking for help files based upon the app name: $HTML_INSTALL_DIR/$app_name/index.html. Like KDE4, I added a keditbookmarks.desktop file to /opt/trinity/share/applications/tde ($HTML_INSTALL_DIR). I am attaching a copy. That test failed to change the results. I temporarily soft linked $HTML_INSTALL_DIR/konqueror to $HTML_INSTALL_DIR/keditbookmarks. Then the KEditBookmarks help feature found the konqueror help file, which confirms that KEditBookmarks is using the default tdelibs help function. As expected, the keditbookmarks.desktop file was again ignored because the konqueror handbook opened at the beginning rather than chapter 6. One curious note. There is a directory named /opt/trinity/share/applnk/Internet/keditbookmarks.desktop. In that directory is one file, uninstall.desktop, with one entry, Hidden=true. I don't know the purpose of that file or why there is a unique directory named keditbookmarks.desktop. KDE4 no longer creates this unique directory. I tested adding the keditbookmarks.desktop to the directory /opt/trinity/share/applnk/Internet/keditbookmarks.desktop. Same failed results. Resolution: I have seen this bug with a few other apps, I believe a global solution is to modify the standard tdelibs help function to search for an $app_name.desktop file before resorting to looking for $HTML_INSTALL_DIR/$app_name/index.html. When a DocPath is defined with $app_name.desktop then use that location. For a reference, in KDE4 the KEditBookmarks code is found in kde-baseapps. I do not know how the KDE developers fixed the problem. They might very well have fixed the global help function, or just added code to look for a keditbookmarks.desktop file and use the DocPath within.