| Summary: | Remove code references to KInfo Center | ||
|---|---|---|---|
| Product: | TDE | Reporter: | Darrell <darrella> |
| Component: | other (any) | Assignee: | Timothy Pearson <kb9vqf> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugwatch, darrella, kb9vqf |
| Priority: | P5 | ||
| Version: | R14.0.0 [Trinity] | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Compiler Version: | TDE Version String: | ||
| Application Version: | Application Name: | ||
| Bug Depends on: | |||
| Bug Blocks: | 2014 | ||
|
Description
Darrell
2014-02-04 15:11:02 CST
Can you post an example snippet so that I know what exactly you are referring to? Thanks! Tim >Can you post an example snippet so that I know what exactly you are referring to? I just grepped the sources. Best I can tell is the remnants are in po files. >Side note: starting kinfocenter from the command line or >Alt+F2 with KDE4 installed starts the KDE4 version because >kinfocenter no longer exists anywhere in Trinity. I wonder whether TDE should add a sym link: $TDEDIR/bin/kinfocenter->$TDEDIR/bin/khelpcenter (Peripherals->Information). I just grepped the source again; most of these are .po files as stated in tde-i18n. There are several docbooks that need to be cleaned up as well. Should the .po files block R14? I'm not sure what the harm is of shipping some obsolete translations. As I do not yet know how those .po files were generated and/or updated in the first place this could end up being a lengthy sticking point. >Should the .po files block R14?
I don't think so. The bug report should be left open.
Should also be left open to address the corner case of KDE4 kinfocenter opening.
I am going though and removing references now. First commit is GIT hash f285b77 (tdelibs); more to come. However, I am concerned we lost something when we dropped the info center. In a single Amarok translation file there is a reference to a Protocols section in kinfocenter that does not appear to exist in kcontrol. Digging further yielded this screenshot: http://slaout.linux62.org/kde-wishs/kio-wizard/ Did such a module exist in kcontrol at one point? I don't want to modify the Amarok translation string until we know if this is missing in kcontrol and needs to be added back in. The Protocols module was removed in commit 50741cc5 2014-02-10. Background discussions for the patch are in bug 1920. (In reply to Darrell from comment #6) > The Protocols module was removed in commit 50741cc5 2014-02-10. Background > discussions for the patch are in bug 1920. OK, thanks for that info. Remaining references removed in GIT hashes 4344b69 (tde-i18n) and e5dadd5 (amarok). Thanks for reporting! |