Bug 1942

If run with

  --disable-sqlite3 \

the build will proceed, but unless you specifically disable sqlite3, this build fails. The sqlite3 source is not updated for tqt and the automake files associated with the sqlite3 source included in kmymoney are broken.

In fact you have to explicitly disable nearly all kmymoney options of the build fails. Unless you have 'html2ps' installed, you must specifically --disable-pdf-docs. If you do install html2ps, pdf doc generation does in fact work. However, a number of distributions do not offer html2ps as an available standard package. A reasonable build test for html2ps is:

  if test -x "/usr/bin/html2ps"; then
    enable_pdfdocs='--enable-pdf-docs'
  else
    enable_pdfdocs='--disable-pdf-docs'
  fi

++ the point being, the autoconf setup should handle this without user intervention.

The 23011-qt-sqlite3-0.2.tar.gz contained within the tree is NOT updated to work with tqtinterface or tqt3.

Since you must --disable-sqlite3 to avoid build failure, there is now way possible to enable a database backend for kmymoney. 

All of these options are 'enabled' by default in the build config, so unless you specifically 'disable' all of the default options, the build fails. The only default build that I have found that works is:

  ./configure \
    --prefix=${TDEDIR} \
    --with-qt-dir=${QTDIR} \
    --with-qt-includes=${QTDIR}/include \
    --with-qt-libraries=${QTDIR}/lib \
    --with-extra-includes="/usr/include/tqt:/usr/include/tqt/Qt" \
    --with-extra-libs="${TDEDIR}/lib:${TDEDIR}/lib/trinity" \
    --sysconfdir=${TDEDIR}/etc \
    --localstatedir=/var \
    $enable_pdfdocs \
    --disable-ofxplugin \
    --disable-ofxbanking \
    --disable-sqlite3 \
    --disable-cppunit \
    --disable-online-tests \
    --disable-qtdesigner \
    --enable-closure

Now this is a "meaningful" goal to be included in a 14.0.1 target.

I build with:

  --disable-dependency-tracking \
  --disable-debug \
  --enable-new-ldflags \
  --disable-final \
  --enable-closure \
  --enable-rpath \
  --disable-gcc-hidden-visibility \
  \
  --with-qmake=/usr/bin/tqmake \
  --with-qt-dir=/usr/lib64/tqt3 \
  \
  --disable-pdf-docs \
  --enable-ofxplugin \
  --enable-ofxbanking \
  --enable-qtdesigner \

(En réponse au commentaire 3)
And forgot last line:
  --disable-sqlite3

Building with all options disable results in the following behavior:

1st use - Ability to import contact information from address book is broken; there is no validation of routing number; and crashes when you first click on the account created during setup. The kcrash for kmymoney is included as an attachment.

Created attachment 1937 [details]
kcrash when clicking in account created during 1st use

Evaluating kmymoney first use. kmymoney crashed. After initial setup, I clicked on the accounts, then on the [icon] for my first account created. kmymoney segfaulted. The build was:

  ./configure \
    --prefix=${TDEDIR} \
    --with-qt-dir=${QTDIR} \
    --with-qt-includes=${QTDIR}/include \
    --with-qt-libraries=${QTDIR}/lib \
    --with-extra-includes="/usr/include/tqt:/usr/include/tqt/Qt" \
    --with-extra-libs="${TDEDIR}/lib:${TDEDIR}/lib/trinity" \
    --sysconfdir=${TDEDIR}/etc \
    --localstatedir=/var \
    $enable_pdfdocs \
    --disable-ofxplugin \
    --disable-ofxbanking \
    --disable-sqlite3 \
    --disable-cppunit \
    --disable-online-tests \
    --disable-qtdesigner \
    --enable-closure

  make $NUMJOBS # VERBOSE=1

(In reply to comment #4)
> (En réponse au commentaire 3)
> And forgot last line:
>   --disable-sqlite3

I knew you had to be building with that one :)

(In reply to comment #4)
> (En réponse au commentaire 3)
> And forgot last line:
>   --disable-sqlite3

Francios,

  Have you looked into what it would take to fix the build with sqlite3? kmymoney continues under active development in kde4, so it isn't some abandoned packaged hanging off the git tree. The initial problem I identified with the files in 23011-qt-sqlite3-0.2.tar.gz not being renamed q->tq is easily fixed. However, I still cannot make any progress building with --enable-sqlite3 due to the smain.cpp build failure:

  'fatal error: tqsqldriverplugin.h: No such file or directory'

  That file is present on the system as noted. Any ideas?

  Also, after receiving your build configuration, I updated dependencies to include 'libofx' and rebuilt kmymoney as follows:

  ./configure \
    --prefix=${TDEDIR} \
    --with-qmake=${QTDIR}/bin/tqmake \
    --with-qt-dir=${QTDIR} \
    --with-qt-includes=${QTDIR}/include \
    --with-qt-libraries=${QTDIR}/lib \
    --with-extra-includes="/usr/include/tqt:/usr/include/tqt/Qt" \
    --with-extra-libs="${TDEDIR}/lib:${TDEDIR}/lib/trinity" \
    --sysconfdir=${TDEDIR}/etc \
    --localstatedir=/var \
    --disable-dependency-tracking \
    --disable-gcc-hidden-visibility \
    $enable_pdfdocs \
    --pdfdir=${TDEDIR}/share/doc \
    --psdir=${TDEDIR}/share/doc \
    --htmldir=${TDEDIR}/share/doc \
    --enable-new-ldflags \
    --enable-rpath \
    --enable-ofxplugin \
    --enable-ofxbanking \
    --enable-qtdesigner \
    --disable-sqlite3 \
    --enable-qtdesigner \
    --disable-debug \
    --disable-final \
    --enable-closure

The build completed 100% then crashed with:

/usr/bin/install: cannot stat '/build/tde-kmymoney/src/kmymoney/kmymoney2/widgets/kmymoneytitlelabel.png': No such file or directory

What happened to this icon?

(In reply to comment #8)
> (In reply to comment #4)
> > (En réponse au commentaire 3)
> > And forgot last line:
> >   --disable-sqlite3
> 
> Francios,
> 
>   Have you looked into what it would take to fix the build with sqlite3?
> kmymoney continues under active development in kde4, so it isn't some abandoned
> packaged hanging off the git tree. The initial problem I identified with the
> files in 23011-qt-sqlite3-0.2.tar.gz not being renamed q->tq is easily fixed.
> However, I still cannot make any progress building with --enable-sqlite3 due to
> the smain.cpp build failure:
> 
>   'fatal error: tqsqldriverplugin.h: No such file or directory'
> 
>   That file is present on the system as noted. Any ideas?
> 
>   Also, after receiving your build configuration, I updated dependencies to
> include 'libofx' and rebuilt kmymoney as follows:
> 
>   ./configure \
>     --prefix=${TDEDIR} \
>     --with-qmake=${QTDIR}/bin/tqmake \
>     --with-qt-dir=${QTDIR} \
>     --with-qt-includes=${QTDIR}/include \
>     --with-qt-libraries=${QTDIR}/lib \
>     --with-extra-includes="/usr/include/tqt:/usr/include/tqt/Qt" \
>     --with-extra-libs="${TDEDIR}/lib:${TDEDIR}/lib/trinity" \
>     --sysconfdir=${TDEDIR}/etc \
>     --localstatedir=/var \
>     --disable-dependency-tracking \
>     --disable-gcc-hidden-visibility \
>     $enable_pdfdocs \
>     --pdfdir=${TDEDIR}/share/doc \
>     --psdir=${TDEDIR}/share/doc \
>     --htmldir=${TDEDIR}/share/doc \
>     --enable-new-ldflags \
>     --enable-rpath \
>     --enable-ofxplugin \
>     --enable-ofxbanking \
>     --enable-qtdesigner \
>     --disable-sqlite3 \
>     --enable-qtdesigner \
>     --disable-debug \
>     --disable-final \
>     --enable-closure
> 
> The build completed 100% then crashed with:
> 
> /usr/bin/install: cannot stat
> '/build/tde-kmymoney/src/kmymoney/kmymoney2/widgets/kmymoneytitlelabel.png': No
> such file or directory
> 
> What happened to this icon?

Here is the answer from the changelog at sourceforge:

2011-05-21 06:32  conet

	* kmymoney/widgets/CMakeLists.txt,
	  kmymoney/widgets/kmymoneytitlelabel.png: Remove unused file.

http://kmymoney2.sourceforge.net/ChangeLog-4.5.95.txt

I'll work on a patch.

Created attachment 1938 [details]
kmymoneytitlelable.png icon necessary for build (attachment corrupted)

The above icon is the needed icon that should be placed in the following directory to allow the kmymoney package to "make install" without failure. This icon has been removed from the current version of kmymoney at sourceforge, but is still necessary for the TDE version to build.

(In reply to comment #10)
> Created attachment 1938 [details]
> kmymoneytitlelable.png icon necessary for build
> 
> The above icon is the needed icon that should be placed in the following
> directory to allow the kmymoney package to "make install" without failure. This
> icon has been removed from the current version of kmymoney at sourceforge, but
> is still necessary for the TDE version to build.

/tde/main/applications/kmymoney/kmymoney2/widgets

(En réponse au commentaire 8)
> (In reply to comment #4)
> > (En réponse au commentaire 3)
> > And forgot last line:
> >   --disable-sqlite3
> 
> Francios,
> 
>   Have you looked into what it would take to fix the build with sqlite3?
> kmymoney continues under active development in kde4, so it isn't some abandoned
> packaged hanging off the git tree. The initial problem I identified with the
> files in 23011-qt-sqlite3-0.2.tar.gz not being renamed q->tq is easily fixed.
> However, I still cannot make any progress building with --enable-sqlite3 due to
> the smain.cpp build failure:
> 
>   'fatal error: tqsqldriverplugin.h: No such file or directory'
> 
>   That file is present on the system as noted. Any ideas?


Yes, I just tried to convert the sqlite3 tarball (using the TDE qt3/tqt conversion script), add the --enable-sqlite3 option to ./configure, and it builds as it should.

I just need to set environment variable QTDIR because the plugin is installed under $QTDIR/plugins/sqldrivers :
  export QTDIR=/usr/lib64/tqt3

Output file is:
  /usr/lib64/tqt3/plugins/sqldrivers/libsqlite3.lib64.so

The program runs without crashing (I did no extensive test, just opening some menus and panels, typing some data ...)

Created attachment 1964 [details]
Remove unused kmymoneytitlelable.png from installation

If the picture is never used, it is preferable to not install it.

Comment on attachment 1964 [details]
Remove unused kmymoneytitlelable.png from installation

Pushed to GIT in hash 2031fb9c.

Comment on attachment 1938 [details]
kmymoneytitlelable.png icon necessary for build (attachment corrupted)

Can you please resubmit this attachment?  It was corrupted in the Bugzilla upgrade.

Thanks!

Created attachment 2061 [details]
tqt3 : add sqlite3 plugin

I considered how to deal with sqlite3 plugin, and I believe that the only correct way is to integrate plugin into TQt3. 

I updated the plugin into line with current TQtSqlCachedResult and incorporate into TQt3. Please test attached patch.

Are any build configuration changes needed for tqt3?

(In reply to Darrell from comment #17)
> Are any build configuration changes needed for tqt3?

Yes, new option is: -plugin-sql-sqlite3
And need to have installed sqlite3 library devel.

Are these two options still distinct?

-plugin-sql-sqlite
-plugin-sql-sqlite3

(In reply to Darrell from comment #19)
> Are these two options still distinct?
> 
> -plugin-sql-sqlite
> -plugin-sql-sqlite3

Yes, these are two separate plugins, although both are designed for sqlite. Original sqlite plugin uses build-in sqlite (see src/3rtparty/sqlite). The new plugin is designed for sqlite3 and sqlite3 library is linked dynamically.

I do not know whether we can discard the original plugin - I do not know where it is used. Therefore, I propose to defer the decision until later.

With the latest tqt3 patch, kmymoney FTBFS, failing during the configuration stage:

checking if the SQLITE3 support is desired... auto
checking if the SQLITE3 support is already present... no
checking sqlite3.h usability... yes
checking sqlite3.h presence... yes
checking for sqlite3.h... yes
checking if the environment variable QTDIR is set... /opt/trinity
./configure: line 27334: /opt/trinity/bin/qmake: No such file or directory
sed: can't read Makefile: No such file or directory
sed: can't read Makefile: No such file or directory

Created attachment 2065 [details]
kmymoney : fix sqlite3 plugin detection

As I found, the problem is just a typo - plugin name is not libsqlite3.so, but libqsqlite3.so. The essential is the fact that this is a change in common admin module => causes update virtually all modules.

The patch in attachment 2065 [details] resolved the configurtion failure. The package buit without error. I don't use kmymoney and did not test sqlite3 support.

I presume the final patch has to be applied to common/admin?

Created attachment 2066 [details]
kmymoney : fix sqlite3 plugin detection (1)

One modification: TQt plugins folder is determined from the configuration, instead of a fixed path derived from QTDIR.

Yes, the final patch will have to be pushed into the common admin module.

Updated patch works fine for me. Same as before: no usability testing performed.

Note 0: Reason of above adjustments see commit 848ba262 - bug 1151.

Note 1: With the incorporation of the plugin into TQt3 will be removed the appropriate tarball from KMyMoney.

Note 2: François, thank you for the conversion Qt => TQt. For integration into TQt3 I used version, which you have prepared. 

Note 3: Darrell, thank you for quick testing.

Note 4: I use KMyMoney, but without a database. Therefore I also do not test database usability.

Comment on attachment 1937 [details]
kcrash when clicking in account created during 1st use

Crashes of this type have been fixed by commit 5da15f81 (TQt3).

Comment on attachment 2061 [details]
tqt3 : add sqlite3 plugin

Pushed to GIT in hash d738b733 (Qt3) and a44a713f (TQt3).

Comment on attachment 2066 [details]
kmymoney : fix sqlite3 plugin detection (1)

Pushed to GIT in hash c413f606 (common-admin) and fc69c94a (kmymoney).