Bug 1955

Created attachment 1944 [details]
kxmleditor : add missing linker flags

Apply this patch after QT3/TQT and KDE3/TDE conversion script.

Created attachment 1945 [details]
kxmleditor : fix FTBFS

This patch allows to build without adding "-fpermissive" to the build options.

Here is how I built it.
Adapt various path according to your computer.
These instructions are a good starting point for porting any KDE3 application to TDE.



cd ~/src
rm -rf kxmleditor-1.1.4
tar xfz ~/src/kxmleditor-1.1.4.tar.gz
cd kxmleditor-1.1.4

rm -rf admin
~/tde/tde_r14/experimental/qt3-tqt3/convert_existing_qt3_app_to_tqt3
~/tde/tde_r14/experimental/kde-tde/convert_existing_kde3_app_to_tde


patch -p1 < /tmp/kxmleditor-fix-ftbfs-permissive.patch
patch -p1 < /tmp/kxmleditor-missing-ldflags.patch

cp -rf ~/tde/tde_r14/main/common/admin/ .
cp -f "/usr/share/aclocal/libtool.m4" "admin/libtool.m4.in"
cp -f "/usr/share/libtool/config/ltmain.sh" "admin/ltmain.sh" || cp -f "/usr/share/libtool/ltmain.sh" "admin/ltmain.sh"
make -f "admin/Makefile.common"

unset QTDIR QTINC QTLIB
which tde-config || export PATH="/opt/trinity/bin:${PATH}"

./configure \
  --prefix=/opt/trinity \
    \
  --disable-dependency-tracking \
  --disable-debug \
  --enable-new-ldflags \
  --enable-final \
  --enable-closure \
  --enable-rpath \
  --disable-gcc-hidden-visibility

make
make install

These are the changes that allowed kxmleditor to build:

# ~/tde/tde/experimental/qt3-tqt3/convert_existing_qt3_app_to_tqt3
# ~/tde/tde/experimental/kde-tde/convert_existing_kde3_app_to_tde
# cp -r ~/tde/tde/main/common/admin .
# sed -i 's/LIB_KFILE/LIB_TDEFILE/' kxmleditor/kxmleditor/Makefile.am
# sed -i 's/LIB_KFILE/LIB_TDEFILE/' kxmleditor/part/Makefile.am
# sed -i 's/LIB_KFILE/LIB_TDEFILE/' kxmleditor/part/Makefile.in
# kxmleditor/Makefile.am: kxmleditor_LDFLAGS = $(all_libraries) $(KDE_RPATH) $(LIB_QT) -lDCOP $(LIB_TDECORE) $(LIB_TDEUI) -ltdefx 

Basically, I copied the libraries from kdiff3. I think the only one that was missing was -lDCOP. Confirm the rest are needed. It builds fine with the above. I'll test Francios patch

Works Great!

http://www.3111skyline.com/dl/dt/trinity/ss/kxmleditor.jpg

When you push the source to the git-tree, we will need to update the kmenu location. It currently installs to:

kmenu/Utilities/KDE3/Editors

  we need to patch it to install at

kmenu/Utilities/Editors

  We should also move or duplicate

kmenu/Utilities/File/kHexEdit

  in

kmenu/Utilities/Editors.

  That way ALL of the editors (text, hex and xml) are all available under Editors.

Created attachment 1958 [details]
kxmleditor source to add to tde/main/applications (attachment corrupted)

This is the kxmleditor source code converted to TQt/TDE that contains both patches from Francios (1944 & 1945). This is the code to go in the tree.

As I mentioned earlier, for inclusion in the GIT tree will not use the result of the conversion, but the original source and the individual process steps.

Thank you both for prepare conversion process and testing the application.

Created attachment 1963 [details]
Updated KXML Editor sources (attachment corrupted)

Attached is an updated tarball of the kxmleditor sources.

This app needed cleanup work.

* Add a GenericName in the *.desktop file for the menu.

* Updated the Categories key to ensure the app appeared in the (Development) menu.

* Updated two obsolete icons in the Settings configuration dialog because they defaulted to the "Empty" icon.

* Updated outdated help handbook descriptions that no longer reflected the actual Settings dialog.

* Updated respective screenshots.

* Cruft files were removed.

* KDE->TDE changes.

* Nominal spell check of the help handbook.

The app builds and functions on Slackware 32-bit. A Debian user will need to review for packaging requirements.

Please not this report is tagged as PATCHAVAIL but the attachment is actually a source tarball.

Configuration options:

CFLAGS=$CPUOPT \
CXXFLAGS=$CPUOPT \
./configure \
  --prefix=${PREFIX} \
  --sysconfdir=${SYSCONFDIR} \
  --libdir=${LIBDIR} \
  --mandir=${MANDIR} \
  --with-qt-dir=${QTDIR} \
  --with-qt-includes=${QT_INCLUDE_DIR} \
  --with-qt-libraries=${QT_LIB_DIR} \
  $DEBUG_AUTOTOOL_OPT || exit 1

Please do not mark patches as obsolete. As I said earlier, for inclusion in the GIT will be incorporated first the original source code, then all subsequent steps of conversion and patches.

I would prefer the code that goes into the tree to go in the directory 'kxmleditor' and not 'kxmleditor-1.1.4'. Retaining the original version string complicates building. Then the conversions can be applied. I assume that is what you mean Slavek?

Slavek so the original source to go in the tree will be available to 3.5.13.2 and then the commits to convert to r14 will make the converted source available. OK, I see that.

Comment on attachment 1958 [details]
kxmleditor source to add to tde/main/applications (attachment corrupted)

Can you please resubmit this attachment?  It was corrupted in the Bugzilla upgrade.

Thanks!

Comment on attachment 1963 [details]
Updated KXML Editor sources (attachment corrupted)

Can you please resubmit this attachment?  It was corrupted in the Bugzilla upgrade.

Thanks!

Application is ready for R14.1.0 - http://mirror.git.trinitydesktop.org/cgit/kxmleditor/