By default, Bugzilla does not search the list of RESOLVED bugs.
You can force it to do so by putting the upper-case word ALL in front of your search query, e.g.: ALL tdelibs
We recommend searching for bugs this way, as you may discover that your bug has already been resolved and fixed in a later release.

Bug 1987

Summary:	Build issue: kopete-otr FTBFS with libotr 4.0
Product:	TDE	Reporter:	Darrell <darrella>
Component:	non-core programs	Assignee:	Timothy Pearson <kb9vqf>
Status:	RESOLVED FIXED
Severity:	normal	CC:	albator78, bugwatch, darrella, kb9vqf, slavek.banko
Priority:	P5
Version:	R14.0.0 [Trinity]
Hardware:	Other
OS:	Linux
Compiler Version:		TDE Version String:
Application Version:		Application Name:
Bug Depends on:
Bug Blocks:	2014
Attachments:	Patch to fix configure warnings with libotr

Description Darrell 2014-03-01 20:47:39 CST

I am unable to build older versions of libotr. With libotr 4.0 I receive the following build failures:

checking libotr/version.h usability... yes
checking libotr/version.h presence... no
configure: WARNING: libotr/version.h: accepted by the compiler, rejected by the preprocessor!
configure: WARNING: libotr/version.h: proceeding with the compiler's result
checking for libotr/version.h... yes
checking for libotr CFLAGS...
checking for libotr LIBS...  -lotr
checking for libotr headers version 3.x >= 3.1.0... not present.
checking for otrl_message_receiving in -lotr... yes
configure: error: libotr 3.1.0 or newer is required.
There was an error trying to build kopete-otr.

Comment 1 Darrell 2014-03-04 17:27:51 CST

Created attachment 1979 [details]
Patch to fix configure warnings with libotr

I am able to build against libotr 3.2.0. I see the same configure warnings:

configure: WARNING: libotr/version.h: accepted by the compiler, rejected by the preprocessor!
configure: WARNING: libotr/version.h: proceeding with the compiler's result

Proposed patch attached.

The patch does not allow kopete-otr to build against libotr 4.0.

Comment 2 Francois Andriot 2014-07-28 12:01:23 CDT

I'm currently looking to backport KDE4 patch to TDE to enable libotr 4.0.0 support in kopete-otr.

https://projects.kde.org/projects/kde/kdenetwork/kopete/repository/revisions/b977f1f701afd1f9192f35e0263f2f1c04bef53e

Comment 3 Francois Andriot 2014-07-28 16:00:33 CDT

Alas, the KDE4 patch uses features that did not exist in our old Kopete version.
It looks like backporting libotr 4.0.0 support is a dead end for now  ...

Comment 4 Timothy Pearson 2014-09-22 17:24:31 CDT

I have added support for libotr 4.x in GIT hash 1b9b8e3.

While the package builds, I have not tested it for functionality.  Can someone who is familiar with kopete-otr please test and verify proper operation with libotr 4.x?

Thanks!

Comment 5 Timothy Pearson 2014-09-22 17:27:12 CDT

Comment on attachment 1979 [details]
Patch to fix configure warnings with libotr

Patch is not needed as proper OTR version detection is now in GIT.

Comment 6 Timothy Pearson 2014-10-02 12:56:45 CDT

I will be closing this bug in a few days unless the new libotr support fails when someone tests it.

Comment 7 Darrell 2014-10-04 19:24:37 CDT

I now can build kopete-otr with libotr 4.0. While the package builds, I see the following warnings:

configure: WARNING: libotr/version.h: accepted by the compiler, rejected by the preprocessor!
configure: WARNING: libotr/version.h: proceeding with the compiler's result

Comment 8 Timothy Pearson 2014-10-04 23:50:10 CDT

(In reply to Darrell from comment #7)
> I now can build kopete-otr with libotr 4.0. While the package builds, I see
> the following warnings:
> 
> configure: WARNING: libotr/version.h: accepted by the compiler, rejected by
> the preprocessor!
> configure: WARNING: libotr/version.h: proceeding with the compiler's result

Taking your patch in attachment 1979 [details] fixed the warnings.

Pushed to GIT in hash dd9b16e.

I'm going to close this report as apparently building is OK and testing has not occurred or has not yielded any bugs.  If bugs do occur they should probably be handled in a new report anyway.

Thanks for reporting and testing!